[GitHub] lucene-solr issue #226: LUCENE-7655 Speed up geo-distance queries that match...
Github user mzasada commented on the issue: https://github.com/apache/lucene-solr/pull/226 No worries :) Thx for a review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr issue #226: LUCENE-7655 Speed up geo-distance queries that match...
Github user jpountz commented on the issue: https://github.com/apache/lucene-solr/pull/226 Oh, nevermind my previous comment then. I had missed the new test! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr issue #226: LUCENE-7655 Speed up geo-distance queries that match...
Github user mzasada commented on the issue: https://github.com/apache/lucene-solr/pull/226 That was my intention when I added `TestLatLonPointQueries#testDistanceQueryWithInvertedIntersection` unit test. Should I improve it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr issue #226: LUCENE-7655 Speed up geo-distance queries that match...
Github user jpountz commented on the issue: https://github.com/apache/lucene-solr/pull/226 The change looks good to me. Maybe we should look into writing at least one test that explicitly tests this case? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
