[GitHub] lucene-solr issue #313: SOLR-11924: Added a way to create collection set wat...
Github user dennisgove commented on the issue: https://github.com/apache/lucene-solr/pull/313 This looks good. I'm running through all tests now but I don't expect any issues to come up. Before I merge this in, would you mind rebasing off current master and collapsing this down to a single commit? --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr issue #313: SOLR-11924: Added a way to create collection set wat...
Github user HoustonPutman commented on the issue: https://github.com/apache/lucene-solr/pull/313 Changed the structure to follow the `LiveNodesListener` convention. This includes passing the previous set of collections as well as the new list of collections in each notification. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr issue #313: SOLR-11924: Added a way to create collection set wat...
Github user dennisgove commented on the issue: https://github.com/apache/lucene-solr/pull/313 I think following the structure in `LiveNodesListener` makes more sense. Perhaps a name of `CloudCollectionsSetListener` or `CloudCollectionsListener`. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr issue #313: SOLR-11924: Added a way to create collection set wat...
Github user HoustonPutman commented on the issue: https://github.com/apache/lucene-solr/pull/313 Regarding your comments: 1. I'm not sure when this would be necessary, however I tried to follow the convention used in `CollectionStateWatcher`. `LiveNodesListener` is a similar interface that doesn't return a value. Maybe it would be better to follow this convention. 2. The use case I need this for is keeping track of all collections that a cloud contains so that we can monitor each collection. It could also be useful for pre-populating State watchers for all collections, so that they aren't created whenever the state information is needed. I also have no qualms about changing the name of this interface, as I don't like the current name very much. It might be good to change it from a `Watcher` to a `Listener` if we decide to follow the `LiveNodesListener` convention instead of the `CollectionStateWatcher` convention for removing itself from the `zkStateReader`. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr issue #313: SOLR-11924: Added a way to create collection set wat...
Github user dennisgove commented on the issue: https://github.com/apache/lucene-solr/pull/313 Overall I think this is a good idea. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
