[GitHub] lucene-solr issue #375: LUCENE-8287: Ensure that empty regex completion quer...

2018-05-25 Thread jtibshirani
Github user jtibshirani commented on the issue: https://github.com/apache/lucene-solr/pull/375 Thank you @rmuir for the pointer, and I'm sorry for the slow reply! I just opened https://github.com/apache/lucene-solr/pull/383 to switch to `Operations.isEmpty` -- @jimczi feel free to

[GitHub] lucene-solr issue #375: LUCENE-8287: Ensure that empty regex completion quer...

2018-05-16 Thread rmuir
Github user rmuir commented on the issue: https://github.com/apache/lucene-solr/pull/375 {quote} When PrefixCompletionQuery has an empty term, its automaton is actually * -- maybe we could look into adding a fix/ optimization there in a follow-up. {quote} Regexp query

[GitHub] lucene-solr issue #375: LUCENE-8287: Ensure that empty regex completion quer...

2018-05-16 Thread jtibshirani
Github user jtibshirani commented on the issue: https://github.com/apache/lucene-solr/pull/375 I'm sorry for the confusion -- I didn't mean complete parity with `RegexpQuery`, as they are different queries with different behaviors, but rather consistency how they treat an empty

[GitHub] lucene-solr issue #375: LUCENE-8287: Ensure that empty regex completion quer...

2018-05-16 Thread jtibshirani
Github user jtibshirani commented on the issue: https://github.com/apache/lucene-solr/pull/375 @jimczi I tried a few different approaches (including updating `RegexCompletionQuery#rewrite`), and this one turned out to be cleanest + most consistent. I'm happy to give more details