[jira] [Comment Edited] (SOLR-7530) Wrong JSON response using Terms Component with distrib=true
[
https://issues.apache.org/jira/browse/SOLR-7530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865476#comment-16865476
]
Munendra S N edited comment on SOLR-7530 at 6/17/19 9:40 AM:
-
[^SOLR-7530.patch]
* Correct me if my understanding is wrong, changes in the Distrib test is to
validate parsed response returned by server. I have made minor changes so that
it validates not only JSON but javabin and xml response formats too. This could
probably be improved further. Also, this should be moved as part of base test
case
* I have changed the wordings a bit in CHANGES.txt, based on SOLR-1845. Should
the reason for choosing Namedlist(array) over SimpleOrderMap(Object/map) be
mentioned here??
* Also, test failure above doesn't look like related to this change
was (Author: munendrasn):
[^SOLR-7530.patch]
* Correct me if my understanding is wrong, changes in the Distrib test is to
validate parsed response returned by server. I have made minor changes so that
it validates not only JSON but javabin and xml response formats too. This could
probably be improved further. Also, this should be moved as part of base test
case
* I have changed the wordings a bit in CHANGES.txt, based on SOLR-1845. Should
the reason for choosing Namedlist(array) over SimpleOrderMap(Object/map) be
mentioned here??
> Wrong JSON response using Terms Component with distrib=true
> ---
>
> Key: SOLR-7530
> URL: https://issues.apache.org/jira/browse/SOLR-7530
> Project: Solr
> Issue Type: Bug
> Components: Response Writers, SearchComponents - other, SolrCloud
>Affects Versions: 4.9
>Reporter: Raúl Grande
>Assignee: Mikhail Khludnev
>Priority: Major
> Fix For: master (9.0)
>
> Attachments: SOLR-7530.patch, SOLR-7530.patch, SOLR-7530.patch,
> SOLR-7530.patch
>
>
> When using TermsComponent in SolrCloud there are differences in the JSON
> response if parameter distrib is true or false. If distrib=true JSON is not
> well formed (please note at the [ ] marks)
> JSON Response when distrib=false. Correct response:
> {"responseHeader":{
> "status":0,
> "QTime":3
> },
> "terms":{
> "FileType":
> [
> "EMAIL",20060,
> "PDF",7051,
> "IMAGE",5108,
> "OFFICE",4912,
> "TXT",4405,
> "OFFICE_EXCEL",4122,
> "OFFICE_WORD",2468
> ]
> } }
> JSON Response when distrib=true. Incorrect response:
> {
> "responseHeader":{
> "status":0,
> "QTime":94
> },
> "terms":{
> "FileType":{
> "EMAIL":31923,
> "PDF":11545,
> "IMAGE":9807,
> "OFFICE_EXCEL":8195,
> "OFFICE":5147,
> "OFFICE_WORD":4820,
> "TIFF":1156,
> "XML":851,
> "HTML":821,
> "RTF":303
> }
> } }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-7530) Wrong JSON response using Terms Component with distrib=true
[
https://issues.apache.org/jira/browse/SOLR-7530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837820#comment-16837820
]
Munendra S N edited comment on SOLR-7530 at 5/11/19 11:23 AM:
--
{quote}I'd like to commit array "FileType": [ "EMAIL",20060,... format into
master (9x) for both distrib modes. UPD ok. I've got that we can't
do that right now.
Personally I prefer object "FileType": { "EMAIL":20060,.., but array is
consistent with old facets. Right? Please confirm my understanding.{quote}
Even though it won't be consistent with old facets response, I prefer current
format returned in distributed mode. With NamedList response would look like
[this|https://issues.apache.org/jira/browse/SOLR-7530?focusedCommentId=16796038=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16796038]
when terms.ttf=true which I feel kind of ugly.
If we are going with old facets response format, should df-ttf response block
also be changed to NamedList?
{quote}ok. Let's introduce an optional parameter terms.format=9.0, which will
be always set at >= 9.0.
{quote}
Do we need this parameter? If this issue is committed only to master then we
won't require above parameter right?
was (Author: munendrasn):
{quote}I'd like to commit array "FileType": [ "EMAIL",20060,... format into
master (9x) for both distrib modes. UPD ok. I've got that we can't
do that right now.
Personally I prefer object "FileType": { "EMAIL":20060,.., but array is
consistent with old facets. Right? Please confirm my understanding.{quote}
Even though it won't be consistent with old facets response, I prefer current
format returned in distributed mode. With NamedList response would look
[like|https://issues.apache.org/jira/browse/SOLR-7530?focusedCommentId=16796038=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16796038]
when terms.ttf=true which I feel kind of ugly.
If we are going old facets response format, should df-ttf response block also
be changed to NamedList??
{quote}ok. Let's introduce an optional parameter terms.format=9.0, which will
be always set at >= 9.0.
{quote}
Do we need this?? If this issue is committed only to master then we won't
require above parameter right?
> Wrong JSON response using Terms Component with distrib=true
> ---
>
> Key: SOLR-7530
> URL: https://issues.apache.org/jira/browse/SOLR-7530
> Project: Solr
> Issue Type: Bug
> Components: Response Writers, SearchComponents - other, SolrCloud
>Affects Versions: 4.9
>Reporter: Raúl Grande
>Assignee: Mikhail Khludnev
>Priority: Major
> Fix For: master (9.0)
>
>
> When using TermsComponent in SolrCloud there are differences in the JSON
> response if parameter distrib is true or false. If distrib=true JSON is not
> well formed (please note at the [ ] marks)
> JSON Response when distrib=false. Correct response:
> {"responseHeader":{
> "status":0,
> "QTime":3
> },
> "terms":{
> "FileType":
> [
> "EMAIL",20060,
> "PDF",7051,
> "IMAGE",5108,
> "OFFICE",4912,
> "TXT",4405,
> "OFFICE_EXCEL",4122,
> "OFFICE_WORD",2468
> ]
> } }
> JSON Response when distrib=true. Incorrect response:
> {
> "responseHeader":{
> "status":0,
> "QTime":94
> },
> "terms":{
> "FileType":{
> "EMAIL":31923,
> "PDF":11545,
> "IMAGE":9807,
> "OFFICE_EXCEL":8195,
> "OFFICE":5147,
> "OFFICE_WORD":4820,
> "TIFF":1156,
> "XML":851,
> "HTML":821,
> "RTF":303
> }
> } }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-7530) Wrong JSON response using Terms Component with distrib=true
[
https://issues.apache.org/jira/browse/SOLR-7530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823489#comment-16823489
]
Mikhail Khludnev edited comment on SOLR-7530 at 4/23/19 11:43 AM:
--
I'd like -to commit- array {{"FileType": [ "EMAIL",20060,...}} format into
master (9x) for both distrib modes. *UPD* ok. I've got that we
can't do that right now.
Personally I prefer object {{"FileType": { "EMAIL":20060,..}}, but array is
consistent with old facets. Right? Please confirm my understanding.
was (Author: mkhludnev):
I'd like to commit array {{"FileType": [ "EMAIL",20060,...}} format into master
(9x) for both distrib modes.
Personally I prefer object {{"FileType": { "EMAIL":20060,..}}, but array is
consistent with old facets. Right? Please confirm my understanding.
> Wrong JSON response using Terms Component with distrib=true
> ---
>
> Key: SOLR-7530
> URL: https://issues.apache.org/jira/browse/SOLR-7530
> Project: Solr
> Issue Type: Bug
> Components: Response Writers, SearchComponents - other, SolrCloud
>Affects Versions: 4.9
>Reporter: Raúl Grande
>Priority: Major
>
> When using TermsComponent in SolrCloud there are differences in the JSON
> response if parameter distrib is true or false. If distrib=true JSON is not
> well formed (please note at the [ ] marks)
> JSON Response when distrib=false. Correct response:
> {"responseHeader":{
> "status":0,
> "QTime":3
> },
> "terms":{
> "FileType":
> [
> "EMAIL",20060,
> "PDF",7051,
> "IMAGE",5108,
> "OFFICE",4912,
> "TXT",4405,
> "OFFICE_EXCEL",4122,
> "OFFICE_WORD",2468
> ]
> } }
> JSON Response when distrib=true. Incorrect response:
> {
> "responseHeader":{
> "status":0,
> "QTime":94
> },
> "terms":{
> "FileType":{
> "EMAIL":31923,
> "PDF":11545,
> "IMAGE":9807,
> "OFFICE_EXCEL":8195,
> "OFFICE":5147,
> "OFFICE_WORD":4820,
> "TIFF":1156,
> "XML":851,
> "HTML":821,
> "RTF":303
> }
> } }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-7530) Wrong JSON response using Terms Component with distrib=true
[
https://issues.apache.org/jira/browse/SOLR-7530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823489#comment-16823489
]
Mikhail Khludnev edited comment on SOLR-7530 at 4/22/19 9:27 PM:
-
I'd like to commit array {{"FileType": [ "EMAIL",20060,...}} format into master
(9x) for both distrib modes.
Personally I prefer object {{"FileType": { "EMAIL":20060,..}}, but array is
consistent with old facets. Right? Please confirm my understanding.
was (Author: mkhludnev):
I'd like to commit array {{ "FileType": [ "EMAIL",20060,...}} format into
master (9x) for both distrib modes.
Personally I prefer object {{ "FileType": { "EMAIL":20060,..}}, but array is
consistent with old facets. Right? Please confirm my understanding.
> Wrong JSON response using Terms Component with distrib=true
> ---
>
> Key: SOLR-7530
> URL: https://issues.apache.org/jira/browse/SOLR-7530
> Project: Solr
> Issue Type: Bug
> Components: Response Writers, SearchComponents - other, SolrCloud
>Affects Versions: 4.9
>Reporter: Raúl Grande
>Priority: Major
>
> When using TermsComponent in SolrCloud there are differences in the JSON
> response if parameter distrib is true or false. If distrib=true JSON is not
> well formed (please note at the [ ] marks)
> JSON Response when distrib=false. Correct response:
> {"responseHeader":{
> "status":0,
> "QTime":3
> },
> "terms":{
> "FileType":
> [
> "EMAIL",20060,
> "PDF",7051,
> "IMAGE",5108,
> "OFFICE",4912,
> "TXT",4405,
> "OFFICE_EXCEL",4122,
> "OFFICE_WORD",2468
> ]
> } }
> JSON Response when distrib=true. Incorrect response:
> {
> "responseHeader":{
> "status":0,
> "QTime":94
> },
> "terms":{
> "FileType":{
> "EMAIL":31923,
> "PDF":11545,
> "IMAGE":9807,
> "OFFICE_EXCEL":8195,
> "OFFICE":5147,
> "OFFICE_WORD":4820,
> "TIFF":1156,
> "XML":851,
> "HTML":821,
> "RTF":303
> }
> } }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
