[jira] [Commented] (LUCENE-3293) Use IOContext.READONCE in VarGapTermsIndexReader to load FST
[ https://issues.apache.org/jira/browse/LUCENE-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13063771#comment-13063771 ] Simon Willnauer commented on LUCENE-3293: - varun, patch looks good. I think you don't need to assign a new variable each time but pass the new IOContext directly. Can you please add javadoc comments to the new constructor to explain what it does? I don't understand your assert in the get method in the patch. can you explain? Use IOContext.READONCE in VarGapTermsIndexReader to load FST Key: LUCENE-3293 URL: https://issues.apache.org/jira/browse/LUCENE-3293 Project: Lucene - Java Issue Type: Task Components: core/codecs Affects Versions: 4.0 Reporter: Simon Willnauer Assignee: Varun Thacker Priority: Minor Fix For: 4.0 Attachments: LUCENE-3293.patch VarGapTermsIndexReader should pass READONCE context down when it opens/reads the FST. Yet, it should just replace the ctx passed in, ie if we are merging vs reading we want to differentiate. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3293) Use IOContext.READONCE in VarGapTermsIndexReader to load FST
[ https://issues.apache.org/jira/browse/LUCENE-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13063787#comment-13063787 ] Simon Willnauer commented on LUCENE-3293: - looks good I think this is ready to commit though. thoughts anyone? Use IOContext.READONCE in VarGapTermsIndexReader to load FST Key: LUCENE-3293 URL: https://issues.apache.org/jira/browse/LUCENE-3293 Project: Lucene - Java Issue Type: Task Components: core/codecs Affects Versions: 4.0 Reporter: Simon Willnauer Assignee: Varun Thacker Priority: Minor Fix For: 4.0 Attachments: LUCENE-3293.patch, LUCENE-3293.patch VarGapTermsIndexReader should pass READONCE context down when it opens/reads the FST. Yet, it should just replace the ctx passed in, ie if we are merging vs reading we want to differentiate. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3293) Use IOContext.READONCE in VarGapTermsIndexReader to load FST
[ https://issues.apache.org/jira/browse/LUCENE-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13063848#comment-13063848 ] Michael McCandless commented on LUCENE-3293: Patch looks good! Just add a space after the , in new IOContext(context,true) in VariableGapTermsIndexReader.java Use IOContext.READONCE in VarGapTermsIndexReader to load FST Key: LUCENE-3293 URL: https://issues.apache.org/jira/browse/LUCENE-3293 Project: Lucene - Java Issue Type: Task Components: core/codecs Affects Versions: 4.0 Reporter: Simon Willnauer Assignee: Varun Thacker Priority: Minor Fix For: 4.0 Attachments: LUCENE-3293.patch, LUCENE-3293.patch VarGapTermsIndexReader should pass READONCE context down when it opens/reads the FST. Yet, it should just replace the ctx passed in, ie if we are merging vs reading we want to differentiate. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
