[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-02-05 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352218#comment-16352218 ] Adrien Grand commented on LUCENE-4198: -- This change had an impact on the nightly benchmarks:  -

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-02-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350276#comment-16350276 ] ASF subversion and git services commented on LUCENE-4198: - Commit

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-02-01 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349648#comment-16349648 ] Steve Rowe commented on LUCENE-4198: {{TestSimpleTextPostingsFormat}} has failed reproducibly a

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-01-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347039#comment-16347039 ] ASF subversion and git services commented on LUCENE-4198: - Commit

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-01-31 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347035#comment-16347035 ] Adrien Grand commented on LUCENE-4198: -- Woops, thanks Steve. I'll fix asap. > Allow codecs to index

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-01-31 Thread Steve Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347016#comment-16347016 ] Steve Rowe commented on LUCENE-4198: My Jenkins found two reproducing Solr test failures that {{git

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-01-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346864#comment-16346864 ] ASF subversion and git services commented on LUCENE-4198: - Commit

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-01-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342865#comment-16342865 ] Robert Muir commented on LUCENE-4198: - Sorry, took me a long time (been traveling). I think the work

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-01-24 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338004#comment-16338004 ] Jim Ferenczi commented on LUCENE-4198: -- Ok thanks for the explanation. I looked briefly at

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-01-24 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337720#comment-16337720 ] Adrien Grand commented on LUCENE-4198: -- Thanks Jim for having a look! bq. the SlowImpactEnum

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-01-23 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335533#comment-16335533 ] Jim Ferenczi commented on LUCENE-4198: -- The patch looks great. The new API seems contained and easy

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-01-19 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332335#comment-16332335 ] Adrien Grand commented on LUCENE-4198: -- Here is a new patch with a minor modification that makes

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-01-12 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324427#comment-16324427 ] Robert Muir commented on LUCENE-4198: - Yeah, its good to split it up into sizable chunks: we can

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-01-12 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324250#comment-16324250 ] Robert Muir commented on LUCENE-4198: - There are a lot of approaches for getting the same benefits

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-01-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324247#comment-16324247 ] Adrien Grand commented on LUCENE-4198: -- Correct, it is only good at computing the top-scoring hits.

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-01-12 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324234#comment-16324234 ] David Smiley commented on LUCENE-4198: -- Just so I'm clear on something: does this performance

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-01-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324101#comment-16324101 ] Adrien Grand commented on LUCENE-4198: -- I tested wikibigall as well, which has the benefit of not

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-01-06 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314678#comment-16314678 ] Robert Muir commented on LUCENE-4198: - {quote} Current take is to add

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-01-03 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310818#comment-16310818 ] Robert Muir commented on LUCENE-4198: - {quote} The similarity API doesn't make it easy to integrate,

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-01-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310061#comment-16310061 ] Adrien Grand commented on LUCENE-4198: -- Once we have block-based impacts, it should also be possible

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-01-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309842#comment-16309842 ] Adrien Grand commented on LUCENE-4198: -- Some things I forgot to mention: - this doesn't optimize