[
https://issues.apache.org/jira/browse/LUCENE-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13610872#comment-13610872
]
Commit Tag Bot commented on LUCENE-4252:
[branch_4x commit] Dawid Weiss
[
https://issues.apache.org/jira/browse/LUCENE-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424414#comment-13424414
]
Dawid Weiss commented on LUCENE-4252:
-
Yep, looks good to me and makes sense. When I
[
https://issues.apache.org/jira/browse/LUCENE-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422030#comment-13422030
]
Robert Muir commented on LUCENE-4252:
-
I think this patch should probably just count
[
https://issues.apache.org/jira/browse/LUCENE-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422039#comment-13422039
]
Uwe Schindler commented on LUCENE-4252:
---
Cool thing! +1 to add this check :-)
[
https://issues.apache.org/jira/browse/LUCENE-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422154#comment-13422154
]
Dawid Weiss commented on LUCENE-4252:
-
Static initializers will be very difficult
[
https://issues.apache.org/jira/browse/LUCENE-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422188#comment-13422188
]
Michael McCandless commented on LUCENE-4252:
+1, thanks Robert!
[
https://issues.apache.org/jira/browse/LUCENE-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422203#comment-13422203
]
Robert Muir commented on LUCENE-4252:
-
I already set this threshold as low as 512KB
[
https://issues.apache.org/jira/browse/LUCENE-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422204#comment-13422204
]
Robert Muir commented on LUCENE-4252:
-
{quote}
The only thing is that I'd rather move
[
https://issues.apache.org/jira/browse/LUCENE-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422596#comment-13422596
]
Dawid Weiss commented on LUCENE-4252:
-
bq. I didnt want to make all test stacktraces
[
https://issues.apache.org/jira/browse/LUCENE-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422772#comment-13422772
]
Robert Muir commented on LUCENE-4252:
-
{quote}
I looked at the patch but I didn't see
10 matches
Mail list logo