[jira] [Commented] (LUCENE-4613) CompressingStoredFieldsWriter ignores the segment suffix if writing aborted
[ https://issues.apache.org/jira/browse/LUCENE-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13530196#comment-13530196 ] Commit Tag Bot commented on LUCENE-4613: [trunk commit] Adrien Grand http://svn.apache.org/viewvc?view=revisionrevision=1420907 LUCENE-4613: CompressingStoredFieldsFormat: fix .abort() when the segment suffix is not empty. CompressingStoredFieldsWriter ignores the segment suffix if writing aborted --- Key: LUCENE-4613 URL: https://issues.apache.org/jira/browse/LUCENE-4613 Project: Lucene - Core Issue Type: Bug Components: core/codecs Affects Versions: 4.1 Reporter: Renaud Delbru Fix For: 4.1 Attachments: LUCENE-4613.patch, LUCENE-4613.patch, LUCENE-4613.patch If the writing is aborted, CompressingStoredFieldsWriter does not remove partially-written files as the segment suffix is not taken into consideration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4613) CompressingStoredFieldsWriter ignores the segment suffix if writing aborted
[ https://issues.apache.org/jira/browse/LUCENE-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13530212#comment-13530212 ] Commit Tag Bot commented on LUCENE-4613: [branch_4x commit] Adrien Grand http://svn.apache.org/viewvc?view=revisionrevision=1420913 LUCENE-4613: CompressingStoredFieldsFormat: fix .abort() when the segment suffix is not empty (merged from r1420907). CompressingStoredFieldsWriter ignores the segment suffix if writing aborted --- Key: LUCENE-4613 URL: https://issues.apache.org/jira/browse/LUCENE-4613 Project: Lucene - Core Issue Type: Bug Components: core/codecs Affects Versions: 4.1 Reporter: Renaud Delbru Assignee: Adrien Grand Fix For: 4.1 Attachments: LUCENE-4613.patch, LUCENE-4613.patch, LUCENE-4613.patch If the writing is aborted, CompressingStoredFieldsWriter does not remove partially-written files as the segment suffix is not taken into consideration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4613) CompressingStoredFieldsWriter ignores the segment suffix if writing aborted
[ https://issues.apache.org/jira/browse/LUCENE-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528847#comment-13528847 ] Renaud Delbru commented on LUCENE-4613: --- Ok, I'll upload something today. CompressingStoredFieldsWriter ignores the segment suffix if writing aborted --- Key: LUCENE-4613 URL: https://issues.apache.org/jira/browse/LUCENE-4613 Project: Lucene - Core Issue Type: Bug Components: core/codecs Affects Versions: 4.1 Reporter: Renaud Delbru Fix For: 4.1 Attachments: LUCENE-4613.patch If the writing is aborted, CompressingStoredFieldsWriter does not remove partially-written files as the segment suffix is not taken into consideration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4613) CompressingStoredFieldsWriter ignores the segment suffix if writing aborted
[
https://issues.apache.org/jira/browse/LUCENE-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529008#comment-13529008
]
Adrien Grand commented on LUCENE-4613:
--
The test looks good!
bq. We might be able to improve this by adding or not randomly a segment suffix.
Yes I think it'd be even better. You can use
{{_TestUtil#randomSimpleString(Random, int maxLength)}}.
bq. Ant test has been executed and did not report any errors.
Same here.
CompressingStoredFieldsWriter ignores the segment suffix if writing aborted
---
Key: LUCENE-4613
URL: https://issues.apache.org/jira/browse/LUCENE-4613
Project: Lucene - Core
Issue Type: Bug
Components: core/codecs
Affects Versions: 4.1
Reporter: Renaud Delbru
Fix For: 4.1
Attachments: LUCENE-4613.patch, LUCENE-4613.patch
If the writing is aborted, CompressingStoredFieldsWriter does not remove
partially-written files as the segment suffix is not taken into consideration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4613) CompressingStoredFieldsWriter ignores the segment suffix if writing aborted
[
https://issues.apache.org/jira/browse/LUCENE-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529065#comment-13529065
]
Renaud Delbru commented on LUCENE-4613:
---
{quote}
Yes I think it'd be even better. You can use
_TestUtil#randomSimpleString(Random, int maxLength).
{quote}
In fact, using random segment suffix is very difficult to achieve, as we cannot
ensure that the codec instantiated through SPI will get the same segment suffix
as the codec instantiated in the {{TestCompressingStoredFieldsFormat#setUp()},
and therefore the {{_TestUtil#checkIndex(Directory dir)}} will fail. The
segment suffix must be deterministic, e.g., similar to the current solution
using the formatName as segment suffix.
CompressingStoredFieldsWriter ignores the segment suffix if writing aborted
---
Key: LUCENE-4613
URL: https://issues.apache.org/jira/browse/LUCENE-4613
Project: Lucene - Core
Issue Type: Bug
Components: core/codecs
Affects Versions: 4.1
Reporter: Renaud Delbru
Fix For: 4.1
Attachments: LUCENE-4613.patch, LUCENE-4613.patch
If the writing is aborted, CompressingStoredFieldsWriter does not remove
partially-written files as the segment suffix is not taken into consideration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4613) CompressingStoredFieldsWriter ignores the segment suffix if writing aborted
[ https://issues.apache.org/jira/browse/LUCENE-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529115#comment-13529115 ] Adrien Grand commented on LUCENE-4613: -- Oh right, I didn't think about that. I'll commit your patch shortly. CompressingStoredFieldsWriter ignores the segment suffix if writing aborted --- Key: LUCENE-4613 URL: https://issues.apache.org/jira/browse/LUCENE-4613 Project: Lucene - Core Issue Type: Bug Components: core/codecs Affects Versions: 4.1 Reporter: Renaud Delbru Fix For: 4.1 Attachments: LUCENE-4613.patch, LUCENE-4613.patch If the writing is aborted, CompressingStoredFieldsWriter does not remove partially-written files as the segment suffix is not taken into consideration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4613) CompressingStoredFieldsWriter ignores the segment suffix if writing aborted
[ https://issues.apache.org/jira/browse/LUCENE-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529152#comment-13529152 ] Adrien Grand commented on LUCENE-4613: -- Actually, there is one test that still doesn't pass (but the test is bogus, not your patch): ant test -Dtestcase=TestIndexFileDeleter -Dtests.method=testDeleteLeftoverFiles -Dtests.seed=A4C78ED2201BC821 -Dtests.slow=true -Dtests.codec=Compressing -Dtests.locale=es_UY -Dtests.timezone=Asia/Urumqi -Dtests.file.encoding=US-ASCII because it assumes the stored fields writer writes a file that ends with .fdt with no segment suffix. I'm not sure of the best way to fix this test independently of a codec impl... CompressingStoredFieldsWriter ignores the segment suffix if writing aborted --- Key: LUCENE-4613 URL: https://issues.apache.org/jira/browse/LUCENE-4613 Project: Lucene - Core Issue Type: Bug Components: core/codecs Affects Versions: 4.1 Reporter: Renaud Delbru Fix For: 4.1 Attachments: LUCENE-4613.patch, LUCENE-4613.patch If the writing is aborted, CompressingStoredFieldsWriter does not remove partially-written files as the segment suffix is not taken into consideration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4613) CompressingStoredFieldsWriter ignores the segment suffix if writing aborted
[
https://issues.apache.org/jira/browse/LUCENE-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529163#comment-13529163
]
Renaud Delbru commented on LUCENE-4613:
---
Maybe one solution would be to not change the behavior of
{{CompressingCodec#randomInstance(Random random)}}, and introduce a new method
{{CompressingCodec#randomInstance(Random random, boolean randomSegmentSuffix)}}
that is used in {{TestCompressingStoredFieldsFormat#setUp()}}. This will keep
backward compatibility with the other unit tests.
CompressingStoredFieldsWriter ignores the segment suffix if writing aborted
---
Key: LUCENE-4613
URL: https://issues.apache.org/jira/browse/LUCENE-4613
Project: Lucene - Core
Issue Type: Bug
Components: core/codecs
Affects Versions: 4.1
Reporter: Renaud Delbru
Fix For: 4.1
Attachments: LUCENE-4613.patch, LUCENE-4613.patch
If the writing is aborted, CompressingStoredFieldsWriter does not remove
partially-written files as the segment suffix is not taken into consideration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4613) CompressingStoredFieldsWriter ignores the segment suffix if writing aborted
[ https://issues.apache.org/jira/browse/LUCENE-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529473#comment-13529473 ] Adrien Grand commented on LUCENE-4613: -- Sounds good. Let's fix this test's assumptions later on... CompressingStoredFieldsWriter ignores the segment suffix if writing aborted --- Key: LUCENE-4613 URL: https://issues.apache.org/jira/browse/LUCENE-4613 Project: Lucene - Core Issue Type: Bug Components: core/codecs Affects Versions: 4.1 Reporter: Renaud Delbru Fix For: 4.1 Attachments: LUCENE-4613.patch, LUCENE-4613.patch If the writing is aborted, CompressingStoredFieldsWriter does not remove partially-written files as the segment suffix is not taken into consideration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4613) CompressingStoredFieldsWriter ignores the segment suffix if writing aborted
[ https://issues.apache.org/jira/browse/LUCENE-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528228#comment-13528228 ] Adrien Grand commented on LUCENE-4613: -- Good catch, Renaud! The patch looks good, can you add a test case to TestCompressingStoredFieldsFormat to make sure abort always removes files correctly? CompressingStoredFieldsWriter ignores the segment suffix if writing aborted --- Key: LUCENE-4613 URL: https://issues.apache.org/jira/browse/LUCENE-4613 Project: Lucene - Core Issue Type: Bug Components: core/codecs Affects Versions: 4.1 Reporter: Renaud Delbru Fix For: 4.1 Attachments: LUCENE-4613.patch If the writing is aborted, CompressingStoredFieldsWriter does not remove partially-written files as the segment suffix is not taken into consideration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
