[
https://issues.apache.org/jira/browse/LUCENE-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542896#comment-13542896
]
Robert Muir commented on LUCENE-4656:
-
I think this might be a broken assert in
[
https://issues.apache.org/jira/browse/LUCENE-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542900#comment-13542900
]
Robert Muir commented on LUCENE-4656:
-
I think we should fix BaseTokenStreamTestCase
[
https://issues.apache.org/jira/browse/LUCENE-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542899#comment-13542899
]
Adrien Grand commented on LUCENE-4656:
--
bq. Why do we have that?
It feels strange
[
https://issues.apache.org/jira/browse/LUCENE-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542902#comment-13542902
]
Robert Muir commented on LUCENE-4656:
-
{quote}
It feels strange to me that a
[
https://issues.apache.org/jira/browse/LUCENE-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542908#comment-13542908
]
Uwe Schindler commented on LUCENE-4656:
---
I am happy with both solutions. I agree,
[
https://issues.apache.org/jira/browse/LUCENE-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542910#comment-13542910
]
Uwe Schindler commented on LUCENE-4656:
---
We should at least test EmptyTokenizer
[
https://issues.apache.org/jira/browse/LUCENE-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542913#comment-13542913
]
Robert Muir commented on LUCENE-4656:
-
There is an EmptyTokenStream in src/java that
[
https://issues.apache.org/jira/browse/LUCENE-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542987#comment-13542987
]
Uwe Schindler commented on LUCENE-4656:
---
bq. I needed to add a quick hack to add a
[
https://issues.apache.org/jira/browse/LUCENE-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542995#comment-13542995
]
Adrien Grand commented on LUCENE-4656:
--
bq. So we should fix IndexWriter to handle
[
https://issues.apache.org/jira/browse/LUCENE-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13543009#comment-13543009
]
Robert Muir commented on LUCENE-4656:
-
I'm not really certain what it should do.
it
[
https://issues.apache.org/jira/browse/LUCENE-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13543017#comment-13543017
]
Uwe Schindler commented on LUCENE-4656:
---
The problem is here that the attributes
[
https://issues.apache.org/jira/browse/LUCENE-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13543095#comment-13543095
]
Uwe Schindler commented on LUCENE-4656:
---
Thanks Robert! I will merge again and I
[
https://issues.apache.org/jira/browse/LUCENE-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13543111#comment-13543111
]
Robert Muir commented on LUCENE-4656:
-
Slightly related to the BaseToken changes, i
13 matches
Mail list logo
