[jira] [Commented] (LUCENE-5153) Allow wrapping Reader from AnalyzerWrapper
[ https://issues.apache.org/jira/browse/LUCENE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13723936#comment-13723936 ] Shai Erera commented on LUCENE-5153: If there are no objections, I'll commit it. Allow wrapping Reader from AnalyzerWrapper -- Key: LUCENE-5153 URL: https://issues.apache.org/jira/browse/LUCENE-5153 Project: Lucene - Core Issue Type: New Feature Components: core/index Reporter: Shai Erera Assignee: Shai Erera Attachments: LUCENE-5153.patch It can be useful to allow AnalyzerWrapper extensions to wrap the Reader given to initReader, e.g. with a CharFilter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5153) Allow wrapping Reader from AnalyzerWrapper
[ https://issues.apache.org/jira/browse/LUCENE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13723941#comment-13723941 ] Robert Muir commented on LUCENE-5153: - One odd thing is that wrapComponents adds to the end of the TokenStream chain, but with this patch wrapReader inserts into the beginning of the charfilter chain. Not saying its wrong, but is it the right thing? Allow wrapping Reader from AnalyzerWrapper -- Key: LUCENE-5153 URL: https://issues.apache.org/jira/browse/LUCENE-5153 Project: Lucene - Core Issue Type: New Feature Components: core/index Reporter: Shai Erera Assignee: Shai Erera Attachments: LUCENE-5153.patch It can be useful to allow AnalyzerWrapper extensions to wrap the Reader given to initReader, e.g. with a CharFilter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5153) Allow wrapping Reader from AnalyzerWrapper
[ https://issues.apache.org/jira/browse/LUCENE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13723992#comment-13723992 ] Adrien Grand commented on LUCENE-5153: -- I think this is the right thing? On the opposite, if wrapReader inserted char filters at the end of the charfilter chain, the behavior of the wrapper analyzer would be altered (it would allow to insert something between the first CharFilter and the last TokenFilter of the wrapped analyzer). Allow wrapping Reader from AnalyzerWrapper -- Key: LUCENE-5153 URL: https://issues.apache.org/jira/browse/LUCENE-5153 Project: Lucene - Core Issue Type: New Feature Components: core/index Reporter: Shai Erera Assignee: Shai Erera Attachments: LUCENE-5153.patch It can be useful to allow AnalyzerWrapper extensions to wrap the Reader given to initReader, e.g. with a CharFilter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5153) Allow wrapping Reader from AnalyzerWrapper
[ https://issues.apache.org/jira/browse/LUCENE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13724119#comment-13724119 ] Shai Erera commented on LUCENE-5153: bq. I think this is the right thing? I tend to agree. If by wrapping we look at the wrapped object as a black box, then we should only allow intervention on its fronts -- before its char filters and after its token stream. Allow wrapping Reader from AnalyzerWrapper -- Key: LUCENE-5153 URL: https://issues.apache.org/jira/browse/LUCENE-5153 Project: Lucene - Core Issue Type: New Feature Components: core/index Reporter: Shai Erera Assignee: Shai Erera Attachments: LUCENE-5153.patch It can be useful to allow AnalyzerWrapper extensions to wrap the Reader given to initReader, e.g. with a CharFilter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5153) Allow wrapping Reader from AnalyzerWrapper
[ https://issues.apache.org/jira/browse/LUCENE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13724124#comment-13724124 ] Robert Muir commented on LUCENE-5153: - Sounds good to me! +1 to the patch, though we might want to add a test. Allow wrapping Reader from AnalyzerWrapper -- Key: LUCENE-5153 URL: https://issues.apache.org/jira/browse/LUCENE-5153 Project: Lucene - Core Issue Type: New Feature Components: core/index Reporter: Shai Erera Assignee: Shai Erera Attachments: LUCENE-5153.patch It can be useful to allow AnalyzerWrapper extensions to wrap the Reader given to initReader, e.g. with a CharFilter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5153) Allow wrapping Reader from AnalyzerWrapper
[ https://issues.apache.org/jira/browse/LUCENE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13724131#comment-13724131 ] Hoss Man commented on LUCENE-5153: -- FWIW: a recent thread on this very point... http://mail-archives.apache.org/mod_mbox/lucene-java-user/201306.mbox/%3cad079bd2-e01e-4e00-b8f6-17594b6c4...@likeness.com%3E +1 to the wrapReader semantics in the patch. Allow wrapping Reader from AnalyzerWrapper -- Key: LUCENE-5153 URL: https://issues.apache.org/jira/browse/LUCENE-5153 Project: Lucene - Core Issue Type: New Feature Components: core/index Reporter: Shai Erera Assignee: Shai Erera Attachments: LUCENE-5153.patch It can be useful to allow AnalyzerWrapper extensions to wrap the Reader given to initReader, e.g. with a CharFilter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5153) Allow wrapping Reader from AnalyzerWrapper
[ https://issues.apache.org/jira/browse/LUCENE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13724230#comment-13724230 ] Robert Muir commented on LUCENE-5153: - I dont see the test in the patch... but I think it should be under lucene/core (and just wrap MockAnalyzer with MockCharFilter or something). I think its good to make wrapComponents just return the components as a default. This will make PerFieldAnalyzerWrapper look less stupid :) the getWrappedAnalyzer is explained by its javadocs. You might want a different analyzer for different fields. Allow wrapping Reader from AnalyzerWrapper -- Key: LUCENE-5153 URL: https://issues.apache.org/jira/browse/LUCENE-5153 Project: Lucene - Core Issue Type: New Feature Components: core/index Reporter: Shai Erera Assignee: Shai Erera Attachments: LUCENE-5153.patch, LUCENE-5153.patch It can be useful to allow AnalyzerWrapper extensions to wrap the Reader given to initReader, e.g. with a CharFilter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5153) Allow wrapping Reader from AnalyzerWrapper
[ https://issues.apache.org/jira/browse/LUCENE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13724266#comment-13724266 ] Shai Erera commented on LUCENE-5153: bq. I dont see the test in the patch Hmm, I was sure I created a new patch. Will upload one soon, after I move the test under lucene/core. bq. I think its good to make wrapComponents just return the components as a default. Ok, will do. bq. the getWrappedAnalyzer is explained by its javadocs Duh, I should have read them before. :) Allow wrapping Reader from AnalyzerWrapper -- Key: LUCENE-5153 URL: https://issues.apache.org/jira/browse/LUCENE-5153 Project: Lucene - Core Issue Type: New Feature Components: core/index Reporter: Shai Erera Assignee: Shai Erera Attachments: LUCENE-5153.patch, LUCENE-5153.patch It can be useful to allow AnalyzerWrapper extensions to wrap the Reader given to initReader, e.g. with a CharFilter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5153) Allow wrapping Reader from AnalyzerWrapper
[ https://issues.apache.org/jira/browse/LUCENE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13724391#comment-13724391 ] ASF subversion and git services commented on LUCENE-5153: - Commit 1508622 from [~shaie] in branch 'dev/trunk' [ https://svn.apache.org/r1508622 ] LUCENE-5153: Allow wrapping Reader from AnalyzerWrapper Allow wrapping Reader from AnalyzerWrapper -- Key: LUCENE-5153 URL: https://issues.apache.org/jira/browse/LUCENE-5153 Project: Lucene - Core Issue Type: New Feature Components: core/index Reporter: Shai Erera Assignee: Shai Erera Attachments: LUCENE-5153.patch, LUCENE-5153.patch, LUCENE-5153.patch, LUCENE-5153.patch It can be useful to allow AnalyzerWrapper extensions to wrap the Reader given to initReader, e.g. with a CharFilter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5153) Allow wrapping Reader from AnalyzerWrapper
[ https://issues.apache.org/jira/browse/LUCENE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13724397#comment-13724397 ] ASF subversion and git services commented on LUCENE-5153: - Commit 1508623 from [~shaie] in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1508623 ] LUCENE-5153: Allow wrapping Reader from AnalyzerWrapper Allow wrapping Reader from AnalyzerWrapper -- Key: LUCENE-5153 URL: https://issues.apache.org/jira/browse/LUCENE-5153 Project: Lucene - Core Issue Type: New Feature Components: core/index Reporter: Shai Erera Assignee: Shai Erera Attachments: LUCENE-5153.patch, LUCENE-5153.patch, LUCENE-5153.patch, LUCENE-5153.patch It can be useful to allow AnalyzerWrapper extensions to wrap the Reader given to initReader, e.g. with a CharFilter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5153) Allow wrapping Reader from AnalyzerWrapper
[ https://issues.apache.org/jira/browse/LUCENE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13724461#comment-13724461 ] Uwe Schindler commented on LUCENE-5153: --- Thanks! Allow wrapping Reader from AnalyzerWrapper -- Key: LUCENE-5153 URL: https://issues.apache.org/jira/browse/LUCENE-5153 Project: Lucene - Core Issue Type: New Feature Components: core/index Reporter: Shai Erera Assignee: Shai Erera Fix For: 5.0, 4.5 Attachments: LUCENE-5153.patch, LUCENE-5153.patch, LUCENE-5153.patch, LUCENE-5153.patch It can be useful to allow AnalyzerWrapper extensions to wrap the Reader given to initReader, e.g. with a CharFilter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
