[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-10-04 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544807#comment-15544807 ] Adrien Grand commented on LUCENE-7453: -- Sorry, I did a typo in the commit message, this commit is

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-10-04 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544805#comment-15544805 ] ASF subversion and git services commented on LUCENE-7453: - Commit

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-22 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513380#comment-15513380 ] Yonik Seeley commented on LUCENE-7453: -- I don't think changing the name really helps a new user

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511145#comment-15511145 ] Paul Elschot commented on LUCENE-7453: -- bq. But the seg examples you have still have docid, just

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511085#comment-15511085 ] Dawid Weiss commented on LUCENE-7453: - Hoss, consider the possibilities of using non-ascii unicode

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Mikhail Khludnev (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511065#comment-15511065 ] Mikhail Khludnev commented on LUCENE-7453: -- Whatever you call name, let's have _dixi_ in code!

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511049#comment-15511049 ] Ryan Ernst commented on LUCENE-7453: bq. this is probably a multicriteria optimisation problem with

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Hoss Man (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511047#comment-15511047 ] Hoss Man commented on LUCENE-7453: -- We could just call it the {{huperDuperEphemeralPositionInIndex}} >

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511042#comment-15511042 ] Ryan Ernst commented on LUCENE-7453: bq. I don't like overloading index for this, especially in the

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511028#comment-15511028 ] Dawid Weiss commented on LUCENE-7453: - bq. [...] i meant the overloading of "index", because it is

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510965#comment-15510965 ] Paul Elschot commented on LUCENE-7453: -- I tried an alternative that adds an variation of segment

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510820#comment-15510820 ] Yonik Seeley commented on LUCENE-7453: -- Indeed, "docIndex" can also be read as "an index of

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510784#comment-15510784 ] Ryan Ernst commented on LUCENE-7453: bq. although I do dislike using such an overloaded term Just to

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510719#comment-15510719 ] Ryan Ernst commented on LUCENE-7453: I'm ok with {{docIndex}}, it is at least an improvement over

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509918#comment-15509918 ] Dawid Weiss commented on LUCENE-7453: - bq. [...] since everybody who has low-level integration with

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509889#comment-15509889 ] Adrien Grand commented on LUCENE-7453: -- bq. When you think of documents inside a reader as a

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509831#comment-15509831 ] Dawid Weiss commented on LUCENE-7453: - bq. Are you fine to get docIndex from IndexReader or

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Mikhail Khludnev (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509814#comment-15509814 ] Mikhail Khludnev commented on LUCENE-7453: -- c'mon. Are you fine to get {{docIndex}} from

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Mikhail Khludnev (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509799#comment-15509799 ] Mikhail Khludnev commented on LUCENE-7453: -- bq. what is "numbering" of documents? Numbering

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509734#comment-15509734 ] Uwe Schindler commented on LUCENE-7453: --- +1 to DocIndex. I see the problem like

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509692#comment-15509692 ] David Smiley commented on LUCENE-7453: -- +1 to docIndex -- nice name. Presumably we'd change both

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509458#comment-15509458 ] Dawid Weiss commented on LUCENE-7453: - The more I think about it, the more I think docIndex is

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509437#comment-15509437 ] Michael McCandless commented on LUCENE-7453: +1 for {{docIndex}}! > Change naming of

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509280#comment-15509280 ] Dawid Weiss commented on LUCENE-7453: - bq. I think docNum is a good improvement because it makes it

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509250#comment-15509250 ] Michael McCandless commented on LUCENE-7453: +1 to rename {{docId}} -> {{docNum}}. {{id}},

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509049#comment-15509049 ] Dawid Weiss commented on LUCENE-7453: - I'm in favor of cleaning up wording too -- don't get me wrong

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-20 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508210#comment-15508210 ] David Smiley commented on LUCENE-7453: -- bq. To me the difference between docnum and docid is really

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-20 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508004#comment-15508004 ] Paul Elschot commented on LUCENE-7453: -- I'm in favour, but it is going to be hard: {code} public

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-20 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507786#comment-15507786 ] Uwe Schindler commented on LUCENE-7453: --- I was the one who suggested that change. Imho the change

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-20 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507544#comment-15507544 ] Dawid Weiss commented on LUCENE-7453: - To me the difference between {{docnum}} and {{docid}} is