[jira] [Commented] (LUCENE-7491) Unexpected merge exception when merging sparse points fields
[
https://issues.apache.org/jira/browse/LUCENE-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15572057#comment-15572057
]
ASF subversion and git services commented on LUCENE-7491:
-
Commit 1a0786332d16eaefde013a4e075658387a3ae382 in lucene-solr's branch
refs/heads/branch_6x from Mike McCandless
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1a07863 ]
LUCENE-7491: also allow for merging segment with points before one without
points for a given field (thank you MockRandomMergePolicy!)
> Unexpected merge exception when merging sparse points fields
>
>
> Key: LUCENE-7491
> URL: https://issues.apache.org/jira/browse/LUCENE-7491
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Michael McCandless
>Assignee: Michael McCandless
> Fix For: master (7.0), 6.3
>
> Attachments: LUCENE-7491.patch, LUCENE-7491.patch
>
>
> Spinoff from this user thread: http://markmail.org/thread/vwdvjgupyz6heep5
> If you have a segment that has points, but a given field ("id") didn't index
> points, and a later segment where field "id" does index points, when try to
> merge those segments we hit this (incorrect!) exception:
> {noformat}
> Caused by: org.apache.lucene.index.MergePolicy$MergeException:
> java.lang.IllegalArgumentException: field="id" did not index point values
> at __randomizedtesting.SeedInfo.seed([9F3E7B030EF482BD]:0)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.handleMergeException(ConcurrentMergeScheduler.java:668)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:648)
> Caused by: java.lang.IllegalArgumentException: field="id" did not index point
> values
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsReader.getBKDReader(Lucene60PointsReader.java:126)
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsReader.size(Lucene60PointsReader.java:224)
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsWriter.merge(Lucene60PointsWriter.java:169)
> at
> org.apache.lucene.index.SegmentMerger.mergePoints(SegmentMerger.java:173)
> at org.apache.lucene.index.SegmentMerger.merge(SegmentMerger.java:122)
> at
> org.apache.lucene.index.IndexWriter.mergeMiddle(IndexWriter.java:4287)
> at org.apache.lucene.index.IndexWriter.merge(IndexWriter.java:3864)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.doMerge(ConcurrentMergeScheduler.java:588)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:626)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7491) Unexpected merge exception when merging sparse points fields
[
https://issues.apache.org/jira/browse/LUCENE-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15572059#comment-15572059
]
ASF subversion and git services commented on LUCENE-7491:
-
Commit f4d3ca89802d06087780d7b7a1e7516c6b0f94c7 in lucene-solr's branch
refs/heads/master from Mike McCandless
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f4d3ca8 ]
LUCENE-7491: also allow for merging segment with points before one without
points for a given field (thank you MockRandomMergePolicy!)
> Unexpected merge exception when merging sparse points fields
>
>
> Key: LUCENE-7491
> URL: https://issues.apache.org/jira/browse/LUCENE-7491
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Michael McCandless
>Assignee: Michael McCandless
> Fix For: master (7.0), 6.3
>
> Attachments: LUCENE-7491.patch, LUCENE-7491.patch
>
>
> Spinoff from this user thread: http://markmail.org/thread/vwdvjgupyz6heep5
> If you have a segment that has points, but a given field ("id") didn't index
> points, and a later segment where field "id" does index points, when try to
> merge those segments we hit this (incorrect!) exception:
> {noformat}
> Caused by: org.apache.lucene.index.MergePolicy$MergeException:
> java.lang.IllegalArgumentException: field="id" did not index point values
> at __randomizedtesting.SeedInfo.seed([9F3E7B030EF482BD]:0)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.handleMergeException(ConcurrentMergeScheduler.java:668)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:648)
> Caused by: java.lang.IllegalArgumentException: field="id" did not index point
> values
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsReader.getBKDReader(Lucene60PointsReader.java:126)
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsReader.size(Lucene60PointsReader.java:224)
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsWriter.merge(Lucene60PointsWriter.java:169)
> at
> org.apache.lucene.index.SegmentMerger.mergePoints(SegmentMerger.java:173)
> at org.apache.lucene.index.SegmentMerger.merge(SegmentMerger.java:122)
> at
> org.apache.lucene.index.IndexWriter.mergeMiddle(IndexWriter.java:4287)
> at org.apache.lucene.index.IndexWriter.merge(IndexWriter.java:3864)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.doMerge(ConcurrentMergeScheduler.java:588)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:626)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7491) Unexpected merge exception when merging sparse points fields
[
https://issues.apache.org/jira/browse/LUCENE-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568697#comment-15568697
]
ASF subversion and git services commented on LUCENE-7491:
-
Commit 86b03358d59c584c89823e187b8806da48eb82af in lucene-solr's branch
refs/heads/branch_6x from Mike McCandless
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=86b0335 ]
LUCENE-7491: fix merge exception if the same field has points in some segments
but not in others
> Unexpected merge exception when merging sparse points fields
>
>
> Key: LUCENE-7491
> URL: https://issues.apache.org/jira/browse/LUCENE-7491
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Michael McCandless
>Assignee: Michael McCandless
> Fix For: master (7.0), 6.3
>
> Attachments: LUCENE-7491.patch, LUCENE-7491.patch
>
>
> Spinoff from this user thread: http://markmail.org/thread/vwdvjgupyz6heep5
> If you have a segment that has points, but a given field ("id") didn't index
> points, and a later segment where field "id" does index points, when try to
> merge those segments we hit this (incorrect!) exception:
> {noformat}
> Caused by: org.apache.lucene.index.MergePolicy$MergeException:
> java.lang.IllegalArgumentException: field="id" did not index point values
> at __randomizedtesting.SeedInfo.seed([9F3E7B030EF482BD]:0)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.handleMergeException(ConcurrentMergeScheduler.java:668)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:648)
> Caused by: java.lang.IllegalArgumentException: field="id" did not index point
> values
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsReader.getBKDReader(Lucene60PointsReader.java:126)
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsReader.size(Lucene60PointsReader.java:224)
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsWriter.merge(Lucene60PointsWriter.java:169)
> at
> org.apache.lucene.index.SegmentMerger.mergePoints(SegmentMerger.java:173)
> at org.apache.lucene.index.SegmentMerger.merge(SegmentMerger.java:122)
> at
> org.apache.lucene.index.IndexWriter.mergeMiddle(IndexWriter.java:4287)
> at org.apache.lucene.index.IndexWriter.merge(IndexWriter.java:3864)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.doMerge(ConcurrentMergeScheduler.java:588)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:626)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7491) Unexpected merge exception when merging sparse points fields
[
https://issues.apache.org/jira/browse/LUCENE-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568648#comment-15568648
]
ASF subversion and git services commented on LUCENE-7491:
-
Commit 1b7a88f61ea44ecc873d7c7d135ce5c6ab88bb0a in lucene-solr's branch
refs/heads/master from Mike McCandless
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1b7a88f ]
LUCENE-7491: fix merge exception if the same field has points in some segments
but not in others
> Unexpected merge exception when merging sparse points fields
>
>
> Key: LUCENE-7491
> URL: https://issues.apache.org/jira/browse/LUCENE-7491
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Michael McCandless
>Assignee: Michael McCandless
> Fix For: master (7.0), 6.3
>
> Attachments: LUCENE-7491.patch, LUCENE-7491.patch
>
>
> Spinoff from this user thread: http://markmail.org/thread/vwdvjgupyz6heep5
> If you have a segment that has points, but a given field ("id") didn't index
> points, and a later segment where field "id" does index points, when try to
> merge those segments we hit this (incorrect!) exception:
> {noformat}
> Caused by: org.apache.lucene.index.MergePolicy$MergeException:
> java.lang.IllegalArgumentException: field="id" did not index point values
> at __randomizedtesting.SeedInfo.seed([9F3E7B030EF482BD]:0)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.handleMergeException(ConcurrentMergeScheduler.java:668)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:648)
> Caused by: java.lang.IllegalArgumentException: field="id" did not index point
> values
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsReader.getBKDReader(Lucene60PointsReader.java:126)
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsReader.size(Lucene60PointsReader.java:224)
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsWriter.merge(Lucene60PointsWriter.java:169)
> at
> org.apache.lucene.index.SegmentMerger.mergePoints(SegmentMerger.java:173)
> at org.apache.lucene.index.SegmentMerger.merge(SegmentMerger.java:122)
> at
> org.apache.lucene.index.IndexWriter.mergeMiddle(IndexWriter.java:4287)
> at org.apache.lucene.index.IndexWriter.merge(IndexWriter.java:3864)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.doMerge(ConcurrentMergeScheduler.java:588)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:626)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7491) Unexpected merge exception when merging sparse points fields
[
https://issues.apache.org/jira/browse/LUCENE-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568386#comment-15568386
]
Adrien Grand commented on LUCENE-7491:
--
+1 to the patch
> Unexpected merge exception when merging sparse points fields
>
>
> Key: LUCENE-7491
> URL: https://issues.apache.org/jira/browse/LUCENE-7491
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Michael McCandless
>Assignee: Michael McCandless
> Fix For: master (7.0), 6.3
>
> Attachments: LUCENE-7491.patch, LUCENE-7491.patch
>
>
> Spinoff from this user thread: http://markmail.org/thread/vwdvjgupyz6heep5
> If you have a segment that has points, but a given field ("id") didn't index
> points, and a later segment where field "id" does index points, when try to
> merge those segments we hit this (incorrect!) exception:
> {noformat}
> Caused by: org.apache.lucene.index.MergePolicy$MergeException:
> java.lang.IllegalArgumentException: field="id" did not index point values
> at __randomizedtesting.SeedInfo.seed([9F3E7B030EF482BD]:0)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.handleMergeException(ConcurrentMergeScheduler.java:668)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:648)
> Caused by: java.lang.IllegalArgumentException: field="id" did not index point
> values
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsReader.getBKDReader(Lucene60PointsReader.java:126)
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsReader.size(Lucene60PointsReader.java:224)
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsWriter.merge(Lucene60PointsWriter.java:169)
> at
> org.apache.lucene.index.SegmentMerger.mergePoints(SegmentMerger.java:173)
> at org.apache.lucene.index.SegmentMerger.merge(SegmentMerger.java:122)
> at
> org.apache.lucene.index.IndexWriter.mergeMiddle(IndexWriter.java:4287)
> at org.apache.lucene.index.IndexWriter.merge(IndexWriter.java:3864)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.doMerge(ConcurrentMergeScheduler.java:588)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:626)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7491) Unexpected merge exception when merging sparse points fields
[
https://issues.apache.org/jira/browse/LUCENE-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568357#comment-15568357
]
Michael McCandless commented on LUCENE-7491:
+1
> Unexpected merge exception when merging sparse points fields
>
>
> Key: LUCENE-7491
> URL: https://issues.apache.org/jira/browse/LUCENE-7491
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Michael McCandless
>Assignee: Michael McCandless
> Fix For: master (7.0), 6.3
>
> Attachments: LUCENE-7491.patch, LUCENE-7491.patch
>
>
> Spinoff from this user thread: http://markmail.org/thread/vwdvjgupyz6heep5
> If you have a segment that has points, but a given field ("id") didn't index
> points, and a later segment where field "id" does index points, when try to
> merge those segments we hit this (incorrect!) exception:
> {noformat}
> Caused by: org.apache.lucene.index.MergePolicy$MergeException:
> java.lang.IllegalArgumentException: field="id" did not index point values
> at __randomizedtesting.SeedInfo.seed([9F3E7B030EF482BD]:0)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.handleMergeException(ConcurrentMergeScheduler.java:668)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:648)
> Caused by: java.lang.IllegalArgumentException: field="id" did not index point
> values
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsReader.getBKDReader(Lucene60PointsReader.java:126)
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsReader.size(Lucene60PointsReader.java:224)
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsWriter.merge(Lucene60PointsWriter.java:169)
> at
> org.apache.lucene.index.SegmentMerger.mergePoints(SegmentMerger.java:173)
> at org.apache.lucene.index.SegmentMerger.merge(SegmentMerger.java:122)
> at
> org.apache.lucene.index.IndexWriter.mergeMiddle(IndexWriter.java:4287)
> at org.apache.lucene.index.IndexWriter.merge(IndexWriter.java:3864)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.doMerge(ConcurrentMergeScheduler.java:588)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:626)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7491) Unexpected merge exception when merging sparse points fields
[
https://issues.apache.org/jira/browse/LUCENE-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568354#comment-15568354
]
Adrien Grand commented on LUCENE-7491:
--
bq. But would this API return null if that field did not index points in that
segment?
Yes, like doc values?
> Unexpected merge exception when merging sparse points fields
>
>
> Key: LUCENE-7491
> URL: https://issues.apache.org/jira/browse/LUCENE-7491
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Michael McCandless
>Assignee: Michael McCandless
> Fix For: master (7.0), 6.3
>
> Attachments: LUCENE-7491.patch, LUCENE-7491.patch
>
>
> Spinoff from this user thread: http://markmail.org/thread/vwdvjgupyz6heep5
> If you have a segment that has points, but a given field ("id") didn't index
> points, and a later segment where field "id" does index points, when try to
> merge those segments we hit this (incorrect!) exception:
> {noformat}
> Caused by: org.apache.lucene.index.MergePolicy$MergeException:
> java.lang.IllegalArgumentException: field="id" did not index point values
> at __randomizedtesting.SeedInfo.seed([9F3E7B030EF482BD]:0)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.handleMergeException(ConcurrentMergeScheduler.java:668)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:648)
> Caused by: java.lang.IllegalArgumentException: field="id" did not index point
> values
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsReader.getBKDReader(Lucene60PointsReader.java:126)
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsReader.size(Lucene60PointsReader.java:224)
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsWriter.merge(Lucene60PointsWriter.java:169)
> at
> org.apache.lucene.index.SegmentMerger.mergePoints(SegmentMerger.java:173)
> at org.apache.lucene.index.SegmentMerger.merge(SegmentMerger.java:122)
> at
> org.apache.lucene.index.IndexWriter.mergeMiddle(IndexWriter.java:4287)
> at org.apache.lucene.index.IndexWriter.merge(IndexWriter.java:3864)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.doMerge(ConcurrentMergeScheduler.java:588)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:626)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7491) Unexpected merge exception when merging sparse points fields
[
https://issues.apache.org/jira/browse/LUCENE-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568327#comment-15568327
]
Michael McCandless commented on LUCENE-7491:
bq. we could have LeafReader.getPointValues(String fieldName) and remove all
String fieldName parameters from PointValues?
I think that's compelling! Maybe open a new issue?
But would this API return null if that field did not index points in that
segment?
> Unexpected merge exception when merging sparse points fields
>
>
> Key: LUCENE-7491
> URL: https://issues.apache.org/jira/browse/LUCENE-7491
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Michael McCandless
>Assignee: Michael McCandless
> Fix For: master (7.0), 6.3
>
> Attachments: LUCENE-7491.patch, LUCENE-7491.patch
>
>
> Spinoff from this user thread: http://markmail.org/thread/vwdvjgupyz6heep5
> If you have a segment that has points, but a given field ("id") didn't index
> points, and a later segment where field "id" does index points, when try to
> merge those segments we hit this (incorrect!) exception:
> {noformat}
> Caused by: org.apache.lucene.index.MergePolicy$MergeException:
> java.lang.IllegalArgumentException: field="id" did not index point values
> at __randomizedtesting.SeedInfo.seed([9F3E7B030EF482BD]:0)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.handleMergeException(ConcurrentMergeScheduler.java:668)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:648)
> Caused by: java.lang.IllegalArgumentException: field="id" did not index point
> values
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsReader.getBKDReader(Lucene60PointsReader.java:126)
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsReader.size(Lucene60PointsReader.java:224)
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsWriter.merge(Lucene60PointsWriter.java:169)
> at
> org.apache.lucene.index.SegmentMerger.mergePoints(SegmentMerger.java:173)
> at org.apache.lucene.index.SegmentMerger.merge(SegmentMerger.java:122)
> at
> org.apache.lucene.index.IndexWriter.mergeMiddle(IndexWriter.java:4287)
> at org.apache.lucene.index.IndexWriter.merge(IndexWriter.java:3864)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.doMerge(ConcurrentMergeScheduler.java:588)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:626)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7491) Unexpected merge exception when merging sparse points fields
[
https://issues.apache.org/jira/browse/LUCENE-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568192#comment-15568192
]
Adrien Grand commented on LUCENE-7491:
--
bq. I'm generally not really a fan of returning fake empty "should be null but
caller can't be trusted" objects though
I don't disagree with this statement but I like the current situation even
less. It makes things hard to test because of the branches it creates. Say you
want to test the point range query on field {{foo}}, you need to test what
happens when no fields have points, when foo has points and when foo does not
have points but other fields from the same segment do. If you don't like
returning non-null even when no fields have points, then maybe we should
consider making points work per field like doc values, so instead of having
{{LeafReader.getPointValues()}} and all methods of {{PointValues}} that take a
{{String fieldName}} parameter, we could have
{{LeafReader.getPointValues(String fieldName)}} and remove all {{String
fieldName}} parameters from {{PointValues}}?
> Unexpected merge exception when merging sparse points fields
>
>
> Key: LUCENE-7491
> URL: https://issues.apache.org/jira/browse/LUCENE-7491
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Michael McCandless
>Assignee: Michael McCandless
> Fix For: master (7.0), 6.3
>
> Attachments: LUCENE-7491.patch, LUCENE-7491.patch
>
>
> Spinoff from this user thread: http://markmail.org/thread/vwdvjgupyz6heep5
> If you have a segment that has points, but a given field ("id") didn't index
> points, and a later segment where field "id" does index points, when try to
> merge those segments we hit this (incorrect!) exception:
> {noformat}
> Caused by: org.apache.lucene.index.MergePolicy$MergeException:
> java.lang.IllegalArgumentException: field="id" did not index point values
> at __randomizedtesting.SeedInfo.seed([9F3E7B030EF482BD]:0)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.handleMergeException(ConcurrentMergeScheduler.java:668)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:648)
> Caused by: java.lang.IllegalArgumentException: field="id" did not index point
> values
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsReader.getBKDReader(Lucene60PointsReader.java:126)
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsReader.size(Lucene60PointsReader.java:224)
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsWriter.merge(Lucene60PointsWriter.java:169)
> at
> org.apache.lucene.index.SegmentMerger.mergePoints(SegmentMerger.java:173)
> at org.apache.lucene.index.SegmentMerger.merge(SegmentMerger.java:122)
> at
> org.apache.lucene.index.IndexWriter.mergeMiddle(IndexWriter.java:4287)
> at org.apache.lucene.index.IndexWriter.merge(IndexWriter.java:3864)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.doMerge(ConcurrentMergeScheduler.java:588)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:626)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7491) Unexpected merge exception when merging sparse points fields
[
https://issues.apache.org/jira/browse/LUCENE-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568160#comment-15568160
]
Michael McCandless commented on LUCENE-7491:
bq. To make things less trappy, I'm wondering that maybe
LeafReader.getPointValues() should never return null.
We could maybe separately consider that? I don't think that would have
prevented this particular bug.
I'm generally not really a fan of returning fake empty "should be null but
caller can't be trusted" objects though: I think it's a degree of API leniency
that if you take it to its limit, never ends, i.e. how deeply do you keep
returning null as you dig into the fake object? These are quite expert APIs
and I think it's reasonable to expect the caller to be careful with the return
result...
Today, a null return from {{LeafReader.getPointValues}} is meaningful: it
notifies you this segment has no points indexed at all. We would be hiding
that information if instead we returned a fake empty object.
Not helping matters, I do realize we are inconsistent here, e.g.
{{LeafReader.fields()}} is not null even if there were no postings in that
segment, yet {{Fields.terms(String field)}} is null if the postings didn't have
that field.
> Unexpected merge exception when merging sparse points fields
>
>
> Key: LUCENE-7491
> URL: https://issues.apache.org/jira/browse/LUCENE-7491
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Michael McCandless
>Assignee: Michael McCandless
> Fix For: master (7.0), 6.3
>
> Attachments: LUCENE-7491.patch, LUCENE-7491.patch
>
>
> Spinoff from this user thread: http://markmail.org/thread/vwdvjgupyz6heep5
> If you have a segment that has points, but a given field ("id") didn't index
> points, and a later segment where field "id" does index points, when try to
> merge those segments we hit this (incorrect!) exception:
> {noformat}
> Caused by: org.apache.lucene.index.MergePolicy$MergeException:
> java.lang.IllegalArgumentException: field="id" did not index point values
> at __randomizedtesting.SeedInfo.seed([9F3E7B030EF482BD]:0)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.handleMergeException(ConcurrentMergeScheduler.java:668)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:648)
> Caused by: java.lang.IllegalArgumentException: field="id" did not index point
> values
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsReader.getBKDReader(Lucene60PointsReader.java:126)
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsReader.size(Lucene60PointsReader.java:224)
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsWriter.merge(Lucene60PointsWriter.java:169)
> at
> org.apache.lucene.index.SegmentMerger.mergePoints(SegmentMerger.java:173)
> at org.apache.lucene.index.SegmentMerger.merge(SegmentMerger.java:122)
> at
> org.apache.lucene.index.IndexWriter.mergeMiddle(IndexWriter.java:4287)
> at org.apache.lucene.index.IndexWriter.merge(IndexWriter.java:3864)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.doMerge(ConcurrentMergeScheduler.java:588)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:626)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7491) Unexpected merge exception when merging sparse points fields
[
https://issues.apache.org/jira/browse/LUCENE-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15567920#comment-15567920
]
Adrien Grand commented on LUCENE-7491:
--
To make things less trappy, I'm wondering that maybe
{{LeafReader.getPointValues()}} should never return {{null}}. Otherwise the
code gets into different branches depending on whether *other* fields index
points or not.
> Unexpected merge exception when merging sparse points fields
>
>
> Key: LUCENE-7491
> URL: https://issues.apache.org/jira/browse/LUCENE-7491
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Michael McCandless
>Assignee: Michael McCandless
> Fix For: master (7.0), 6.3
>
> Attachments: LUCENE-7491.patch
>
>
> Spinoff from this user thread: http://markmail.org/thread/vwdvjgupyz6heep5
> If you have a segment that has points, but a given field ("id") didn't index
> points, and a later segment where field "id" does index points, when try to
> merge those segments we hit this (incorrect!) exception:
> {noformat}
> Caused by: org.apache.lucene.index.MergePolicy$MergeException:
> java.lang.IllegalArgumentException: field="id" did not index point values
> at __randomizedtesting.SeedInfo.seed([9F3E7B030EF482BD]:0)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.handleMergeException(ConcurrentMergeScheduler.java:668)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:648)
> Caused by: java.lang.IllegalArgumentException: field="id" did not index point
> values
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsReader.getBKDReader(Lucene60PointsReader.java:126)
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsReader.size(Lucene60PointsReader.java:224)
> at
> org.apache.lucene.codecs.lucene60.Lucene60PointsWriter.merge(Lucene60PointsWriter.java:169)
> at
> org.apache.lucene.index.SegmentMerger.mergePoints(SegmentMerger.java:173)
> at org.apache.lucene.index.SegmentMerger.merge(SegmentMerger.java:122)
> at
> org.apache.lucene.index.IndexWriter.mergeMiddle(IndexWriter.java:4287)
> at org.apache.lucene.index.IndexWriter.merge(IndexWriter.java:3864)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler.doMerge(ConcurrentMergeScheduler.java:588)
> at
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:626)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
