[jira] [Commented] (LUCENE-7655) Speed up geo-distance queries that match most documents
[ https://issues.apache.org/jira/browse/LUCENE-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116465#comment-16116465 ] ASF GitHub Bot commented on LUCENE-7655: Github user asfgit closed the pull request at: https://github.com/apache/lucene-solr/pull/226 > Speed up geo-distance queries that match most documents > --- > > Key: LUCENE-7655 > URL: https://issues.apache.org/jira/browse/LUCENE-7655 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > > I think the same optimization that was applied in LUCENE-7641 would also work > with geo-distance queries? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7655) Speed up geo-distance queries that match most documents
[ https://issues.apache.org/jira/browse/LUCENE-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116463#comment-16116463 ] ASF subversion and git services commented on LUCENE-7655: - Commit 5fb800f01819a2bfcebf8ba04fb1fd7d28ba6b23 in lucene-solr's branch refs/heads/master from [~jpountz] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5fb800f ] LUCENE-7655: Speed up geo-distance queries that match most documents. Closes #226 > Speed up geo-distance queries that match most documents > --- > > Key: LUCENE-7655 > URL: https://issues.apache.org/jira/browse/LUCENE-7655 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > > I think the same optimization that was applied in LUCENE-7641 would also work > with geo-distance queries? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7655) Speed up geo-distance queries that match most documents
[ https://issues.apache.org/jira/browse/LUCENE-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116462#comment-16116462 ] ASF subversion and git services commented on LUCENE-7655: - Commit fdf808475fe7a065bd4ea8b46cfe55129299e2c0 in lucene-solr's branch refs/heads/branch_7x from [~jpountz] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fdf8084 ] LUCENE-7655: Speed up geo-distance queries that match most documents. Closes #226 > Speed up geo-distance queries that match most documents > --- > > Key: LUCENE-7655 > URL: https://issues.apache.org/jira/browse/LUCENE-7655 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > > I think the same optimization that was applied in LUCENE-7641 would also work > with geo-distance queries? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7655) Speed up geo-distance queries that match most documents
[ https://issues.apache.org/jira/browse/LUCENE-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116394#comment-16116394 ] ASF GitHub Bot commented on LUCENE-7655: Github user mzasada commented on the issue: https://github.com/apache/lucene-solr/pull/226 No worries :) Thx for a review! > Speed up geo-distance queries that match most documents > --- > > Key: LUCENE-7655 > URL: https://issues.apache.org/jira/browse/LUCENE-7655 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > > I think the same optimization that was applied in LUCENE-7641 would also work > with geo-distance queries? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7655) Speed up geo-distance queries that match most documents
[ https://issues.apache.org/jira/browse/LUCENE-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116384#comment-16116384 ] ASF GitHub Bot commented on LUCENE-7655: Github user jpountz commented on the issue: https://github.com/apache/lucene-solr/pull/226 Oh, nevermind my previous comment then. I had missed the new test! > Speed up geo-distance queries that match most documents > --- > > Key: LUCENE-7655 > URL: https://issues.apache.org/jira/browse/LUCENE-7655 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > > I think the same optimization that was applied in LUCENE-7641 would also work > with geo-distance queries? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7655) Speed up geo-distance queries that match most documents
[ https://issues.apache.org/jira/browse/LUCENE-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116333#comment-16116333 ] ASF GitHub Bot commented on LUCENE-7655: Github user mzasada commented on the issue: https://github.com/apache/lucene-solr/pull/226 That was my intention when I added `TestLatLonPointQueries#testDistanceQueryWithInvertedIntersection` unit test. Should I improve it? > Speed up geo-distance queries that match most documents > --- > > Key: LUCENE-7655 > URL: https://issues.apache.org/jira/browse/LUCENE-7655 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > > I think the same optimization that was applied in LUCENE-7641 would also work > with geo-distance queries? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7655) Speed up geo-distance queries that match most documents
[ https://issues.apache.org/jira/browse/LUCENE-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116322#comment-16116322 ] Adrien Grand commented on LUCENE-7655: -- Thanks [~maciej.zasada]! I just had a look and it looks good to me. I think we just need to look into testing it explicitly before merging. > Speed up geo-distance queries that match most documents > --- > > Key: LUCENE-7655 > URL: https://issues.apache.org/jira/browse/LUCENE-7655 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > > I think the same optimization that was applied in LUCENE-7641 would also work > with geo-distance queries? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7655) Speed up geo-distance queries that match most documents
[ https://issues.apache.org/jira/browse/LUCENE-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116321#comment-16116321 ] ASF GitHub Bot commented on LUCENE-7655: Github user jpountz commented on the issue: https://github.com/apache/lucene-solr/pull/226 The change looks good to me. Maybe we should look into writing at least one test that explicitly tests this case? > Speed up geo-distance queries that match most documents > --- > > Key: LUCENE-7655 > URL: https://issues.apache.org/jira/browse/LUCENE-7655 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > > I think the same optimization that was applied in LUCENE-7641 would also work > with geo-distance queries? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7655) Speed up geo-distance queries that match most documents
[ https://issues.apache.org/jira/browse/LUCENE-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115415#comment-16115415 ] David Smiley commented on LUCENE-7655: -- Cool [~maciej.zasada]; thanks for contributing. > Speed up geo-distance queries that match most documents > --- > > Key: LUCENE-7655 > URL: https://issues.apache.org/jira/browse/LUCENE-7655 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > > I think the same optimization that was applied in LUCENE-7641 would also work > with geo-distance queries? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7655) Speed up geo-distance queries that match most documents
[ https://issues.apache.org/jira/browse/LUCENE-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115037#comment-16115037 ] Maciej Zasada commented on LUCENE-7655: --- Hi [~jpountz], I'd like to contribute this improvement. I opened a PR on GH, would you mind taking a look? Unit tests pass, I also ran luceneutil spatial test: {code} perf.IndexAndSearchOpenStreetMaps -points -distance {code} and after tuning queries to match ~75% of the docs, I did see ~ +20% QPS gain. Let me know if I can do anything more. Cheers! > Speed up geo-distance queries that match most documents > --- > > Key: LUCENE-7655 > URL: https://issues.apache.org/jira/browse/LUCENE-7655 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > > I think the same optimization that was applied in LUCENE-7641 would also work > with geo-distance queries? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7655) Speed up geo-distance queries that match most documents
[ https://issues.apache.org/jira/browse/LUCENE-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114772#comment-16114772 ] ASF GitHub Bot commented on LUCENE-7655: GitHub user mzasada opened a pull request: https://github.com/apache/lucene-solr/pull/226 LUCENE-7655 Speed up geo-distance queries that match most documents You can merge this pull request into a Git repository by running: $ git pull https://github.com/mzasada/lucene-solr LUCENE-7655 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/226.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #226 commit cea3578fc58cb72873a93702b93f0aefb8040b4a Author: mzasadaDate: 2017-08-02T13:58:30Z LUCENE-7655 Speed up geo-distance queries that match most documents > Speed up geo-distance queries that match most documents > --- > > Key: LUCENE-7655 > URL: https://issues.apache.org/jira/browse/LUCENE-7655 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > > I think the same optimization that was applied in LUCENE-7641 would also work > with geo-distance queries? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7655) Speed up geo-distance queries that match most documents
[ https://issues.apache.org/jira/browse/LUCENE-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843662#comment-15843662 ] Michael McCandless commented on LUCENE-7655: +1 > Speed up geo-distance queries that match most documents > --- > > Key: LUCENE-7655 > URL: https://issues.apache.org/jira/browse/LUCENE-7655 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Priority: Minor > > I think the same optimization that was applied in LUCENE-7641 would also work > with geo-distance queries? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org