[jira] [Commented] (LUCENE-8229) Add a method to Weight to retrieve matches for a single document

2018-07-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536633#comment-16536633 ] Alan Woodward commented on LUCENE-8229: --- Simon added IOSupplier rather than IOConsumer, which

[jira] [Commented] (LUCENE-8229) Add a method to Weight to retrieve matches for a single document

2018-07-06 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534937#comment-16534937 ] David Smiley commented on LUCENE-8229: -- I was just looking at Matches.MatchesIteratorSupplier.

[jira] [Commented] (LUCENE-8229) Add a method to Weight to retrieve matches for a single document

2018-04-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435723#comment-16435723 ] ASF subversion and git services commented on LUCENE-8229: - Commit

[jira] [Commented] (LUCENE-8229) Add a method to Weight to retrieve matches for a single document

2018-04-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435716#comment-16435716 ] ASF subversion and git services commented on LUCENE-8229: - Commit

[jira] [Commented] (LUCENE-8229) Add a method to Weight to retrieve matches for a single document

2018-04-12 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435020#comment-16435020 ] Alan Woodward commented on LUCENE-8229: --- +1 > Add a method to Weight to retrieve matches for a

[jira] [Commented] (LUCENE-8229) Add a method to Weight to retrieve matches for a single document

2018-04-11 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434924#comment-16434924 ] David Smiley commented on LUCENE-8229: -- I'm excited about this too :-) I made some small tweaks,

[jira] [Commented] (LUCENE-8229) Add a method to Weight to retrieve matches for a single document

2018-04-11 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433640#comment-16433640 ] ASF subversion and git services commented on LUCENE-8229: - Commit

[jira] [Commented] (LUCENE-8229) Add a method to Weight to retrieve matches for a single document

2018-04-11 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433641#comment-16433641 ] ASF subversion and git services commented on LUCENE-8229: - Commit

[jira] [Commented] (LUCENE-8229) Add a method to Weight to retrieve matches for a single document

2018-04-06 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428112#comment-16428112 ] Alan Woodward commented on LUCENE-8229: --- OK, the latest iteration moves the notion of a match

[jira] [Commented] (LUCENE-8229) Add a method to Weight to retrieve matches for a single document

2018-04-05 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427422#comment-16427422 ] Alan Woodward commented on LUCENE-8229: --- bq. because even a no-match response requires knowledge of

[jira] [Commented] (LUCENE-8229) Add a method to Weight to retrieve matches for a single document

2018-04-05 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427185#comment-16427185 ] David Smiley commented on LUCENE-8229: -- It's really looking great Alan. I looked over your patch a

[jira] [Commented] (LUCENE-8229) Add a method to Weight to retrieve matches for a single document

2018-04-04 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425406#comment-16425406 ] Alan Woodward commented on LUCENE-8229: --- Patch up to date with master, precommit and tests pass. I

[jira] [Commented] (LUCENE-8229) Add a method to Weight to retrieve matches for a single document

2018-04-02 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422822#comment-16422822 ] Alan Woodward commented on LUCENE-8229: --- I've pushed a few more changes - IndexOrDocValuesQuery

[jira] [Commented] (LUCENE-8229) Add a method to Weight to retrieve matches for a single document

2018-03-29 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418770#comment-16418770 ] Alan Woodward commented on LUCENE-8229: --- Having slept on it, I've come round to [~dsmiley]'s

[jira] [Commented] (LUCENE-8229) Add a method to Weight to retrieve matches for a single document

2018-03-29 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418708#comment-16418708 ] Jim Ferenczi commented on LUCENE-8229: -- I like the proposal here. For simple queries it makes the

[jira] [Commented] (LUCENE-8229) Add a method to Weight to retrieve matches for a single document

2018-03-28 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418007#comment-16418007 ] Alan Woodward commented on LUCENE-8229: --- {quote}A caller might want all fields, or perhaps just

[jira] [Commented] (LUCENE-8229) Add a method to Weight to retrieve matches for a single document

2018-03-28 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417909#comment-16417909 ] Dawid Weiss commented on LUCENE-8229: - bq. The ability to find out exactly what a query has matched

[jira] [Commented] (LUCENE-8229) Add a method to Weight to retrieve matches for a single document

2018-03-28 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417849#comment-16417849 ] David Smiley commented on LUCENE-8229: -- This is really interesting [~romseygeek]! Here's your

[jira] [Commented] (LUCENE-8229) Add a method to Weight to retrieve matches for a single document

2018-03-28 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417443#comment-16417443 ] Alan Woodward commented on LUCENE-8229: --- The PR linked above illustrates the idea.  There are still