[jira] [Commented] (LUCENE-8242) Rename IndexSearcher.createNormalizedWeight()

2018-04-09 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430667#comment-16430667 ] ASF subversion and git services commented on LUCENE-8242: - Commit

[jira] [Commented] (LUCENE-8242) Rename IndexSearcher.createNormalizedWeight()

2018-04-09 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430666#comment-16430666 ] ASF subversion and git services commented on LUCENE-8242: - Commit

[jira] [Commented] (LUCENE-8242) Rename IndexSearcher.createNormalizedWeight()

2018-04-09 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430665#comment-16430665 ] ASF subversion and git services commented on LUCENE-8242: - Commit

[jira] [Commented] (LUCENE-8242) Rename IndexSearcher.createNormalizedWeight()

2018-04-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430517#comment-16430517 ] Adrien Grand commented on LUCENE-8242: -- +1 Maybe say that {{boost}} should be {{1}} in the

[jira] [Commented] (LUCENE-8242) Rename IndexSearcher.createNormalizedWeight()

2018-04-07 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429476#comment-16429476 ] Alan Woodward commented on LUCENE-8242: --- Here's a patch deprecating the method, and removing all

[jira] [Commented] (LUCENE-8242) Rename IndexSearcher.createNormalizedWeight()

2018-04-07 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429322#comment-16429322 ] Robert Muir commented on LUCENE-8242: - Please remove it, I see zero advantage in renaming it. >

[jira] [Commented] (LUCENE-8242) Rename IndexSearcher.createNormalizedWeight()

2018-04-06 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428236#comment-16428236 ] Adrien Grand commented on LUCENE-8242: -- Or maybe remove it entirely and expect callers to rewrite

[jira] [Commented] (LUCENE-8242) Rename IndexSearcher.createNormalizedWeight()

2018-04-06 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428210#comment-16428210 ] Alan Woodward commented on LUCENE-8242: --- We have two createWeight() functions in IndexSearcher: