[jira] [Commented] (LUCENE-8249) Add matches to exact PhraseQuery and MultiPhraseQuery

2018-05-10 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470322#comment-16470322 ] ASF subversion and git services commented on LUCENE-8249: - Commit

[jira] [Commented] (LUCENE-8249) Add matches to exact PhraseQuery and MultiPhraseQuery

2018-05-10 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470321#comment-16470321 ] ASF subversion and git services commented on LUCENE-8249: - Commit

[jira] [Commented] (LUCENE-8249) Add matches to exact PhraseQuery and MultiPhraseQuery

2018-05-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469099#comment-16469099 ] Adrien Grand commented on LUCENE-8249: -- +1 > Add matches to exact PhraseQuery and MultiPhraseQuery

[jira] [Commented] (LUCENE-8249) Add matches to exact PhraseQuery and MultiPhraseQuery

2018-05-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469069#comment-16469069 ] Alan Woodward commented on LUCENE-8249: --- I spoke to Adrien elsewhere and have added some comments

[jira] [Commented] (LUCENE-8249) Add matches to exact PhraseQuery and MultiPhraseQuery

2018-04-24 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449494#comment-16449494 ] Alan Woodward commented on LUCENE-8249: --- Updated patch, now that MatchesIterator#term() is gone. I

[jira] [Commented] (LUCENE-8249) Add matches to exact PhraseQuery and MultiPhraseQuery

2018-04-20 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445723#comment-16445723 ] Adrien Grand commented on LUCENE-8249: -- Thanks for the update, I'll have another look. bq. I like

[jira] [Commented] (LUCENE-8249) Add matches to exact PhraseQuery and MultiPhraseQuery

2018-04-20 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445499#comment-16445499 ] Alan Woodward commented on LUCENE-8249: --- Here's an updated patch: * minFreq() is now maxFreq() * I

[jira] [Commented] (LUCENE-8249) Add matches to exact PhraseQuery and MultiPhraseQuery

2018-04-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442798#comment-16442798 ] Adrien Grand commented on LUCENE-8249: -- I like this approach better. I have some questions/notes: -

[jira] [Commented] (LUCENE-8249) Add matches to exact PhraseQuery and MultiPhraseQuery

2018-04-16 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439293#comment-16439293 ] Alan Woodward commented on LUCENE-8249: --- Looks like a small penalty on sloppy phrases, and a

[jira] [Commented] (LUCENE-8249) Add matches to exact PhraseQuery and MultiPhraseQuery

2018-04-16 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439285#comment-16439285 ] Alan Woodward commented on LUCENE-8249: --- Here's an updated patch: * matching is moved out to a new

[jira] [Commented] (LUCENE-8249) Add matches to exact PhraseQuery and MultiPhraseQuery

2018-04-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435757#comment-16435757 ] Adrien Grand commented on LUCENE-8249: -- I don't like mixing scorers, which are about documents with

[jira] [Commented] (LUCENE-8249) Add matches to exact PhraseQuery and MultiPhraseQuery

2018-04-12 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435730#comment-16435730 ] Alan Woodward commented on LUCENE-8249: --- I'm not sure this makes things that much more complex? It

[jira] [Commented] (LUCENE-8249) Add matches to exact PhraseQuery and MultiPhraseQuery

2018-04-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435709#comment-16435709 ] Adrien Grand commented on LUCENE-8249: -- I don't think we should modify ExactPhraseScorer to expose

[jira] [Commented] (LUCENE-8249) Add matches to exact PhraseQuery and MultiPhraseQuery

2018-04-12 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435691#comment-16435691 ] Alan Woodward commented on LUCENE-8249: --- Here's the benchmark. Looks like noise to me... {code}

[jira] [Commented] (LUCENE-8249) Add matches to exact PhraseQuery and MultiPhraseQuery

2018-04-12 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435322#comment-16435322 ] Alan Woodward commented on LUCENE-8249: --- Here's a patch. It involves some minor refactoring of