[jira] [Commented] (LUCENE-8254) LRUQueryCache can leak locks
[ https://issues.apache.org/jira/browse/LUCENE-8254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447693#comment-16447693 ] ASF subversion and git services commented on LUCENE-8254: - Commit 696ff57f4cfaebd842926a80e71d4e0970a73544 in lucene-solr's branch refs/heads/branch_7_3 from [~romseygeek] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=696ff57 ] LUCENE-8254: LRUQueryCache can leak locks > LRUQueryCache can leak locks > > > Key: LUCENE-8254 > URL: https://issues.apache.org/jira/browse/LUCENE-8254 > Project: Lucene - Core > Issue Type: Bug >Reporter: Alan Woodward >Assignee: Alan Woodward >Priority: Major > Fix For: 7.4 > > Attachments: LUCENE-8254.patch, LUCENE-8254.patch > > > If a QueryCache is shared between two searchers, one of which has an > IndexReader with no CacheHelper, then CachingWrapperWeight can leak locks in > scorerSupplier() and bulkScorer(). This can cause the IndexReader that does > have a CacheHelper to hang on close. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8254) LRUQueryCache can leak locks
[ https://issues.apache.org/jira/browse/LUCENE-8254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439221#comment-16439221 ] Alan Woodward commented on LUCENE-8254: --- This only happens under very unusual circumstances (query cache shared between two different IndexReader types, one of which has a null CacheHelper), so I don't think this warrants a bug fix release? > LRUQueryCache can leak locks > > > Key: LUCENE-8254 > URL: https://issues.apache.org/jira/browse/LUCENE-8254 > Project: Lucene - Core > Issue Type: Bug >Reporter: Alan Woodward >Priority: Major > Attachments: LUCENE-8254.patch, LUCENE-8254.patch > > > If a QueryCache is shared between two searchers, one of which has an > IndexReader with no CacheHelper, then CachingWrapperWeight can leak locks in > scorerSupplier() and bulkScorer(). This can cause the IndexReader that does > have a CacheHelper to hang on close. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8254) LRUQueryCache can leak locks
[ https://issues.apache.org/jira/browse/LUCENE-8254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439222#comment-16439222 ] ASF subversion and git services commented on LUCENE-8254: - Commit 8eb6ed4638e4e27e4dc22ac9d8f44b36238ff3ac in lucene-solr's branch refs/heads/branch_7x from [~romseygeek] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8eb6ed4 ] LUCENE-8254: LRUQueryCache can leak locks > LRUQueryCache can leak locks > > > Key: LUCENE-8254 > URL: https://issues.apache.org/jira/browse/LUCENE-8254 > Project: Lucene - Core > Issue Type: Bug >Reporter: Alan Woodward >Priority: Major > Attachments: LUCENE-8254.patch, LUCENE-8254.patch > > > If a QueryCache is shared between two searchers, one of which has an > IndexReader with no CacheHelper, then CachingWrapperWeight can leak locks in > scorerSupplier() and bulkScorer(). This can cause the IndexReader that does > have a CacheHelper to hang on close. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8254) LRUQueryCache can leak locks
[ https://issues.apache.org/jira/browse/LUCENE-8254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439223#comment-16439223 ] ASF subversion and git services commented on LUCENE-8254: - Commit 19fa91dbfbca990df460a9e709b7f83c27bc27cd in lucene-solr's branch refs/heads/master from [~romseygeek] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=19fa91d ] LUCENE-8254: LRUQueryCache can leak locks > LRUQueryCache can leak locks > > > Key: LUCENE-8254 > URL: https://issues.apache.org/jira/browse/LUCENE-8254 > Project: Lucene - Core > Issue Type: Bug >Reporter: Alan Woodward >Priority: Major > Attachments: LUCENE-8254.patch, LUCENE-8254.patch > > > If a QueryCache is shared between two searchers, one of which has an > IndexReader with no CacheHelper, then CachingWrapperWeight can leak locks in > scorerSupplier() and bulkScorer(). This can cause the IndexReader that does > have a CacheHelper to hang on close. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8254) LRUQueryCache can leak locks
[ https://issues.apache.org/jira/browse/LUCENE-8254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439192#comment-16439192 ] Adrien Grand commented on LUCENE-8254: -- +1 > LRUQueryCache can leak locks > > > Key: LUCENE-8254 > URL: https://issues.apache.org/jira/browse/LUCENE-8254 > Project: Lucene - Core > Issue Type: Bug >Reporter: Alan Woodward >Priority: Major > Attachments: LUCENE-8254.patch, LUCENE-8254.patch > > > If a QueryCache is shared between two searchers, one of which has an > IndexReader with no CacheHelper, then CachingWrapperWeight can leak locks in > scorerSupplier() and bulkScorer(). This can cause the IndexReader that does > have a CacheHelper to hang on close. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8254) LRUQueryCache can leak locks
[ https://issues.apache.org/jira/browse/LUCENE-8254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439188#comment-16439188 ] Alan Woodward commented on LUCENE-8254: --- Oops, yes. Sorry, not enough tea yet this morning. Here's an updated patch. > LRUQueryCache can leak locks > > > Key: LUCENE-8254 > URL: https://issues.apache.org/jira/browse/LUCENE-8254 > Project: Lucene - Core > Issue Type: Bug >Reporter: Alan Woodward >Priority: Major > Attachments: LUCENE-8254.patch, LUCENE-8254.patch > > > If a QueryCache is shared between two searchers, one of which has an > IndexReader with no CacheHelper, then CachingWrapperWeight can leak locks in > scorerSupplier() and bulkScorer(). This can cause the IndexReader that does > have a CacheHelper to hang on close. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8254) LRUQueryCache can leak locks
[ https://issues.apache.org/jira/browse/LUCENE-8254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439181#comment-16439181 ] Adrien Grand commented on LUCENE-8254: -- I think it would be better to test the cache helper before trying to take the lock, instead of doing it in the try block? > LRUQueryCache can leak locks > > > Key: LUCENE-8254 > URL: https://issues.apache.org/jira/browse/LUCENE-8254 > Project: Lucene - Core > Issue Type: Bug >Reporter: Alan Woodward >Priority: Major > Attachments: LUCENE-8254.patch > > > If a QueryCache is shared between two searchers, one of which has an > IndexReader with no CacheHelper, then CachingWrapperWeight can leak locks in > scorerSupplier() and bulkScorer(). This can cause the IndexReader that does > have a CacheHelper to hang on close. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8254) LRUQueryCache can leak locks
[ https://issues.apache.org/jira/browse/LUCENE-8254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439179#comment-16439179 ] Alan Woodward commented on LUCENE-8254: --- Here's a patch, including a test that hangs without the corresponding fix. > LRUQueryCache can leak locks > > > Key: LUCENE-8254 > URL: https://issues.apache.org/jira/browse/LUCENE-8254 > Project: Lucene - Core > Issue Type: Bug >Reporter: Alan Woodward >Priority: Major > Attachments: LUCENE-8254.patch > > > If a QueryCache is shared between two searchers, one of which has an > IndexReader with no CacheHelper, then CachingWrapperWeight can leak locks in > scorerSupplier() and bulkScorer(). This can cause the IndexReader that does > have a CacheHelper to hang on close. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
