[jira] [Commented] (LUCENE-8257) GeoComplexPolygon fails when points are near identical
[
https://issues.apache.org/jira/browse/LUCENE-8257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440505#comment-16440505
]
Karl Wright commented on LUCENE-8257:
-
[~ivera], using the backing plane all the time seemed OK with the way I set it
up. But computing the interpolation point is expensive, so as a performance
improvement, you might want to use the "functionally identical" test and change
the code in the Edge class to make it cheaper to construct most Edge objects.
> GeoComplexPolygon fails when points are near identical
> --
>
> Key: LUCENE-8257
> URL: https://issues.apache.org/jira/browse/LUCENE-8257
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial3d
>Reporter: Ignacio Vera
>Assignee: Karl Wright
>Priority: Major
> Fix For: 6.7, 7.4, master (8.0)
>
> Attachments: LUCENE-8257.patch
>
>
> When a polygon have two consecutive points very close to each other but not
> numerically identical, we can get wrong results because planes defining that
> edge intersects somewhere else on the world. At that point the following
> check is evaluated to true:
> {code:java}
> if (edge.plane.evaluateIsZero(thePointX, thePointY, thePointZ) &&
> edge.startPlane.isWithin(thePointX, thePointY, thePointZ) &&
> edge.endPlane.isWithin(thePointX, thePointY, thePointZ)) {
> return false;
> }{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8257) GeoComplexPolygon fails when points are near identical
[
https://issues.apache.org/jira/browse/LUCENE-8257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440488#comment-16440488
]
ASF subversion and git services commented on LUCENE-8257:
-
Commit 8b0ac122e652a48c77fab81ba17d3923db16a968 in lucene-solr's branch
refs/heads/branch_6x from [~kwri...@metacarta.com]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8b0ac12 ]
LUCENE-8257: All edges have a backing plane, so edge membership doesn't bleed
through to the opposite side of the world.
> GeoComplexPolygon fails when points are near identical
> --
>
> Key: LUCENE-8257
> URL: https://issues.apache.org/jira/browse/LUCENE-8257
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial3d
>Reporter: Ignacio Vera
>Assignee: Karl Wright
>Priority: Major
> Attachments: LUCENE-8257.patch
>
>
> When a polygon have two consecutive points very close to each other but not
> numerically identical, we can get wrong results because planes defining that
> edge intersects somewhere else on the world. At that point the following
> check is evaluated to true:
> {code:java}
> if (edge.plane.evaluateIsZero(thePointX, thePointY, thePointZ) &&
> edge.startPlane.isWithin(thePointX, thePointY, thePointZ) &&
> edge.endPlane.isWithin(thePointX, thePointY, thePointZ)) {
> return false;
> }{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8257) GeoComplexPolygon fails when points are near identical
[
https://issues.apache.org/jira/browse/LUCENE-8257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440486#comment-16440486
]
ASF subversion and git services commented on LUCENE-8257:
-
Commit 4ee92c22a4b731d3ec2f93409f3fe57ae348cea1 in lucene-solr's branch
refs/heads/master from [~kwri...@metacarta.com]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4ee92c2 ]
LUCENE-8257: All edges have a backing plane, so edge membership doesn't bleed
through to the opposite side of the world.
> GeoComplexPolygon fails when points are near identical
> --
>
> Key: LUCENE-8257
> URL: https://issues.apache.org/jira/browse/LUCENE-8257
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial3d
>Reporter: Ignacio Vera
>Assignee: Karl Wright
>Priority: Major
> Attachments: LUCENE-8257.patch
>
>
> When a polygon have two consecutive points very close to each other but not
> numerically identical, we can get wrong results because planes defining that
> edge intersects somewhere else on the world. At that point the following
> check is evaluated to true:
> {code:java}
> if (edge.plane.evaluateIsZero(thePointX, thePointY, thePointZ) &&
> edge.startPlane.isWithin(thePointX, thePointY, thePointZ) &&
> edge.endPlane.isWithin(thePointX, thePointY, thePointZ)) {
> return false;
> }{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8257) GeoComplexPolygon fails when points are near identical
[
https://issues.apache.org/jira/browse/LUCENE-8257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440487#comment-16440487
]
ASF subversion and git services commented on LUCENE-8257:
-
Commit ad6b173a6356b648e817b3146f2d78a4b959ab6c in lucene-solr's branch
refs/heads/branch_7x from [~kwri...@metacarta.com]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ad6b173 ]
LUCENE-8257: All edges have a backing plane, so edge membership doesn't bleed
through to the opposite side of the world.
> GeoComplexPolygon fails when points are near identical
> --
>
> Key: LUCENE-8257
> URL: https://issues.apache.org/jira/browse/LUCENE-8257
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial3d
>Reporter: Ignacio Vera
>Assignee: Karl Wright
>Priority: Major
> Attachments: LUCENE-8257.patch
>
>
> When a polygon have two consecutive points very close to each other but not
> numerically identical, we can get wrong results because planes defining that
> edge intersects somewhere else on the world. At that point the following
> check is evaluated to true:
> {code:java}
> if (edge.plane.evaluateIsZero(thePointX, thePointY, thePointZ) &&
> edge.startPlane.isWithin(thePointX, thePointY, thePointZ) &&
> edge.endPlane.isWithin(thePointX, thePointY, thePointZ)) {
> return false;
> }{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8257) GeoComplexPolygon fails when points are near identical
[
https://issues.apache.org/jira/browse/LUCENE-8257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440467#comment-16440467
]
Ignacio Vera commented on LUCENE-8257:
--
One thing I notice is that the start and end plane for that edge are
functionally identical. Maybe that condition can be used to check the need for
a backing side.
> GeoComplexPolygon fails when points are near identical
> --
>
> Key: LUCENE-8257
> URL: https://issues.apache.org/jira/browse/LUCENE-8257
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial3d
>Reporter: Ignacio Vera
>Assignee: Karl Wright
>Priority: Major
> Attachments: LUCENE-8257.patch
>
>
> When a polygon have two consecutive points very close to each other but not
> numerically identical, we can get wrong results because planes defining that
> edge intersects somewhere else on the world. At that point the following
> check is evaluated to true:
> {code:java}
> if (edge.plane.evaluateIsZero(thePointX, thePointY, thePointZ) &&
> edge.startPlane.isWithin(thePointX, thePointY, thePointZ) &&
> edge.endPlane.isWithin(thePointX, thePointY, thePointZ)) {
> return false;
> }{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8257) GeoComplexPolygon fails when points are near identical
[
https://issues.apache.org/jira/browse/LUCENE-8257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440442#comment-16440442
]
Karl Wright commented on LUCENE-8257:
-
For standard polygons, we wound up accepting the fact that points on the
opposite sides of the world would be within the shape, and even modified the
bounds computation to allow it. The question is whether that is what you are
seeing here?
> GeoComplexPolygon fails when points are near identical
> --
>
> Key: LUCENE-8257
> URL: https://issues.apache.org/jira/browse/LUCENE-8257
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial3d
>Reporter: Ignacio Vera
>Priority: Major
> Attachments: LUCENE-8257.patch
>
>
> When a polygon have two consecutive points very close to each other but not
> numerically identical, we can get wrong results because planes defining that
> edge intersects somewhere else on the world. At that point the following
> check is evaluated to true:
> {code:java}
> if (edge.plane.evaluateIsZero(thePointX, thePointY, thePointZ) &&
> edge.startPlane.isWithin(thePointX, thePointY, thePointZ) &&
> edge.endPlane.isWithin(thePointX, thePointY, thePointZ)) {
> return false;
> }{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
