[jira] [Commented] (LUCENE-8367) Make per-dimension drill down optional for each facet dimension
[
https://issues.apache.org/jira/browse/LUCENE-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525527#comment-16525527
]
ASF subversion and git services commented on LUCENE-8367:
-
Commit cfaa2b01f79e87fb26e0a3cb94be8ad406e1d12b in lucene-solr's branch
refs/heads/branch_7x from Mike McCandless
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cfaa2b0 ]
LUCENE-8367: make per-dimension drill down optional for each facet dimension
> Make per-dimension drill down optional for each facet dimension
> ---
>
> Key: LUCENE-8367
> URL: https://issues.apache.org/jira/browse/LUCENE-8367
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
>Reporter: Michael McCandless
>Assignee: Michael McCandless
>Priority: Major
> Fix For: master (8.0), 7.5
>
> Attachments: LUCENE-8367.patch, LUCENE-8367.patch
>
>
> Today, when you index a {{FacetField}} with path {{foo/bar,}} we index two
> drill down terms onto the document: {{foo}} and {{foo/bar}}.
> But I suspect some users (like me!) don't need to drilldown just on {{foo}}
> (effectively "find all documents that have any value for this facet
> dimension"), so I added an option to {{FacetsConfig}} to let you specify
> per-dimension whether you need to drill down (defaults to true, matching
> current behavior).
> I also added {{hashCode}} and {{equals}} to the {{LongRange}} and
> {{DoubleRange}} classes in facets module, and improved {{CheckIndex}} a bit
> to print the total %deletions across the index.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8367) Make per-dimension drill down optional for each facet dimension
[
https://issues.apache.org/jira/browse/LUCENE-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525526#comment-16525526
]
ASF subversion and git services commented on LUCENE-8367:
-
Commit e8d1057403b98dce08341c26b73724222d4a42b5 in lucene-solr's branch
refs/heads/master from Mike McCandless
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e8d1057 ]
LUCENE-8367: make per-dimension drill down optional for each facet dimension
> Make per-dimension drill down optional for each facet dimension
> ---
>
> Key: LUCENE-8367
> URL: https://issues.apache.org/jira/browse/LUCENE-8367
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
>Reporter: Michael McCandless
>Assignee: Michael McCandless
>Priority: Major
> Attachments: LUCENE-8367.patch, LUCENE-8367.patch
>
>
> Today, when you index a {{FacetField}} with path {{foo/bar,}} we index two
> drill down terms onto the document: {{foo}} and {{foo/bar}}.
> But I suspect some users (like me!) don't need to drilldown just on {{foo}}
> (effectively "find all documents that have any value for this facet
> dimension"), so I added an option to {{FacetsConfig}} to let you specify
> per-dimension whether you need to drill down (defaults to true, matching
> current behavior).
> I also added {{hashCode}} and {{equals}} to the {{LongRange}} and
> {{DoubleRange}} classes in facets module, and improved {{CheckIndex}} a bit
> to print the total %deletions across the index.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8367) Make per-dimension drill down optional for each facet dimension
[
https://issues.apache.org/jira/browse/LUCENE-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523219#comment-16523219
]
Lucene/Solr QA commented on LUCENE-8367:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
47s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 0m 44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 0m 40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 0m 40s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 26m
51s{color} | {color:green} core in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
34s{color} | {color:green} facet in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 38m 29s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-8367 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12929011/LUCENE-8367.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 095f9eb |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 8 2015 |
| Default Java | 1.8.0_172 |
| Test Results |
https://builds.apache.org/job/PreCommit-LUCENE-Build/39/testReport/ |
| modules | C: lucene/core lucene/facet U: lucene |
| Console output |
https://builds.apache.org/job/PreCommit-LUCENE-Build/39/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Make per-dimension drill down optional for each facet dimension
> ---
>
> Key: LUCENE-8367
> URL: https://issues.apache.org/jira/browse/LUCENE-8367
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
>Reporter: Michael McCandless
>Assignee: Michael McCandless
>Priority: Major
> Attachments: LUCENE-8367.patch, LUCENE-8367.patch
>
>
> Today, when you index a {{FacetField}} with path {{foo/bar,}} we index two
> drill down terms onto the document: {{foo}} and {{foo/bar}}.
> But I suspect some users (like me!) don't need to drilldown just on {{foo}}
> (effectively "find all documents that have any value for this facet
> dimension"), so I added an option to {{FacetsConfig}} to let you specify
> per-dimension whether you need to drill down (defaults to true, matching
> current behavior).
> I also added {{hashCode}} and {{equals}} to the {{LongRange}} and
> {{DoubleRange}} classes in facets module, and improved {{CheckIndex}} a bit
> to print the total %deletions across the index.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8367) Make per-dimension drill down optional for each facet dimension
[
https://issues.apache.org/jira/browse/LUCENE-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522121#comment-16522121
]
Michael McCandless commented on LUCENE-8367:
New patch, just switching to {{Double.compare}}.
> Make per-dimension drill down optional for each facet dimension
> ---
>
> Key: LUCENE-8367
> URL: https://issues.apache.org/jira/browse/LUCENE-8367
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
>Reporter: Michael McCandless
>Assignee: Michael McCandless
>Priority: Major
> Attachments: LUCENE-8367.patch, LUCENE-8367.patch
>
>
> Today, when you index a {{FacetField}} with path {{foo/bar,}} we index two
> drill down terms onto the document: {{foo}} and {{foo/bar}}.
> But I suspect some users (like me!) don't need to drilldown just on {{foo}}
> (effectively "find all documents that have any value for this facet
> dimension"), so I added an option to {{FacetsConfig}} to let you specify
> per-dimension whether you need to drill down (defaults to true, matching
> current behavior).
> I also added {{hashCode}} and {{equals}} to the {{LongRange}} and
> {{DoubleRange}} classes in facets module, and improved {{CheckIndex}} a bit
> to print the total %deletions across the index.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8367) Make per-dimension drill down optional for each facet dimension
[
https://issues.apache.org/jira/browse/LUCENE-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520557#comment-16520557
]
Lucene/Solr QA commented on LUCENE-8367:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 4s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 29m
43s{color} | {color:green} core in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
29s{color} | {color:green} facet in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 37m 52s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-8367 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12928696/LUCENE-8367.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 3b9d3a7 |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 8 2015 |
| Default Java | 1.8.0_172 |
| Test Results |
https://builds.apache.org/job/PreCommit-LUCENE-Build/38/testReport/ |
| modules | C: lucene/core lucene/facet U: lucene |
| Console output |
https://builds.apache.org/job/PreCommit-LUCENE-Build/38/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Make per-dimension drill down optional for each facet dimension
> ---
>
> Key: LUCENE-8367
> URL: https://issues.apache.org/jira/browse/LUCENE-8367
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
>Reporter: Michael McCandless
>Assignee: Michael McCandless
>Priority: Major
> Attachments: LUCENE-8367.patch
>
>
> Today, when you index a {{FacetField}} with path {{foo/bar,}} we index two
> drill down terms onto the document: {{foo}} and {{foo/bar}}.
> But I suspect some users (like me!) don't need to drilldown just on {{foo}}
> (effectively "find all documents that have any value for this facet
> dimension"), so I added an option to {{FacetsConfig}} to let you specify
> per-dimension whether you need to drill down (defaults to true, matching
> current behavior).
> I also added {{hashCode}} and {{equals}} to the {{LongRange}} and
> {{DoubleRange}} classes in facets module, and improved {{CheckIndex}} a bit
> to print the total %deletions across the index.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8367) Make per-dimension drill down optional for each facet dimension
[
https://issues.apache.org/jira/browse/LUCENE-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520218#comment-16520218
]
Michael McCandless commented on LUCENE-8367:
{quote}Should the DoubleRange equals() compare bits for safety like
Double.equals()? Otherwise with == its a bit smelly and buggy (-0 vs 0 and so
on).
{quote}
Oh good catch! Sneaky ... I'll switch to {{Double.equals}}. Thanks [~rcmuir]!
> Make per-dimension drill down optional for each facet dimension
> ---
>
> Key: LUCENE-8367
> URL: https://issues.apache.org/jira/browse/LUCENE-8367
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
>Reporter: Michael McCandless
>Assignee: Michael McCandless
>Priority: Major
> Attachments: LUCENE-8367.patch
>
>
> Today, when you index a {{FacetField}} with path {{foo/bar,}} we index two
> drill down terms onto the document: {{foo}} and {{foo/bar}}.
> But I suspect some users (like me!) don't need to drilldown just on {{foo}}
> (effectively "find all documents that have any value for this facet
> dimension"), so I added an option to {{FacetsConfig}} to let you specify
> per-dimension whether you need to drill down (defaults to true, matching
> current behavior).
> I also added {{hashCode}} and {{equals}} to the {{LongRange}} and
> {{DoubleRange}} classes in facets module, and improved {{CheckIndex}} a bit
> to print the total %deletions across the index.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8367) Make per-dimension drill down optional for each facet dimension
[
https://issues.apache.org/jira/browse/LUCENE-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520016#comment-16520016
]
Robert Muir commented on LUCENE-8367:
-
Looking at the code it seems like those ValueSources already call equals/etc on
the ranges today, so it seems good you fixed that.
Should the DoubleRange equals() compare bits for safety like Double.equals()?
Otherwise with == its a bit smelly and buggy (-0 vs 0 and so on).
> Make per-dimension drill down optional for each facet dimension
> ---
>
> Key: LUCENE-8367
> URL: https://issues.apache.org/jira/browse/LUCENE-8367
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
>Reporter: Michael McCandless
>Assignee: Michael McCandless
>Priority: Major
> Attachments: LUCENE-8367.patch
>
>
> Today, when you index a {{FacetField}} with path {{foo/bar,}} we index two
> drill down terms onto the document: {{foo}} and {{foo/bar}}.
> But I suspect some users (like me!) don't need to drilldown just on {{foo}}
> (effectively "find all documents that have any value for this facet
> dimension"), so I added an option to {{FacetsConfig}} to let you specify
> per-dimension whether you need to drill down (defaults to true, matching
> current behavior).
> I also added {{hashCode}} and {{equals}} to the {{LongRange}} and
> {{DoubleRange}} classes in facets module, and improved {{CheckIndex}} a bit
> to print the total %deletions across the index.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
