[jira] [Commented] (LUCENE-8447) Add DISJOINT and WITHIN support to LatLonShape queries
[
https://issues.apache.org/jira/browse/LUCENE-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573798#comment-16573798
]
ASF subversion and git services commented on LUCENE-8447:
-
Commit 3102c21e004d7384beff245f61bf8cb79639ebae in lucene-solr's branch
refs/heads/branch_7x from [~nknize]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3102c21 ]
LUCENE-8447: Add DISJOINT and WITHIN support to LatLonShape queries
> Add DISJOINT and WITHIN support to LatLonShape queries
> --
>
> Key: LUCENE-8447
> URL: https://issues.apache.org/jira/browse/LUCENE-8447
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Nicholas Knize
>Assignee: Nicholas Knize
>Priority: Major
> Attachments: LUCENE-8447.patch, LUCENE-8447.patch, LUCENE-8447.patch
>
>
> This feature will add support to {{LatLonShapeBoundingBoxQuery}} and
> {{LatLonShapePolygonQuery}} for searching all indexed {{LatLonShape}} types
> that are {{WITHIN}}, or {{DISJOINT}} to, the target query shape.
> {{INTERSECTS}} remains unchanged.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8447) Add DISJOINT and WITHIN support to LatLonShape queries
[
https://issues.apache.org/jira/browse/LUCENE-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573583#comment-16573583
]
ASF subversion and git services commented on LUCENE-8447:
-
Commit cbaedb470c8ddc7b21e8ff0b2729c6cf97fbd3d0 in lucene-solr's branch
refs/heads/master from [~nknize]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cbaedb4 ]
LUCENE-8447: Add DISJOINT and WITHIN support to LatLonShape queries
> Add DISJOINT and WITHIN support to LatLonShape queries
> --
>
> Key: LUCENE-8447
> URL: https://issues.apache.org/jira/browse/LUCENE-8447
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Nicholas Knize
>Assignee: Nicholas Knize
>Priority: Major
> Attachments: LUCENE-8447.patch, LUCENE-8447.patch, LUCENE-8447.patch
>
>
> This feature will add support to {{LatLonShapeBoundingBoxQuery}} and
> {{LatLonShapePolygonQuery}} for searching all indexed {{LatLonShape}} types
> that are {{WITHIN}}, or {{DISJOINT}} to, the target query shape.
> {{INTERSECTS}} remains unchanged.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8447) Add DISJOINT and WITHIN support to LatLonShape queries
[
https://issues.apache.org/jira/browse/LUCENE-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573547#comment-16573547
]
Lucene/Solr QA commented on LUCENE-8447:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 5 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 33m
7s{color} | {color:green} core in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
54s{color} | {color:green} sandbox in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 42m 50s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-8447 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12934824/LUCENE-8447.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 9b418a4 |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| Default Java | 1.8.0_172 |
| Test Results |
https://builds.apache.org/job/PreCommit-LUCENE-Build/68/testReport/ |
| modules | C: lucene lucene/core lucene/sandbox U: lucene |
| Console output |
https://builds.apache.org/job/PreCommit-LUCENE-Build/68/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Add DISJOINT and WITHIN support to LatLonShape queries
> --
>
> Key: LUCENE-8447
> URL: https://issues.apache.org/jira/browse/LUCENE-8447
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Nicholas Knize
>Assignee: Nicholas Knize
>Priority: Major
> Attachments: LUCENE-8447.patch, LUCENE-8447.patch, LUCENE-8447.patch
>
>
> This feature will add support to {{LatLonShapeBoundingBoxQuery}} and
> {{LatLonShapePolygonQuery}} for searching all indexed {{LatLonShape}} types
> that are {{WITHIN}}, or {{DISJOINT}} to, the target query shape.
> {{INTERSECTS}} remains unchanged.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8447) Add DISJOINT and WITHIN support to LatLonShape queries
[
https://issues.apache.org/jira/browse/LUCENE-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573516#comment-16573516
]
Adrien Grand commented on LUCENE-8447:
--
+1 I'd just keep the transpose() method as an impl detail rather than add it to
the points API.
> Add DISJOINT and WITHIN support to LatLonShape queries
> --
>
> Key: LUCENE-8447
> URL: https://issues.apache.org/jira/browse/LUCENE-8447
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Nicholas Knize
>Assignee: Nicholas Knize
>Priority: Major
> Attachments: LUCENE-8447.patch, LUCENE-8447.patch, LUCENE-8447.patch
>
>
> This feature will add support to {{LatLonShapeBoundingBoxQuery}} and
> {{LatLonShapePolygonQuery}} for searching all indexed {{LatLonShape}} types
> that are {{WITHIN}}, or {{DISJOINT}} to, the target query shape.
> {{INTERSECTS}} remains unchanged.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8447) Add DISJOINT and WITHIN support to LatLonShape queries
[
https://issues.apache.org/jira/browse/LUCENE-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572997#comment-16572997
]
Lucene/Solr QA commented on LUCENE-8447:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 5 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 0m 23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 0m 19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 0m 19s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m
35s{color} | {color:green} core in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 1m 58s{color}
| {color:red} sandbox in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 15m 12s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | lucene.document.TestLatLonLineShapeQueries |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-8447 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12934724/LUCENE-8447.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.4.0-130-generic #156~14.04.1-Ubuntu SMP Thu
Jun 14 13:51:47 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 38bf976 |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | 1.8.0_172 |
| unit |
https://builds.apache.org/job/PreCommit-LUCENE-Build/65/artifact/out/patch-unit-lucene_sandbox.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-LUCENE-Build/65/testReport/ |
| modules | C: lucene lucene/core lucene/sandbox U: lucene |
| Console output |
https://builds.apache.org/job/PreCommit-LUCENE-Build/65/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Add DISJOINT and WITHIN support to LatLonShape queries
> --
>
> Key: LUCENE-8447
> URL: https://issues.apache.org/jira/browse/LUCENE-8447
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Nicholas Knize
>Assignee: Nicholas Knize
>Priority: Major
> Attachments: LUCENE-8447.patch, LUCENE-8447.patch
>
>
> This feature will add support to {{LatLonShapeBoundingBoxQuery}} and
> {{LatLonShapePolygonQuery}} for searching all indexed {{LatLonShape}} types
> that are {{WITHIN}}, or {{DISJOINT}} to, the target query shape.
> {{INTERSECTS}} remains unchanged.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8447) Add DISJOINT and WITHIN support to LatLonShape queries
[
https://issues.apache.org/jira/browse/LUCENE-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571600#comment-16571600
]
Adrien Grand commented on LUCENE-8447:
--
Thanks Nick, it looks great. It looks like INTERSECTS now always creates dense
bitsets as opposed to filling a sparse DocIdSetBuilder (the one created in
LatLonShapeQuery is unused). I see how it's helping with code reuse but maybe
we should try to improve it in follow-ups. Regarding your comment about whether
the inverse optimization makes sense with DISJOINT and WITHIN, I think it has
limited benefits indeed. I wonder whether we should drop this optimization
entirely, as well as maybe the other one that checks whether all documents
match, in order to make shapes easier to maintain since I don't think these
optimizations would often kick in in practice. I suspect it will at least help
to remove them temporarily while we are iterating, even if we eventually decide
to add them back once the code stabilizes.
> Add DISJOINT and WITHIN support to LatLonShape queries
> --
>
> Key: LUCENE-8447
> URL: https://issues.apache.org/jira/browse/LUCENE-8447
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Nicholas Knize
>Assignee: Nicholas Knize
>Priority: Major
> Attachments: LUCENE-8447.patch
>
>
> This feature will add support to {{LatLonShapeBoundingBoxQuery}} and
> {{LatLonShapePolygonQuery}} for searching all indexed {{LatLonShape}} types
> that are {{WITHIN}}, or {{DISJOINT}} to, the target query shape.
> {{INTERSECTS}} remains unchanged.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
