[jira] [Commented] (LUCENE-8805) Parameter changes for stringField() in StoredFieldVisitor

2019-05-21 Thread Namgyu Kim (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845383#comment-16845383 ] Namgyu Kim commented on LUCENE-8805: Thank you for applying my patch! [~jpountz] and [~rcmuir] >

[jira] [Commented] (LUCENE-8805) Parameter changes for stringField() in StoredFieldVisitor

2019-05-21 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845121#comment-16845121 ] Robert Muir commented on LUCENE-8805: - +1 > Parameter changes for stringField() in

[jira] [Commented] (LUCENE-8805) Parameter changes for stringField() in StoredFieldVisitor

2019-05-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845112#comment-16845112 ] ASF subversion and git services commented on LUCENE-8805: - Commit

[jira] [Commented] (LUCENE-8805) Parameter changes for stringField() in StoredFieldVisitor

2019-05-21 Thread Namgyu Kim (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844825#comment-16844825 ] Namgyu Kim commented on LUCENE-8805: Oops, I saw it wrong :( I modified it and uploaded a new patch!

[jira] [Commented] (LUCENE-8805) Parameter changes for stringField() in StoredFieldVisitor

2019-05-20 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844183#comment-16844183 ] Adrien Grand commented on LUCENE-8805: -- The patch looks good in general. In SolrDocumentFetcher,

[jira] [Commented] (LUCENE-8805) Parameter changes for stringField() in StoredFieldVisitor

2019-05-20 Thread Namgyu Kim (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844143#comment-16844143 ] Namgyu Kim commented on LUCENE-8805: I uploaded a new patch with only stringField modified