[jira] [Commented] (LUCENE-8900) Simplify MultiSorter

2019-07-09 Thread Namgyu Kim (JIRA) 


[ 
https://issues.apache.org/jira/browse/LUCENE-8900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881302#comment-16881302
 ] 

Namgyu Kim commented on LUCENE-8900:


You're welcome! [~jpountz].

> Simplify MultiSorter
> 
>
> Key: LUCENE-8900
> URL: https://issues.apache.org/jira/browse/LUCENE-8900
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Adrien Grand
>Priority: Minor
> Fix For: 8.2
>
> Attachments: LUCENE-8900.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-8900) Simplify MultiSorter

2019-07-09 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/LUCENE-8900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881293#comment-16881293
 ] 

ASF subversion and git services commented on LUCENE-8900:
-

Commit 17f2f96a5cf8e0001a81b9327c2ddced053e6934 in lucene-solr's branch 
refs/heads/master from Adrien Grand
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=17f2f96 ]

LUCENE-8900: Simplify MultiSorter.


> Simplify MultiSorter
> 
>
> Key: LUCENE-8900
> URL: https://issues.apache.org/jira/browse/LUCENE-8900
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Adrien Grand
>Priority: Minor
> Attachments: LUCENE-8900.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-8900) Simplify MultiSorter

2019-07-09 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/LUCENE-8900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881289#comment-16881289
 ] 

ASF subversion and git services commented on LUCENE-8900:
-

Commit aad4b411cdd2d517328a2444147b407d4a38343d in lucene-solr's branch 
refs/heads/branch_8x from Adrien Grand
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=aad4b41 ]

LUCENE-8900: Simplify MultiSorter.


> Simplify MultiSorter
> 
>
> Key: LUCENE-8900
> URL: https://issues.apache.org/jira/browse/LUCENE-8900
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Adrien Grand
>Priority: Minor
> Attachments: LUCENE-8900.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-8900) Simplify MultiSorter

2019-07-03 Thread Namgyu Kim (JIRA) 


[ 
https://issues.apache.org/jira/browse/LUCENE-8900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877924#comment-16877924
 ] 

Namgyu Kim commented on LUCENE-8900:


Oh, about the suggestion 2, I saw it wrong.
It can cause a ClassCastException :(

Sorry for confusing and thank you for taking the suggestion 1.

> Simplify MultiSorter
> 
>
> Key: LUCENE-8900
> URL: https://issues.apache.org/jira/browse/LUCENE-8900
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Adrien Grand
>Priority: Minor
> Attachments: LUCENE-8900.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-8900) Simplify MultiSorter

2019-07-02 Thread Adrien Grand (JIRA) 


[ 
https://issues.apache.org/jira/browse/LUCENE-8900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877183#comment-16877183
 ] 

Adrien Grand commented on LUCENE-8900:
--

Thanks [~danmuzi], I will apply your first suggestion. However I can't apply 2 
because I merged the logic for integers and longs, which means that is some 
cases the missing value will be an Integer and in other cases it will be a Long.

> Simplify MultiSorter
> 
>
> Key: LUCENE-8900
> URL: https://issues.apache.org/jira/browse/LUCENE-8900
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Adrien Grand
>Priority: Minor
> Attachments: LUCENE-8900.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-8900) Simplify MultiSorter

2019-07-02 Thread Namgyu Kim (JIRA) 


[ 
https://issues.apache.org/jira/browse/LUCENE-8900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877180#comment-16877180
 ] 

Namgyu Kim commented on LUCENE-8900:


+1

This patch looks good. [~jpountz] :D
 I have some opinions about your patch.

1. In lessThan method in PriorityQueue, we can reduce the computation. (very 
minor difference)
 Before
{code:java}
public boolean lessThan(LeafAndDocID a, LeafAndDocID b) {
  for(int i=0;i Simplify MultiSorter
> 
>
> Key: LUCENE-8900
> URL: https://issues.apache.org/jira/browse/LUCENE-8900
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Adrien Grand
>Priority: Minor
> Attachments: LUCENE-8900.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org