[jira] [Commented] (SOLR-10042) Delete old deprecated Admin UI
[ https://issues.apache.org/jira/browse/SOLR-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017270#comment-16017270 ] ASF subversion and git services commented on SOLR-10042: Commit 467af790cbf50b5633204e384c0efbf19fad30de in lucene-solr's branch refs/heads/master from [~janhoy] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=467af79 ] SOLR-10042: Clean up old comments from Angular UI code > Delete old deprecated Admin UI > -- > > Key: SOLR-10042 > URL: https://issues.apache.org/jira/browse/SOLR-10042 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Admin UI >Reporter: Jan Høydahl >Assignee: Jan Høydahl > Fix For: master (7.0) > > Attachments: SOLR-10042.patch, SOLR-10042_remove_commented.patch > > > The old jQuery based Admin UI has been deprecated since 6.0. Let us clean up > the last known bugs in Angular UI and simply delete the old UI in master. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10042) Delete old deprecated Admin UI
[ https://issues.apache.org/jira/browse/SOLR-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017264#comment-16017264 ] ASF subversion and git services commented on SOLR-10042: Commit 467af790cbf50b5633204e384c0efbf19fad30de in lucene-solr's branch refs/heads/master2 from [~janhoy] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=467af79 ] SOLR-10042: Clean up old comments from Angular UI code > Delete old deprecated Admin UI > -- > > Key: SOLR-10042 > URL: https://issues.apache.org/jira/browse/SOLR-10042 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Admin UI >Reporter: Jan Høydahl >Assignee: Jan Høydahl > Fix For: master (7.0) > > Attachments: SOLR-10042.patch, SOLR-10042_remove_commented.patch > > > The old jQuery based Admin UI has been deprecated since 6.0. Let us clean up > the last known bugs in Angular UI and simply delete the old UI in master. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10042) Delete old deprecated Admin UI
[ https://issues.apache.org/jira/browse/SOLR-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017204#comment-16017204 ] Upayavira commented on SOLR-10042: -- SOLR-10042_remove_commented.patch removes stuff that was meant to remind me of unimplemented features. I eventually stopped using that method, but failed to clean up. These comments are redundant and can be removed. > Delete old deprecated Admin UI > -- > > Key: SOLR-10042 > URL: https://issues.apache.org/jira/browse/SOLR-10042 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Admin UI >Reporter: Jan Høydahl >Assignee: Jan Høydahl > Fix For: master (7.0) > > Attachments: SOLR-10042.patch, SOLR-10042_remove_commented.patch > > > The old jQuery based Admin UI has been deprecated since 6.0. Let us clean up > the last known bugs in Angular UI and simply delete the old UI in master. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10042) Delete old deprecated Admin UI
[ https://issues.apache.org/jira/browse/SOLR-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017099#comment-16017099 ] Jan Høydahl commented on SOLR-10042: Thanks Tomas! > Delete old deprecated Admin UI > -- > > Key: SOLR-10042 > URL: https://issues.apache.org/jira/browse/SOLR-10042 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Admin UI >Reporter: Jan Høydahl >Assignee: Jan Høydahl > Fix For: master (7.0) > > Attachments: SOLR-10042.patch, SOLR-10042_remove_commented.patch > > > The old jQuery based Admin UI has been deprecated since 6.0. Let us clean up > the last known bugs in Angular UI and simply delete the old UI in master. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10042) Delete old deprecated Admin UI
[ https://issues.apache.org/jira/browse/SOLR-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016712#comment-16016712 ] ASF subversion and git services commented on SOLR-10042: Commit d30d012c7c2f9de46a32d7e9eda3b17c51a7fa04 in lucene-solr's branch refs/heads/master from Tomas Fernandez Lobbe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d30d012 ] SOLR-10042, LUCENE-7838: Fix precommit > Delete old deprecated Admin UI > -- > > Key: SOLR-10042 > URL: https://issues.apache.org/jira/browse/SOLR-10042 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Admin UI >Reporter: Jan Høydahl >Assignee: Jan Høydahl > Fix For: master (7.0) > > Attachments: SOLR-10042.patch, SOLR-10042_remove_commented.patch > > > The old jQuery based Admin UI has been deprecated since 6.0. Let us clean up > the last known bugs in Angular UI and simply delete the old UI in master. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10042) Delete old deprecated Admin UI
[ https://issues.apache.org/jira/browse/SOLR-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016367#comment-16016367 ] Alexandre Rafalovitch commented on SOLR-10042: -- I think the commented out part was the unimplemented features. But some of them got implemented later through their own JIRAs. I think it is safe to not worry about it and just let people report the issues found normally. > Delete old deprecated Admin UI > -- > > Key: SOLR-10042 > URL: https://issues.apache.org/jira/browse/SOLR-10042 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Admin UI >Reporter: Jan Høydahl >Assignee: Jan Høydahl > Fix For: master (7.0) > > Attachments: SOLR-10042.patch > > > The old jQuery based Admin UI has been deprecated since 6.0. Let us clean up > the last known bugs in Angular UI and simply delete the old UI in master. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10042) Delete old deprecated Admin UI
[ https://issues.apache.org/jira/browse/SOLR-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015653#comment-16015653 ] ASF subversion and git services commented on SOLR-10042: Commit 21384b5b215a68233cb3ef9edaea14be935570b9 in lucene-solr's branch refs/heads/master from [~janhoy] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=21384b5 ] SOLR-10042: Delete old deprecated Admin UI > Delete old deprecated Admin UI > -- > > Key: SOLR-10042 > URL: https://issues.apache.org/jira/browse/SOLR-10042 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Admin UI >Reporter: Jan Høydahl >Assignee: Jan Høydahl > Fix For: master (7.0) > > Attachments: SOLR-10042.patch > > > The old jQuery based Admin UI has been deprecated since 6.0. Let us clean up > the last known bugs in Angular UI and simply delete the old UI in master. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10042) Delete old deprecated Admin UI
[ https://issues.apache.org/jira/browse/SOLR-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015609#comment-16015609 ] Jan Høydahl commented on SOLR-10042: Found one showstopper - the autocomplete plugin used by velocity requires an older version of jquery. I think I'll try to place a copy of the older jquery inside velocity and open a JIRA to migrate later. > Delete old deprecated Admin UI > -- > > Key: SOLR-10042 > URL: https://issues.apache.org/jira/browse/SOLR-10042 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Admin UI >Reporter: Jan Høydahl >Assignee: Jan Høydahl > Fix For: master (7.0) > > Attachments: SOLR-10042.patch > > > The old jQuery based Admin UI has been deprecated since 6.0. Let us clean up > the last known bugs in Angular UI and simply delete the old UI in master. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10042) Delete old deprecated Admin UI
[
https://issues.apache.org/jira/browse/SOLR-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015528#comment-16015528
]
Jan Høydahl commented on SOLR-10042:
Anyone remember what the commented-out lines in {{app.js}} is about? See
https://github.com/apache/lucene-solr/blob/e2521b2a8baabdaf43b92192588f51e042d21e97/solr/webapp/web/js/angular/app.js#L551
Does it have a JIRA issue or is not necessary?
> Delete old deprecated Admin UI
> --
>
> Key: SOLR-10042
> URL: https://issues.apache.org/jira/browse/SOLR-10042
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Admin UI
>Reporter: Jan Høydahl
>Assignee: Jan Høydahl
> Fix For: master (7.0)
>
> Attachments: SOLR-10042.patch
>
>
> The old jQuery based Admin UI has been deprecated since 6.0. Let us clean up
> the last known bugs in Angular UI and simply delete the old UI in master.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10042) Delete old deprecated Admin UI
[ https://issues.apache.org/jira/browse/SOLR-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012060#comment-16012060 ] Stefan Matheis (steffkes) commented on SOLR-10042: -- [~janhoy] LGTM. as far as i know the structure is pretty well separated between the old and the current UI, so it should be okay to remove all the old files, yepp > Delete old deprecated Admin UI > -- > > Key: SOLR-10042 > URL: https://issues.apache.org/jira/browse/SOLR-10042 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Admin UI >Reporter: Jan Høydahl >Assignee: Jan Høydahl > Fix For: master (7.0) > > Attachments: SOLR-10042.patch > > > The old jQuery based Admin UI has been deprecated since 6.0. Let us clean up > the last known bugs in Angular UI and simply delete the old UI in master. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10042) Delete old deprecated Admin UI
[ https://issues.apache.org/jira/browse/SOLR-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012054#comment-16012054 ] Jan Høydahl commented on SOLR-10042: Calling out to [~upayavira] and [~steffkes], does this patch seem viable? Are you aware of any other open JIRA that should be a blocker for committing this? If I don't hear anything I'll commit current patch to master on thursday. > Delete old deprecated Admin UI > -- > > Key: SOLR-10042 > URL: https://issues.apache.org/jira/browse/SOLR-10042 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Admin UI >Reporter: Jan Høydahl > Fix For: master (7.0) > > Attachments: SOLR-10042.patch > > > The old jQuery based Admin UI has been deprecated since 6.0. Let us clean up > the last known bugs in Angular UI and simply delete the old UI in master. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10042) Delete old deprecated Admin UI
[
https://issues.apache.org/jira/browse/SOLR-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000572#comment-16000572
]
Jan Høydahl commented on SOLR-10042:
The blocker issue I was thinking about was SOLR-9516 which is now resolved. So
can someone please review my patch. What it does is basically:
* Delete webapp/web/css/styles
* Delete webapp/web/css/chosen.css
* Delete webapp/web/js/lib
* Delete webapp/web/js/scripts
* Delete webapp/web/js/main.js
* Delete webapp/web/js/require.js
* Delete webapp/web/tpl
* Delete webapp/web/old.html
* Switches velocity code from {{js/lib/jquery-1.7.2.min.js}} to
{{/libs/jquery-2.1.3.min.js}} (not tested)
* Remove javacscript-natural-sort-NOTICE.txt and license
* Rips out "Dump" feature and removes ZeroClipboard from wherever, inlcuding
NOTICE.txt
* Moves {{java-properties.css}} from styles/ to angular/
* Removes link to old UI in index.html
The patch works without breaking anything as far I can tell, but I may have
overlooked some file or deleted too much without knowing, please speak out.
> Delete old deprecated Admin UI
> --
>
> Key: SOLR-10042
> URL: https://issues.apache.org/jira/browse/SOLR-10042
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Admin UI
>Reporter: Jan Høydahl
> Fix For: master (7.0)
>
> Attachments: SOLR-10042.patch
>
>
> The old jQuery based Admin UI has been deprecated since 6.0. Let us clean up
> the last known bugs in Angular UI and simply delete the old UI in master.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10042) Delete old deprecated Admin UI
[ https://issues.apache.org/jira/browse/SOLR-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1675#comment-1675 ] Jan Høydahl commented on SOLR-10042: Linking some Angular UI bugs as "requires". I don't mean that all of these need to be fixed before we kill the old UI, but probably some of them should. We can discuss that further here and then attempt fixing the most serious ones before deleting the old UI code. > Delete old deprecated Admin UI > -- > > Key: SOLR-10042 > URL: https://issues.apache.org/jira/browse/SOLR-10042 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Admin UI >Reporter: Jan Høydahl > Fix For: master (7.0) > > > The old jQuery based Admin UI has been deprecated since 6.0. Let us clean up > the last known bugs in Angular UI and simply delete the old UI in master. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10042) Delete old deprecated Admin UI
[ https://issues.apache.org/jira/browse/SOLR-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839828#comment-15839828 ] Jan Høydahl commented on SOLR-10042: Feel free :) And then before closing this and releasing 7.0 we decide whether remaining liked issues are blockers or not. > Delete old deprecated Admin UI > -- > > Key: SOLR-10042 > URL: https://issues.apache.org/jira/browse/SOLR-10042 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: UI >Reporter: Jan Høydahl > Fix For: master (7.0) > > > The old jQuery based Admin UI has been deprecated since 6.0. Let us clean up > the last known bugs in Angular UI and simply delete the old UI in master. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10042) Delete old deprecated Admin UI
[ https://issues.apache.org/jira/browse/SOLR-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839730#comment-15839730 ] Alexandre Rafalovitch commented on SOLR-10042: -- Should we use this one as a umbrella issue and link open UI bugs into it? > Delete old deprecated Admin UI > -- > > Key: SOLR-10042 > URL: https://issues.apache.org/jira/browse/SOLR-10042 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: UI >Reporter: Jan Høydahl > Fix For: master (7.0) > > > The old jQuery based Admin UI has been deprecated since 6.0. Let us clean up > the last known bugs in Angular UI and simply delete the old UI in master. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
