[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-03-07 Thread Shalin Shekhar Mangar (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389452#comment-16389452
 ] 

Shalin Shekhar Mangar commented on SOLR-11066:
--

Another one:
{code}
SOLR-11066: Use timeZone.toZoneId instead of ZoneId.of(timeZoneString) because 
the latter cannot lookup short aliases

Master: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/498927d0
branch_7x: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/8cc98868
{code}

> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066-test-fix.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-03-06 Thread Shalin Shekhar Mangar (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388320#comment-16388320
 ] 

Shalin Shekhar Mangar commented on SOLR-11066:
--

Another commit missed by jira bot:
{code}
SOLR-11066: Renamed the internal ScheduledTriggers.ScheduledTrigger inner class 
to TriggerWrapper to avoid confusion with the ScheduledTrigger added in this 
issue

Master: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/8b9a1adb
branch_7x: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/05297278
{code}

> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066-test-fix.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-03-06 Thread Shalin Shekhar Mangar (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388029#comment-16388029
 ] 

Shalin Shekhar Mangar commented on SOLR-11066:
--

Jirabot missed a commit I made:

{code}
SOLR-11066: Added examples of startTime in ref guide. Added null check for 
processor and code comments to explain skipped events and lastRunAt 
initialization. Moved default preferredOp value to ComputePlanAction. Extracted 
a constant.

master: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/9cec2221
branch_7x: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/29060a7b
{code}

> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066-test-fix.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-03-05 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385818#comment-16385818
 ] 

ASF subversion and git services commented on SOLR-11066:


Commit f711d475ba206f430c91edce1cfcb6c8c282e26d in lucene-solr's branch 
refs/heads/branch_7x from [~shalinmangar]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f711d47 ]

SOLR-11066: Fix TriggerIntegrationTest.testScheduledTrigger by ensuring number 
of jetties is always 2 before start of test

(cherry picked from commit 3344306)


> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066-test-fix.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-03-05 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385817#comment-16385817
 ] 

ASF subversion and git services commented on SOLR-11066:


Commit 334430647356bbd404442121fb968329aa581f54 in lucene-solr's branch 
refs/heads/master from [~shalinmangar]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3344306 ]

SOLR-11066: Fix TriggerIntegrationTest.testScheduledTrigger by ensuring number 
of jetties is always 2 before start of test


> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066-test-fix.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-03-05 Thread Shalin Shekhar Mangar (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385795#comment-16385795
 ] 

Shalin Shekhar Mangar commented on SOLR-11066:
--

I found the cause of the test failures. I had beasted the new test before 
committing but the failures were always suite failures and depended on the 
order the tests were executed. The root cause was that some tests start 
additional nodes which are not shutdown. This causes the cluster layout 
assumption made in testScheduledTrigger to be wrong and therefore the test 
fails. This patch fixes the TriggerIntegrationTest to ensure that the 
beforeTest method keeps exactly 2 jetties running.

> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066-test-fix.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-03-03 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384825#comment-16384825
 ] 

ASF subversion and git services commented on SOLR-11066:


Commit 1a3468b87282a9743b7176d9eaeb603e4968 in lucene-solr's branch 
refs/heads/branch_7x from [~shalinmangar]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1a3468b ]

SOLR-11066: Marking the test as AwaitsFix until the test failures on jenkins 
are investigated and fixed

(cherry picked from commit 78f11d0)


> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-03-03 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384823#comment-16384823
 ] 

ASF subversion and git services commented on SOLR-11066:


Commit 78f11d05acc8730986d23eda7011b00b213d0fe5 in lucene-solr's branch 
refs/heads/master from [~shalinmangar]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=78f11d0 ]

SOLR-11066: Marking the test as AwaitsFix until the test failures on jenkins 
are investigated and fixed


> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-03-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384041#comment-16384041
 ] 

ASF subversion and git services commented on SOLR-11066:


Commit a7dc153a22f46e1d14307c57ab815ac5c96321b7 in lucene-solr's branch 
refs/heads/branch_7x from [~shalinmangar]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a7dc153 ]

SOLR-11066: Implement a scheduled autoscaling trigger that runs on a fixed 
interval beginning with a given start time

(cherry picked from commit 71fc9cd)


> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-03-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384039#comment-16384039
 ] 

ASF subversion and git services commented on SOLR-11066:


Commit 71fc9cd43d0001ca0e66a443654b091485b21a46 in lucene-solr's branch 
refs/heads/master from [~shalinmangar]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=71fc9cd ]

SOLR-11066: Implement a scheduled autoscaling trigger that runs on a fixed 
interval beginning with a given start time


> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-03-02 Thread Shalin Shekhar Mangar (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384038#comment-16384038
 ] 

Shalin Shekhar Mangar commented on SOLR-11066:
--

Removed a nocommit in the test I had put in for debugging earlier. Also fixes 
forbidden API usage in ScheduledTriggerTest. Tests and precommit pass. I'll 
commit this now.

> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-03-02 Thread Shalin Shekhar Mangar (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384011#comment-16384011
 ] 

Shalin Shekhar Mangar commented on SOLR-11066:
--

Final patch with some additional code comments after SOLR-12023/SOLR-12031 was 
fixed.

> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-02-25 Thread Shalin Shekhar Mangar (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376421#comment-16376421
 ] 

Shalin Shekhar Mangar commented on SOLR-11066:
--

Blocked by SOLR-12023

> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-02-22 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372865#comment-16372865
 ] 

ASF subversion and git services commented on SOLR-11066:


Commit 4446545de64926eb97bc6160c34c76f25cc7fe7c in lucene-solr's branch 
refs/heads/master from [~shalinmangar]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4446545 ]

Revert "SOLR-11066: Implement a scheduled autoscaling trigger that runs on a 
fixed interval beginning with a given start time"

This reverts commit 137e647


> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-02-22 Thread Shalin Shekhar Mangar (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372864#comment-16372864
 ] 

Shalin Shekhar Mangar commented on SOLR-11066:
--

There are a few test failures on jenkins after the commit on master so I am 
going to revert it until I fix the tests.

> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-02-21 Thread Shalin Shekhar Mangar (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372386#comment-16372386
 ] 

Shalin Shekhar Mangar commented on SOLR-11066:
--

Final patch attached with ref guide changes. I'll commit this to master now.

> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-02-19 Thread Shalin Shekhar Mangar (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369720#comment-16369720
 ] 

Shalin Shekhar Mangar commented on SOLR-11066:
--

This patch adds support for Ignored events in ScheduledTrigger. In case where 
grace time has elapsed and the event is to be skipped, the listener is fired 
with stage=Ignored so that it is possible to perform some useful action on it.

> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch, SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-02-18 Thread Shalin Shekhar Mangar (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368808#comment-16368808
 ] 

Shalin Shekhar Mangar commented on SOLR-11066:
--

This patch adds an integration test as well as hooks to create the trigger via 
the APIs.

> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch, 
> SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-01-31 Thread Shalin Shekhar Mangar (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347521#comment-16347521
 ] 

Shalin Shekhar Mangar commented on SOLR-11066:
--

Thanks David, Gus and Andrzej!

The latest patch has the following changes:
# graceTime is renamed to graceDuration
# The trigger accepts a startTime which must be an ISO-8601 date time string 
ending with the 'Z' (signalling UTC) or without 'Z'. If the date time is 
without 'Z' then a time zone must be specified.
# The date math is done using the given time zone or UTC if none given
# The calculations in the trigger are all done using the Instant class
# The configuration stored in ZK is exactly what the user provided while 
creating the API.

bq. It's not clear to me looking at the patch how these ScheduledTriggers are 
created.  Can you please explain?  I was anticipating some new API call to 
create the trigger.

The trigger is created using the existing set-trigger API so no API changes 
were made. This is also the reason behind keeping the configuration in ZK the 
same as what was given by the user. The alternative would have been for the API 
to know that scheduled trigger is special and it may require modifying the 
provided startTime value to UTC. The downside to the current approach is that 
there is no validation of the properties until a Trigger is instantiated or 
initialized.

I'm going to open another issue to add a general validation API to Trigger 
which can be used for validating input configuration to avoid set-trigger calls 
with bad input succeeding.

> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-01-29 Thread Andrzej Bialecki (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343038#comment-16343038
 ] 

Andrzej Bialecki  commented on SOLR-11066:
--

+1 to require {{Z}} and UTC, with optional {{TZ}}. I think that ultimately it’s 
better to mandate a single format for a time instant, at least in the config - 
we could be perhaps more lenient in the user APIs, or provide a suggested value 
expressed in UTC inside the error message.

> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066.patch, SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-01-27 Thread Gus Heck (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342462#comment-16342462
 ] 

Gus Heck commented on SOLR-11066:
-

As dave previously pointed out to me, SOLR-2690 has discussion of the rational 
behind the original TZ param. FWIW I would think start time ought to be UTC for 
consistency sake. At a minimum it should accept and respect a time stamp with a 
final Z if the user provides it, and this should not necessarily set the TZ 
parameter. 
{code:java}
"startTime": "2018-01-26T21:00:00Z",
"TZ" : "America/St_Vincent"{code}
Should mean starting at that clear and unambiguous instant, and performing 
DateMath calculations per the St Vincent timezone. 

> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066.patch, SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-01-27 Thread David Smiley (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342400#comment-16342400
 ] 

David Smiley commented on SOLR-11066:
-

Solr has some conventions here already... "TZ" is Solr's timezone parameter.  
It has been exclusively used for date math semantics alone – all times are 
fully unambiguous with Z==UTC.  I've working on Time Routed Aliases with 
[~gus_heck] and we followed this convention.  I guess I'm okay with allowing 
startTime to not have a trailing 'Z' provided that in this circumstance, we 
insist that TZ is provided.

graceTime should probably be renamed graceDuration since it is not a time 
(startTime is a time).  I like the readability of using date math.  With Time 
Routed Aliases there's a little internal setting "max-future-ms" that is in 
milliseconds but I hesitated a bit on wether to use date math.  Maybe we should 
have.

It's not clear to me looking at the patch how these ScheduledTriggers are 
created.  Can you please explain?  I was anticipating some new API call to 
create the trigger.

> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066.patch, SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-01-27 Thread Shalin Shekhar Mangar (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342295#comment-16342295
 ] 

Shalin Shekhar Mangar commented on SOLR-11066:
--

Example configuration looks like this with the latest patch:
{code}
{
  "name": "scheduled_trigger_1",
  "type": "scheduled",
  "startTime": "2018-01-26T21:00:00",
  "every": "+1DAY",
  "graceTime": "+1MINUTE",
  "timeZone" : "America/St_Vincent"
}
{code}

> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066.patch, SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-01-27 Thread Shalin Shekhar Mangar (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342294#comment-16342294
 ] 

Shalin Shekhar Mangar commented on SOLR-11066:
--

This patch adds a {{timeZone}} configuration parameter. It also changes 
{{graceTime}} to be a date math string instead of milliseconds.

> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066.patch, SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-01-27 Thread Shalin Shekhar Mangar (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342277#comment-16342277
 ] 

Shalin Shekhar Mangar commented on SOLR-11066:
--

Thanks David. I actually did not want the trailing 'Z' because it signals that 
the date is represented in UTC. I think that it is an overhead to the user to 
convert their local timezone to UTC to call/use this API. I will introduce a 
timeZone configuration parameter to remove chances of confusion.  If the 
timeZone parameter is missing then we can default to the server's timezone. 
What do you think?

> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-01-26 Thread David Smiley (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341645#comment-16341645
 ] 

David Smiley commented on SOLR-11066:
-

Shouldn't startTime end in a 'Z', as is standard in Solr?  Why use a custom 
SimpleDateFormat, which by the way is an old API?Simply parse using 
DateMathParser.parse(str).toInstant(), and an Instant has a toString() of the 
standard ISO-8601 with 'Z'

DEFAULT_GRACE_TIME_MS could be more clearly defined as: 
{{TimeUnit.MINUTES.toMillis(15)}}

> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-11066) Implement a scheduled trigger

2018-01-26 Thread Shalin Shekhar Mangar (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341625#comment-16341625
 ] 

Shalin Shekhar Mangar commented on SOLR-11066:
--

This patch is a first cut of the feature. Integration tests are still pending. 
The configuration of the trigger supports the following parameter:
{code}
{
  "name": "scheduled_trigger_1",
  "type": "scheduled",
  "startTime": "2018-01-26T21:00:00",
  "every": "+1DAY",
  "graceTime": "6"
}
{code}

# {{startTime}} is a date in the format {{-MM-dd'T'HH:mm:ss}}. If not 
specified then it will default to the trigger's creation time.
# {{every}} is a string which follows Solr's date math parser syntax e.g. 
{{+1DAY}}, {{+12HOURS}} etc. (note date math supports subtraction but using 
such expression will ensure that the trigger never produces an event
# {{graceTime}} is the number of milliseconds after the next scheduled time 
within which the trigger will fire an event (if it was not able to fire at the 
exact right time). It defaults to 15 minutes.

The trigger itself is quite simple. It applies the {{every}} date match 
expression on the {{startTime}} or the last fire time to derive the next 
scheduled time and if current time is greater than next scheduled time but 
within {{graceTime}} milliseconds then an event is generated.

> Implement a scheduled trigger
> -
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: AutoScaling, SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 
> 24 hours starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org