[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435662#comment-16435662
]
Gus Heck commented on SOLR-11487:
-
{quote}Decomposing aliases.json has pros/cons, but it won't remove the
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434467#comment-16434467
]
Varun Thacker commented on SOLR-11487:
--
Hi David,
I've added the fix version as 7.2 for this Jira
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257676#comment-16257676
]
ASF subversion and git services commented on SOLR-11487:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257672#comment-16257672
]
ASF subversion and git services commented on SOLR-11487:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255784#comment-16255784
]
ASF subversion and git services commented on SOLR-11487:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255782#comment-16255782
]
ASF subversion and git services commented on SOLR-11487:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255683#comment-16255683
]
Gus Heck commented on SOLR-11487:
-
* Bug: heh, I almost wrote a test for that too... I clearly should
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252963#comment-16252963
]
David Smiley commented on SOLR-11487:
-
This looks really good, I'll commit this with some very small
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252802#comment-16252802
]
Gus Heck commented on SOLR-11487:
-
All good points, many of them bits that didn't get cleaned up as
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252748#comment-16252748
]
Gus Heck commented on SOLR-11487:
-
* compute if absent: used it in the constructor, elsewhere we don't
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250254#comment-16250254
]
David Smiley commented on SOLR-11487:
-
Looks like we're finally super close!
Aliases:
* good -- all
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246858#comment-16246858
]
David Smiley commented on SOLR-11487:
-
* The zkVersion int need not be volatile because it is only
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245905#comment-16245905
]
Gus Heck commented on SOLR-11487:
-
* Consolidation of the alias related stuff in ZkStateReader is nice.
*
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242826#comment-16242826
]
Gus Heck commented on SOLR-11487:
-
Added SOLR-11617 to track the creation of an API
> Collection Alias
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242637#comment-16242637
]
Gus Heck commented on SOLR-11487:
-
{quote}Decomposing aliases.json has pros/cons, but it won't remove the
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242236#comment-16242236
]
David Smiley commented on SOLR-11487:
-
Decomposing aliases.json has pros/cons, but it won't remove the
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242091#comment-16242091
]
Gus Heck commented on SOLR-11487:
-
*Constructor* - Yeah that can be simplified. Much of the code directly
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240417#comment-16240417
]
David Smiley commented on SOLR-11487:
-
Aliases
* constructor is confusing to me; you save aliasMap to
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225618#comment-16225618
]
David Smiley commented on SOLR-11487:
-
*Aliases.java*
* cloneAliases: you can probably reduce the LOC
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224353#comment-16224353
]
Gus Heck commented on SOLR-11487:
-
Attaching revised patch.
Highlights:
* Immutability was restored
*
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216287#comment-16216287
]
David Smiley commented on SOLR-11487:
-
Fantastic response to my code review by the way :-)
RE
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216223#comment-16216223
]
Gus Heck commented on SOLR-11487:
-
Thx for the review Dave.
I'll start in on some of the fix-ups, here's
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215893#comment-16215893
]
David Smiley commented on SOLR-11487:
-
BTW FWIW RE TimeOut... IMO it'd be more nice to have a static
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215845#comment-16215845
]
David Smiley commented on SOLR-11487:
-
Thanks for the patch Gus!
* I think just String values is fine;
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211098#comment-16211098
]
David Smiley commented on SOLR-11487:
-
The latter -- alias metadata.
> Collection Alias metadata for
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211026#comment-16211026
]
Gus Heck commented on SOLR-11487:
-
Is this ticket meant to add a general collection metadata facility
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206772#comment-16206772
]
Noble Paul commented on SOLR-11487:
---
I prefer the approach of adding a collection_metadata key in the
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206546#comment-16206546
]
David Smiley commented on SOLR-11487:
-
Thanks for sharing your idea [~gus_heck]. This is an approach
[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205218#comment-16205218
]
Gus Heck commented on SOLR-11487:
-
In zk nodes can have both values and children right? So the value of
29 matches
Mail list logo
