[jira] [Commented] (SOLR-11585) Solr SQL does not work with point numeric fields

2018-08-10 Thread Joel Bernstein (JIRA)


[ 
https://issues.apache.org/jira/browse/SOLR-11585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576088#comment-16576088
 ] 

Joel Bernstein commented on SOLR-11585:
---

Thanks [~kiranch]!

> Solr SQL does not work with point numeric fields
> 
>
> Key: SOLR-11585
> URL: https://issues.apache.org/jira/browse/SOLR-11585
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Parallel SQL
>Affects Versions: 7.1
>Reporter: kiran
>Assignee: Joel Bernstein
>Priority: Major
> Attachments: SOLR-11585.patch, SOLR-11585.patch
>
>
> Solr SQL does not work with point field types. there is no support for 
> 'pint', 'plong', 'pdouble', 'pfloat'  in 
> https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.1.0/solr/core/src/java/org/apache/solr/handler/sql/SolrSchema.java#L99
> Sample query:
> {code}
> http://localhost:8983/solr/ratings1/sql?indent=off=json=2.2=facet=+SELECT+movie_id,+COUNT(*)+as+agg_count,+avg(rating)+as+avg_rating,+sum(rating)+as+sum_rating,+min(rating)+as+min_rating,+max(rating)+as+max_rating+FROM+ratings1+GROUP+BY+movie_id+ORDER+BY+movie_id+asc
> Error:
> Error while executing SQL " SELECT movie_id, COUNT(*) as agg_count, 
> avg(rating) as avg_rating, sum(rating) as sum_rating, min(rating) as 
> min_rating, max(rating) as max_rating FROM 
> ratingsffd34e87_2c95_4c82_acff_d31c40983b73 GROUP BY movie_id ORDER BY 
> movie_id asc ": From line 1, column 42 to line 1, column 52: Cannot apply 
> 'AVG' to arguments of type 'AVG()'. 
> Supported form(s): 'AVG()'
>   at 
> org.apache.solr.client.solrj.io.stream.JDBCStream.open(JDBCStream.java:270)
>   at 
> org.apache.solr.client.solrj.io.stream.ExceptionStream.open(ExceptionStream.java:51)
>   at 
> org.apache.solr.handler.StreamHandler$TimerStream.open(StreamHandler.java:605)
>   at 
> org.apache.solr.client.solrj.io.stream.TupleStream.writeMap(TupleStream.java:83)
>   at 
> org.apache.solr.response.JSONWriter.writeMap(JSONResponseWriter.java:547)
>   at 
> org.apache.solr.response.TextResponseWriter.writeVal(TextResponseWriter.java:198)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedListAsMapWithDups(JSONResponseWriter.java:209)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedList(JSONResponseWriter.java:325)
>   at 
> org.apache.solr.response.JSONWriter.writeResponse(JSONResponseWriter.java:120)
>   at 
> org.apache.solr.response.JSONResponseWriter.write(JSONResponseWriter.java:71)
>   at 
> org.apache.solr.response.QueryResponseWriterUtil.writeQueryResponse(QueryResponseWriterUtil.java:65)
>   at 
> org.apache.solr.servlet.HttpSolrCall.writeResponse(HttpSolrCall.java:806)
>   at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:535)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:382)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:326)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1759)
>   at 
> org.apache.solr.client.solrj.embedded.JettySolrRunner$DebugFilter.doFilter(JettySolrRunner.java:139)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1759)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:582)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:224)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:512)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
>   at 
> org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:426)
>   at 
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
>   at org.eclipse.jetty.server.Server.handle(Server.java:534)
>   at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320)
>   at 
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
>   at 
> org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:283)
>   at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:108)
>   at 
> org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93)
>   at 
> 

[jira] [Commented] (SOLR-11585) Solr SQL does not work with point numeric fields

2018-08-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/SOLR-11585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576001#comment-16576001
 ] 

ASF subversion and git services commented on SOLR-11585:


Commit 71310a4722f3e95a0e10a4ca4297d090ace3efd4 in lucene-solr's branch 
refs/heads/jira/http2 from [~joel.bernstein]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=71310a4 ]

SOLR-11585: Solr SQL does not work with point numeric fields


> Solr SQL does not work with point numeric fields
> 
>
> Key: SOLR-11585
> URL: https://issues.apache.org/jira/browse/SOLR-11585
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Parallel SQL
>Affects Versions: 7.1
>Reporter: kiran
>Assignee: Joel Bernstein
>Priority: Major
> Attachments: SOLR-11585.patch, SOLR-11585.patch
>
>
> Solr SQL does not work with point field types. there is no support for 
> 'pint', 'plong', 'pdouble', 'pfloat'  in 
> https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.1.0/solr/core/src/java/org/apache/solr/handler/sql/SolrSchema.java#L99
> Sample query:
> {code}
> http://localhost:8983/solr/ratings1/sql?indent=off=json=2.2=facet=+SELECT+movie_id,+COUNT(*)+as+agg_count,+avg(rating)+as+avg_rating,+sum(rating)+as+sum_rating,+min(rating)+as+min_rating,+max(rating)+as+max_rating+FROM+ratings1+GROUP+BY+movie_id+ORDER+BY+movie_id+asc
> Error:
> Error while executing SQL " SELECT movie_id, COUNT(*) as agg_count, 
> avg(rating) as avg_rating, sum(rating) as sum_rating, min(rating) as 
> min_rating, max(rating) as max_rating FROM 
> ratingsffd34e87_2c95_4c82_acff_d31c40983b73 GROUP BY movie_id ORDER BY 
> movie_id asc ": From line 1, column 42 to line 1, column 52: Cannot apply 
> 'AVG' to arguments of type 'AVG()'. 
> Supported form(s): 'AVG()'
>   at 
> org.apache.solr.client.solrj.io.stream.JDBCStream.open(JDBCStream.java:270)
>   at 
> org.apache.solr.client.solrj.io.stream.ExceptionStream.open(ExceptionStream.java:51)
>   at 
> org.apache.solr.handler.StreamHandler$TimerStream.open(StreamHandler.java:605)
>   at 
> org.apache.solr.client.solrj.io.stream.TupleStream.writeMap(TupleStream.java:83)
>   at 
> org.apache.solr.response.JSONWriter.writeMap(JSONResponseWriter.java:547)
>   at 
> org.apache.solr.response.TextResponseWriter.writeVal(TextResponseWriter.java:198)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedListAsMapWithDups(JSONResponseWriter.java:209)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedList(JSONResponseWriter.java:325)
>   at 
> org.apache.solr.response.JSONWriter.writeResponse(JSONResponseWriter.java:120)
>   at 
> org.apache.solr.response.JSONResponseWriter.write(JSONResponseWriter.java:71)
>   at 
> org.apache.solr.response.QueryResponseWriterUtil.writeQueryResponse(QueryResponseWriterUtil.java:65)
>   at 
> org.apache.solr.servlet.HttpSolrCall.writeResponse(HttpSolrCall.java:806)
>   at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:535)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:382)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:326)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1759)
>   at 
> org.apache.solr.client.solrj.embedded.JettySolrRunner$DebugFilter.doFilter(JettySolrRunner.java:139)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1759)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:582)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:224)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:512)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
>   at 
> org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:426)
>   at 
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
>   at org.eclipse.jetty.server.Server.handle(Server.java:534)
>   at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320)
>   at 
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
>   at 
> org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:283)
>   at 

[jira] [Commented] (SOLR-11585) Solr SQL does not work with point numeric fields

2018-08-09 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/SOLR-11585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575596#comment-16575596
 ] 

ASF subversion and git services commented on SOLR-11585:


Commit c5ea325e096a344b58cbf1df2ef167d4953c97b1 in lucene-solr's branch 
refs/heads/branch_7x from [~joel.bernstein]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c5ea325 ]

SOLR-11585: Solr SQL does not work with point numeric fields


> Solr SQL does not work with point numeric fields
> 
>
> Key: SOLR-11585
> URL: https://issues.apache.org/jira/browse/SOLR-11585
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Parallel SQL
>Affects Versions: 7.1
>Reporter: kiran
>Assignee: Joel Bernstein
>Priority: Major
> Attachments: SOLR-11585.patch, SOLR-11585.patch
>
>
> Solr SQL does not work with point field types. there is no support for 
> 'pint', 'plong', 'pdouble', 'pfloat'  in 
> https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.1.0/solr/core/src/java/org/apache/solr/handler/sql/SolrSchema.java#L99
> Sample query:
> {code}
> http://localhost:8983/solr/ratings1/sql?indent=off=json=2.2=facet=+SELECT+movie_id,+COUNT(*)+as+agg_count,+avg(rating)+as+avg_rating,+sum(rating)+as+sum_rating,+min(rating)+as+min_rating,+max(rating)+as+max_rating+FROM+ratings1+GROUP+BY+movie_id+ORDER+BY+movie_id+asc
> Error:
> Error while executing SQL " SELECT movie_id, COUNT(*) as agg_count, 
> avg(rating) as avg_rating, sum(rating) as sum_rating, min(rating) as 
> min_rating, max(rating) as max_rating FROM 
> ratingsffd34e87_2c95_4c82_acff_d31c40983b73 GROUP BY movie_id ORDER BY 
> movie_id asc ": From line 1, column 42 to line 1, column 52: Cannot apply 
> 'AVG' to arguments of type 'AVG()'. 
> Supported form(s): 'AVG()'
>   at 
> org.apache.solr.client.solrj.io.stream.JDBCStream.open(JDBCStream.java:270)
>   at 
> org.apache.solr.client.solrj.io.stream.ExceptionStream.open(ExceptionStream.java:51)
>   at 
> org.apache.solr.handler.StreamHandler$TimerStream.open(StreamHandler.java:605)
>   at 
> org.apache.solr.client.solrj.io.stream.TupleStream.writeMap(TupleStream.java:83)
>   at 
> org.apache.solr.response.JSONWriter.writeMap(JSONResponseWriter.java:547)
>   at 
> org.apache.solr.response.TextResponseWriter.writeVal(TextResponseWriter.java:198)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedListAsMapWithDups(JSONResponseWriter.java:209)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedList(JSONResponseWriter.java:325)
>   at 
> org.apache.solr.response.JSONWriter.writeResponse(JSONResponseWriter.java:120)
>   at 
> org.apache.solr.response.JSONResponseWriter.write(JSONResponseWriter.java:71)
>   at 
> org.apache.solr.response.QueryResponseWriterUtil.writeQueryResponse(QueryResponseWriterUtil.java:65)
>   at 
> org.apache.solr.servlet.HttpSolrCall.writeResponse(HttpSolrCall.java:806)
>   at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:535)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:382)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:326)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1759)
>   at 
> org.apache.solr.client.solrj.embedded.JettySolrRunner$DebugFilter.doFilter(JettySolrRunner.java:139)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1759)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:582)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:224)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:512)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
>   at 
> org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:426)
>   at 
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
>   at org.eclipse.jetty.server.Server.handle(Server.java:534)
>   at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320)
>   at 
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
>   at 
> org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:283)
>   at 

[jira] [Commented] (SOLR-11585) Solr SQL does not work with point numeric fields

2018-08-09 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/SOLR-11585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575593#comment-16575593
 ] 

ASF subversion and git services commented on SOLR-11585:


Commit 71310a4722f3e95a0e10a4ca4297d090ace3efd4 in lucene-solr's branch 
refs/heads/master from [~joel.bernstein]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=71310a4 ]

SOLR-11585: Solr SQL does not work with point numeric fields


> Solr SQL does not work with point numeric fields
> 
>
> Key: SOLR-11585
> URL: https://issues.apache.org/jira/browse/SOLR-11585
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Parallel SQL
>Affects Versions: 7.1
>Reporter: kiran
>Assignee: Joel Bernstein
>Priority: Major
> Attachments: SOLR-11585.patch, SOLR-11585.patch
>
>
> Solr SQL does not work with point field types. there is no support for 
> 'pint', 'plong', 'pdouble', 'pfloat'  in 
> https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.1.0/solr/core/src/java/org/apache/solr/handler/sql/SolrSchema.java#L99
> Sample query:
> {code}
> http://localhost:8983/solr/ratings1/sql?indent=off=json=2.2=facet=+SELECT+movie_id,+COUNT(*)+as+agg_count,+avg(rating)+as+avg_rating,+sum(rating)+as+sum_rating,+min(rating)+as+min_rating,+max(rating)+as+max_rating+FROM+ratings1+GROUP+BY+movie_id+ORDER+BY+movie_id+asc
> Error:
> Error while executing SQL " SELECT movie_id, COUNT(*) as agg_count, 
> avg(rating) as avg_rating, sum(rating) as sum_rating, min(rating) as 
> min_rating, max(rating) as max_rating FROM 
> ratingsffd34e87_2c95_4c82_acff_d31c40983b73 GROUP BY movie_id ORDER BY 
> movie_id asc ": From line 1, column 42 to line 1, column 52: Cannot apply 
> 'AVG' to arguments of type 'AVG()'. 
> Supported form(s): 'AVG()'
>   at 
> org.apache.solr.client.solrj.io.stream.JDBCStream.open(JDBCStream.java:270)
>   at 
> org.apache.solr.client.solrj.io.stream.ExceptionStream.open(ExceptionStream.java:51)
>   at 
> org.apache.solr.handler.StreamHandler$TimerStream.open(StreamHandler.java:605)
>   at 
> org.apache.solr.client.solrj.io.stream.TupleStream.writeMap(TupleStream.java:83)
>   at 
> org.apache.solr.response.JSONWriter.writeMap(JSONResponseWriter.java:547)
>   at 
> org.apache.solr.response.TextResponseWriter.writeVal(TextResponseWriter.java:198)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedListAsMapWithDups(JSONResponseWriter.java:209)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedList(JSONResponseWriter.java:325)
>   at 
> org.apache.solr.response.JSONWriter.writeResponse(JSONResponseWriter.java:120)
>   at 
> org.apache.solr.response.JSONResponseWriter.write(JSONResponseWriter.java:71)
>   at 
> org.apache.solr.response.QueryResponseWriterUtil.writeQueryResponse(QueryResponseWriterUtil.java:65)
>   at 
> org.apache.solr.servlet.HttpSolrCall.writeResponse(HttpSolrCall.java:806)
>   at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:535)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:382)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:326)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1759)
>   at 
> org.apache.solr.client.solrj.embedded.JettySolrRunner$DebugFilter.doFilter(JettySolrRunner.java:139)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1759)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:582)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:224)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:512)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
>   at 
> org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:426)
>   at 
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
>   at org.eclipse.jetty.server.Server.handle(Server.java:534)
>   at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320)
>   at 
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
>   at 
> org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:283)
>   at 

[jira] [Commented] (SOLR-11585) Solr SQL does not work with point numeric fields

2018-08-09 Thread Joel Bernstein (JIRA)


[ 
https://issues.apache.org/jira/browse/SOLR-11585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575293#comment-16575293
 ] 

Joel Bernstein commented on SOLR-11585:
---

Latest patch is looking fairly good. The tests still need more work in general 
but they do exercise the points in different ways. I'll do some manual testing 
as well and then likely commit.

I'll create another ticket to improve the tests in general to ensure the more 
cases are covered, in particular that both map_reduce and facet 
aggregationModes have enough coverage.

> Solr SQL does not work with point numeric fields
> 
>
> Key: SOLR-11585
> URL: https://issues.apache.org/jira/browse/SOLR-11585
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Parallel SQL
>Affects Versions: 7.1
>Reporter: kiran
>Assignee: Joel Bernstein
>Priority: Major
> Attachments: SOLR-11585.patch, SOLR-11585.patch
>
>
> Solr SQL does not work with point field types. there is no support for 
> 'pint', 'plong', 'pdouble', 'pfloat'  in 
> https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.1.0/solr/core/src/java/org/apache/solr/handler/sql/SolrSchema.java#L99
> Sample query:
> {code}
> http://localhost:8983/solr/ratings1/sql?indent=off=json=2.2=facet=+SELECT+movie_id,+COUNT(*)+as+agg_count,+avg(rating)+as+avg_rating,+sum(rating)+as+sum_rating,+min(rating)+as+min_rating,+max(rating)+as+max_rating+FROM+ratings1+GROUP+BY+movie_id+ORDER+BY+movie_id+asc
> Error:
> Error while executing SQL " SELECT movie_id, COUNT(*) as agg_count, 
> avg(rating) as avg_rating, sum(rating) as sum_rating, min(rating) as 
> min_rating, max(rating) as max_rating FROM 
> ratingsffd34e87_2c95_4c82_acff_d31c40983b73 GROUP BY movie_id ORDER BY 
> movie_id asc ": From line 1, column 42 to line 1, column 52: Cannot apply 
> 'AVG' to arguments of type 'AVG()'. 
> Supported form(s): 'AVG()'
>   at 
> org.apache.solr.client.solrj.io.stream.JDBCStream.open(JDBCStream.java:270)
>   at 
> org.apache.solr.client.solrj.io.stream.ExceptionStream.open(ExceptionStream.java:51)
>   at 
> org.apache.solr.handler.StreamHandler$TimerStream.open(StreamHandler.java:605)
>   at 
> org.apache.solr.client.solrj.io.stream.TupleStream.writeMap(TupleStream.java:83)
>   at 
> org.apache.solr.response.JSONWriter.writeMap(JSONResponseWriter.java:547)
>   at 
> org.apache.solr.response.TextResponseWriter.writeVal(TextResponseWriter.java:198)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedListAsMapWithDups(JSONResponseWriter.java:209)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedList(JSONResponseWriter.java:325)
>   at 
> org.apache.solr.response.JSONWriter.writeResponse(JSONResponseWriter.java:120)
>   at 
> org.apache.solr.response.JSONResponseWriter.write(JSONResponseWriter.java:71)
>   at 
> org.apache.solr.response.QueryResponseWriterUtil.writeQueryResponse(QueryResponseWriterUtil.java:65)
>   at 
> org.apache.solr.servlet.HttpSolrCall.writeResponse(HttpSolrCall.java:806)
>   at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:535)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:382)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:326)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1759)
>   at 
> org.apache.solr.client.solrj.embedded.JettySolrRunner$DebugFilter.doFilter(JettySolrRunner.java:139)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1759)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:582)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:224)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:512)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
>   at 
> org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:426)
>   at 
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
>   at org.eclipse.jetty.server.Server.handle(Server.java:534)
>   at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320)
>   at 
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
>   at 
> 

[jira] [Commented] (SOLR-11585) Solr SQL does not work with point numeric fields

2018-08-09 Thread Joel Bernstein (JIRA)


[ 
https://issues.apache.org/jira/browse/SOLR-11585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575118#comment-16575118
 ] 

Joel Bernstein commented on SOLR-11585:
---

We can try that. Let's do this in two tickets, In this ticket let's get this 
done:

1) Fix the bug

2) Add better tests that explicitly use points

I'll get this committed and pushed out today.

Then I'll open another ticket which looks at using the standard schema.xml. 
There may be more then one problem that needs to be fixed with this.

 

> Solr SQL does not work with point numeric fields
> 
>
> Key: SOLR-11585
> URL: https://issues.apache.org/jira/browse/SOLR-11585
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Parallel SQL
>Affects Versions: 7.1
>Reporter: kiran
>Assignee: Joel Bernstein
>Priority: Major
> Attachments: SOLR-11585.patch
>
>
> Solr SQL does not work with point field types. there is no support for 
> 'pint', 'plong', 'pdouble', 'pfloat'  in 
> https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.1.0/solr/core/src/java/org/apache/solr/handler/sql/SolrSchema.java#L99
> Sample query:
> {code}
> http://localhost:8983/solr/ratings1/sql?indent=off=json=2.2=facet=+SELECT+movie_id,+COUNT(*)+as+agg_count,+avg(rating)+as+avg_rating,+sum(rating)+as+sum_rating,+min(rating)+as+min_rating,+max(rating)+as+max_rating+FROM+ratings1+GROUP+BY+movie_id+ORDER+BY+movie_id+asc
> Error:
> Error while executing SQL " SELECT movie_id, COUNT(*) as agg_count, 
> avg(rating) as avg_rating, sum(rating) as sum_rating, min(rating) as 
> min_rating, max(rating) as max_rating FROM 
> ratingsffd34e87_2c95_4c82_acff_d31c40983b73 GROUP BY movie_id ORDER BY 
> movie_id asc ": From line 1, column 42 to line 1, column 52: Cannot apply 
> 'AVG' to arguments of type 'AVG()'. 
> Supported form(s): 'AVG()'
>   at 
> org.apache.solr.client.solrj.io.stream.JDBCStream.open(JDBCStream.java:270)
>   at 
> org.apache.solr.client.solrj.io.stream.ExceptionStream.open(ExceptionStream.java:51)
>   at 
> org.apache.solr.handler.StreamHandler$TimerStream.open(StreamHandler.java:605)
>   at 
> org.apache.solr.client.solrj.io.stream.TupleStream.writeMap(TupleStream.java:83)
>   at 
> org.apache.solr.response.JSONWriter.writeMap(JSONResponseWriter.java:547)
>   at 
> org.apache.solr.response.TextResponseWriter.writeVal(TextResponseWriter.java:198)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedListAsMapWithDups(JSONResponseWriter.java:209)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedList(JSONResponseWriter.java:325)
>   at 
> org.apache.solr.response.JSONWriter.writeResponse(JSONResponseWriter.java:120)
>   at 
> org.apache.solr.response.JSONResponseWriter.write(JSONResponseWriter.java:71)
>   at 
> org.apache.solr.response.QueryResponseWriterUtil.writeQueryResponse(QueryResponseWriterUtil.java:65)
>   at 
> org.apache.solr.servlet.HttpSolrCall.writeResponse(HttpSolrCall.java:806)
>   at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:535)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:382)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:326)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1759)
>   at 
> org.apache.solr.client.solrj.embedded.JettySolrRunner$DebugFilter.doFilter(JettySolrRunner.java:139)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1759)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:582)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:224)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:512)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
>   at 
> org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:426)
>   at 
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
>   at org.eclipse.jetty.server.Server.handle(Server.java:534)
>   at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320)
>   at 
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
>   at 
> 

[jira] [Commented] (SOLR-11585) Solr SQL does not work with point numeric fields

2018-08-09 Thread Varun Thacker (JIRA)


[ 
https://issues.apache.org/jira/browse/SOLR-11585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575096#comment-16575096
 ] 

Varun Thacker commented on SOLR-11585:
--

{quote}I think it will be very difficult to switch the test case to use 
schema.xml because DocValues are required for many of the SQL queries being 
tested. 
{quote}
We could perhaps use this to always ensure fields have doc-values 
{code:java}
System.setProperty(NUMERIC_DOCVALUES_SYSPROP,"true");{code}
The motivation for me is we have lots of test-specific schemas and the more we 
can reuse the better. New devs then just end up copy-pasting an existing test 
case but don't get the context to why a particular schema was used

> Solr SQL does not work with point numeric fields
> 
>
> Key: SOLR-11585
> URL: https://issues.apache.org/jira/browse/SOLR-11585
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Parallel SQL
>Affects Versions: 7.1
>Reporter: kiran
>Assignee: Joel Bernstein
>Priority: Major
> Attachments: SOLR-11585.patch
>
>
> Solr SQL does not work with point field types. there is no support for 
> 'pint', 'plong', 'pdouble', 'pfloat'  in 
> https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.1.0/solr/core/src/java/org/apache/solr/handler/sql/SolrSchema.java#L99
> Sample query:
> {code}
> http://localhost:8983/solr/ratings1/sql?indent=off=json=2.2=facet=+SELECT+movie_id,+COUNT(*)+as+agg_count,+avg(rating)+as+avg_rating,+sum(rating)+as+sum_rating,+min(rating)+as+min_rating,+max(rating)+as+max_rating+FROM+ratings1+GROUP+BY+movie_id+ORDER+BY+movie_id+asc
> Error:
> Error while executing SQL " SELECT movie_id, COUNT(*) as agg_count, 
> avg(rating) as avg_rating, sum(rating) as sum_rating, min(rating) as 
> min_rating, max(rating) as max_rating FROM 
> ratingsffd34e87_2c95_4c82_acff_d31c40983b73 GROUP BY movie_id ORDER BY 
> movie_id asc ": From line 1, column 42 to line 1, column 52: Cannot apply 
> 'AVG' to arguments of type 'AVG()'. 
> Supported form(s): 'AVG()'
>   at 
> org.apache.solr.client.solrj.io.stream.JDBCStream.open(JDBCStream.java:270)
>   at 
> org.apache.solr.client.solrj.io.stream.ExceptionStream.open(ExceptionStream.java:51)
>   at 
> org.apache.solr.handler.StreamHandler$TimerStream.open(StreamHandler.java:605)
>   at 
> org.apache.solr.client.solrj.io.stream.TupleStream.writeMap(TupleStream.java:83)
>   at 
> org.apache.solr.response.JSONWriter.writeMap(JSONResponseWriter.java:547)
>   at 
> org.apache.solr.response.TextResponseWriter.writeVal(TextResponseWriter.java:198)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedListAsMapWithDups(JSONResponseWriter.java:209)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedList(JSONResponseWriter.java:325)
>   at 
> org.apache.solr.response.JSONWriter.writeResponse(JSONResponseWriter.java:120)
>   at 
> org.apache.solr.response.JSONResponseWriter.write(JSONResponseWriter.java:71)
>   at 
> org.apache.solr.response.QueryResponseWriterUtil.writeQueryResponse(QueryResponseWriterUtil.java:65)
>   at 
> org.apache.solr.servlet.HttpSolrCall.writeResponse(HttpSolrCall.java:806)
>   at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:535)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:382)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:326)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1759)
>   at 
> org.apache.solr.client.solrj.embedded.JettySolrRunner$DebugFilter.doFilter(JettySolrRunner.java:139)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1759)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:582)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:224)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:512)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
>   at 
> org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:426)
>   at 
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
>   at org.eclipse.jetty.server.Server.handle(Server.java:534)
>   at 

[jira] [Commented] (SOLR-11585) Solr SQL does not work with point numeric fields

2018-08-09 Thread Joel Bernstein (JIRA)


[ 
https://issues.apache.org/jira/browse/SOLR-11585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575045#comment-16575045
 ] 

Joel Bernstein commented on SOLR-11585:
---

I think it will be very difficult to switch the test case to use schema.xml 
because DocValues are required for many of the SQL queries being tested. In 
schema.xml DocValues are randomized in places which will break the test.

So I will focus on getting all the field types that need to be tested in 
schema-sql.xml. Then I'll expand the tests to excercise all the field types. 

I'll also remove the badapple designation from the TestSQLHandler and fix any 
issues I see in jenkins.

> Solr SQL does not work with point numeric fields
> 
>
> Key: SOLR-11585
> URL: https://issues.apache.org/jira/browse/SOLR-11585
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Parallel SQL
>Affects Versions: 7.1
>Reporter: kiran
>Assignee: Joel Bernstein
>Priority: Major
> Attachments: SOLR-11585.patch
>
>
> Solr SQL does not work with point field types. there is no support for 
> 'pint', 'plong', 'pdouble', 'pfloat'  in 
> https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.1.0/solr/core/src/java/org/apache/solr/handler/sql/SolrSchema.java#L99
> Sample query:
> {code}
> http://localhost:8983/solr/ratings1/sql?indent=off=json=2.2=facet=+SELECT+movie_id,+COUNT(*)+as+agg_count,+avg(rating)+as+avg_rating,+sum(rating)+as+sum_rating,+min(rating)+as+min_rating,+max(rating)+as+max_rating+FROM+ratings1+GROUP+BY+movie_id+ORDER+BY+movie_id+asc
> Error:
> Error while executing SQL " SELECT movie_id, COUNT(*) as agg_count, 
> avg(rating) as avg_rating, sum(rating) as sum_rating, min(rating) as 
> min_rating, max(rating) as max_rating FROM 
> ratingsffd34e87_2c95_4c82_acff_d31c40983b73 GROUP BY movie_id ORDER BY 
> movie_id asc ": From line 1, column 42 to line 1, column 52: Cannot apply 
> 'AVG' to arguments of type 'AVG()'. 
> Supported form(s): 'AVG()'
>   at 
> org.apache.solr.client.solrj.io.stream.JDBCStream.open(JDBCStream.java:270)
>   at 
> org.apache.solr.client.solrj.io.stream.ExceptionStream.open(ExceptionStream.java:51)
>   at 
> org.apache.solr.handler.StreamHandler$TimerStream.open(StreamHandler.java:605)
>   at 
> org.apache.solr.client.solrj.io.stream.TupleStream.writeMap(TupleStream.java:83)
>   at 
> org.apache.solr.response.JSONWriter.writeMap(JSONResponseWriter.java:547)
>   at 
> org.apache.solr.response.TextResponseWriter.writeVal(TextResponseWriter.java:198)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedListAsMapWithDups(JSONResponseWriter.java:209)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedList(JSONResponseWriter.java:325)
>   at 
> org.apache.solr.response.JSONWriter.writeResponse(JSONResponseWriter.java:120)
>   at 
> org.apache.solr.response.JSONResponseWriter.write(JSONResponseWriter.java:71)
>   at 
> org.apache.solr.response.QueryResponseWriterUtil.writeQueryResponse(QueryResponseWriterUtil.java:65)
>   at 
> org.apache.solr.servlet.HttpSolrCall.writeResponse(HttpSolrCall.java:806)
>   at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:535)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:382)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:326)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1759)
>   at 
> org.apache.solr.client.solrj.embedded.JettySolrRunner$DebugFilter.doFilter(JettySolrRunner.java:139)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1759)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:582)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:224)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:512)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
>   at 
> org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:426)
>   at 
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
>   at org.eclipse.jetty.server.Server.handle(Server.java:534)
>   at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320)
>   at 
> 

[jira] [Commented] (SOLR-11585) Solr SQL does not work with point numeric fields

2018-08-09 Thread Joel Bernstein (JIRA)


[ 
https://issues.apache.org/jira/browse/SOLR-11585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574975#comment-16574975
 ] 

Joel Bernstein commented on SOLR-11585:
---

I'll apply the patch and then work on the tests so that all the numeric field 
types are exercised.

> Solr SQL does not work with point numeric fields
> 
>
> Key: SOLR-11585
> URL: https://issues.apache.org/jira/browse/SOLR-11585
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Parallel SQL
>Affects Versions: 7.1
>Reporter: kiran
>Assignee: Joel Bernstein
>Priority: Major
> Attachments: SOLR-11585.patch
>
>
> Solr SQL does not work with point field types. there is no support for 
> 'pint', 'plong', 'pdouble', 'pfloat'  in 
> https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.1.0/solr/core/src/java/org/apache/solr/handler/sql/SolrSchema.java#L99
> Sample query:
> {code}
> http://localhost:8983/solr/ratings1/sql?indent=off=json=2.2=facet=+SELECT+movie_id,+COUNT(*)+as+agg_count,+avg(rating)+as+avg_rating,+sum(rating)+as+sum_rating,+min(rating)+as+min_rating,+max(rating)+as+max_rating+FROM+ratings1+GROUP+BY+movie_id+ORDER+BY+movie_id+asc
> Error:
> Error while executing SQL " SELECT movie_id, COUNT(*) as agg_count, 
> avg(rating) as avg_rating, sum(rating) as sum_rating, min(rating) as 
> min_rating, max(rating) as max_rating FROM 
> ratingsffd34e87_2c95_4c82_acff_d31c40983b73 GROUP BY movie_id ORDER BY 
> movie_id asc ": From line 1, column 42 to line 1, column 52: Cannot apply 
> 'AVG' to arguments of type 'AVG()'. 
> Supported form(s): 'AVG()'
>   at 
> org.apache.solr.client.solrj.io.stream.JDBCStream.open(JDBCStream.java:270)
>   at 
> org.apache.solr.client.solrj.io.stream.ExceptionStream.open(ExceptionStream.java:51)
>   at 
> org.apache.solr.handler.StreamHandler$TimerStream.open(StreamHandler.java:605)
>   at 
> org.apache.solr.client.solrj.io.stream.TupleStream.writeMap(TupleStream.java:83)
>   at 
> org.apache.solr.response.JSONWriter.writeMap(JSONResponseWriter.java:547)
>   at 
> org.apache.solr.response.TextResponseWriter.writeVal(TextResponseWriter.java:198)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedListAsMapWithDups(JSONResponseWriter.java:209)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedList(JSONResponseWriter.java:325)
>   at 
> org.apache.solr.response.JSONWriter.writeResponse(JSONResponseWriter.java:120)
>   at 
> org.apache.solr.response.JSONResponseWriter.write(JSONResponseWriter.java:71)
>   at 
> org.apache.solr.response.QueryResponseWriterUtil.writeQueryResponse(QueryResponseWriterUtil.java:65)
>   at 
> org.apache.solr.servlet.HttpSolrCall.writeResponse(HttpSolrCall.java:806)
>   at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:535)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:382)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:326)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1759)
>   at 
> org.apache.solr.client.solrj.embedded.JettySolrRunner$DebugFilter.doFilter(JettySolrRunner.java:139)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1759)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:582)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:224)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:512)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
>   at 
> org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:426)
>   at 
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
>   at org.eclipse.jetty.server.Server.handle(Server.java:534)
>   at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320)
>   at 
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
>   at 
> org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:283)
>   at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:108)
>   at 
> org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93)
>   at 
> 

[jira] [Commented] (SOLR-11585) Solr SQL does not work with point numeric fields

2017-10-31 Thread Varun Thacker (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227368#comment-16227368
 ] 

Varun Thacker commented on SOLR-11585:
--

The  tests didn't catch this because TestSQLHandler is using field names like 
{{field_i}} which is hardcoded to use trie fields. If it used {[field_ti}} then 
the test framework would have randomized b/w trie and point fields. 

We should just use {[schema.xml}} instead of {{"schema-sql.xml"}} . A quick 
glance shows that the test uses three dynamic fields - _t  , _s and _i which is 
present in schema.xml . _i is also randomized b/w trie and point fields. 

> Solr SQL does not work with point numeric fields
> 
>
> Key: SOLR-11585
> URL: https://issues.apache.org/jira/browse/SOLR-11585
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Parallel SQL
>Affects Versions: 7.1.0
>Reporter: kiran
> Attachments: SOLR-11585.patch
>
>
> Solr SQL does not work with point field types. there is no support for 
> 'pint', 'plong', 'pdouble', 'pfloat'  in 
> https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.1.0/solr/core/src/java/org/apache/solr/handler/sql/SolrSchema.java#L99
> Sample query:
> {code}
> http://localhost:8983/solr/ratings1/sql?indent=off=json=2.2=facet=+SELECT+movie_id,+COUNT(*)+as+agg_count,+avg(rating)+as+avg_rating,+sum(rating)+as+sum_rating,+min(rating)+as+min_rating,+max(rating)+as+max_rating+FROM+ratings1+GROUP+BY+movie_id+ORDER+BY+movie_id+asc
> Error:
> Error while executing SQL " SELECT movie_id, COUNT(*) as agg_count, 
> avg(rating) as avg_rating, sum(rating) as sum_rating, min(rating) as 
> min_rating, max(rating) as max_rating FROM 
> ratingsffd34e87_2c95_4c82_acff_d31c40983b73 GROUP BY movie_id ORDER BY 
> movie_id asc ": From line 1, column 42 to line 1, column 52: Cannot apply 
> 'AVG' to arguments of type 'AVG()'. 
> Supported form(s): 'AVG()'
>   at 
> org.apache.solr.client.solrj.io.stream.JDBCStream.open(JDBCStream.java:270)
>   at 
> org.apache.solr.client.solrj.io.stream.ExceptionStream.open(ExceptionStream.java:51)
>   at 
> org.apache.solr.handler.StreamHandler$TimerStream.open(StreamHandler.java:605)
>   at 
> org.apache.solr.client.solrj.io.stream.TupleStream.writeMap(TupleStream.java:83)
>   at 
> org.apache.solr.response.JSONWriter.writeMap(JSONResponseWriter.java:547)
>   at 
> org.apache.solr.response.TextResponseWriter.writeVal(TextResponseWriter.java:198)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedListAsMapWithDups(JSONResponseWriter.java:209)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedList(JSONResponseWriter.java:325)
>   at 
> org.apache.solr.response.JSONWriter.writeResponse(JSONResponseWriter.java:120)
>   at 
> org.apache.solr.response.JSONResponseWriter.write(JSONResponseWriter.java:71)
>   at 
> org.apache.solr.response.QueryResponseWriterUtil.writeQueryResponse(QueryResponseWriterUtil.java:65)
>   at 
> org.apache.solr.servlet.HttpSolrCall.writeResponse(HttpSolrCall.java:806)
>   at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:535)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:382)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:326)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1759)
>   at 
> org.apache.solr.client.solrj.embedded.JettySolrRunner$DebugFilter.doFilter(JettySolrRunner.java:139)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1759)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:582)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:224)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:512)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
>   at 
> org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:426)
>   at 
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
>   at org.eclipse.jetty.server.Server.handle(Server.java:534)
>   at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320)
>   at 
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
>   

[jira] [Commented] (SOLR-11585) Solr SQL does not work with point numeric fields

2017-10-31 Thread kiran (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-11585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227358#comment-16227358
 ] 

kiran commented on SOLR-11585:
--

Did some local testing with the attached patch and it seems to fix the issue

> Solr SQL does not work with point numeric fields
> 
>
> Key: SOLR-11585
> URL: https://issues.apache.org/jira/browse/SOLR-11585
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Parallel SQL
>Affects Versions: 7.1.0
>Reporter: kiran
> Attachments: SOLR-11585.patch
>
>
> Solr SQL does not work with point field types. there is no support for 
> `pint`, `plong`, `pdouble`, `pfloat`  in 
> https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.1.0/solr/core/src/java/org/apache/solr/handler/sql/SolrSchema.java#L99
> Sample query:
> {code}
> http://localhost:8983/solr/ratings1/sql?indent=off=json=2.2=facet=+SELECT+movie_id,+COUNT(*)+as+agg_count,+avg(rating)+as+avg_rating,+sum(rating)+as+sum_rating,+min(rating)+as+min_rating,+max(rating)+as+max_rating+FROM+ratings1+GROUP+BY+movie_id+ORDER+BY+movie_id+asc
> Error:
> Error while executing SQL " SELECT movie_id, COUNT(*) as agg_count, 
> avg(rating) as avg_rating, sum(rating) as sum_rating, min(rating) as 
> min_rating, max(rating) as max_rating FROM 
> ratingsffd34e87_2c95_4c82_acff_d31c40983b73 GROUP BY movie_id ORDER BY 
> movie_id asc ": From line 1, column 42 to line 1, column 52: Cannot apply 
> 'AVG' to arguments of type 'AVG()'. 
> Supported form(s): 'AVG()'
>   at 
> org.apache.solr.client.solrj.io.stream.JDBCStream.open(JDBCStream.java:270)
>   at 
> org.apache.solr.client.solrj.io.stream.ExceptionStream.open(ExceptionStream.java:51)
>   at 
> org.apache.solr.handler.StreamHandler$TimerStream.open(StreamHandler.java:605)
>   at 
> org.apache.solr.client.solrj.io.stream.TupleStream.writeMap(TupleStream.java:83)
>   at 
> org.apache.solr.response.JSONWriter.writeMap(JSONResponseWriter.java:547)
>   at 
> org.apache.solr.response.TextResponseWriter.writeVal(TextResponseWriter.java:198)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedListAsMapWithDups(JSONResponseWriter.java:209)
>   at 
> org.apache.solr.response.JSONWriter.writeNamedList(JSONResponseWriter.java:325)
>   at 
> org.apache.solr.response.JSONWriter.writeResponse(JSONResponseWriter.java:120)
>   at 
> org.apache.solr.response.JSONResponseWriter.write(JSONResponseWriter.java:71)
>   at 
> org.apache.solr.response.QueryResponseWriterUtil.writeQueryResponse(QueryResponseWriterUtil.java:65)
>   at 
> org.apache.solr.servlet.HttpSolrCall.writeResponse(HttpSolrCall.java:806)
>   at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:535)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:382)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:326)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1759)
>   at 
> org.apache.solr.client.solrj.embedded.JettySolrRunner$DebugFilter.doFilter(JettySolrRunner.java:139)
>   at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1759)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:582)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:224)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
>   at 
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:512)
>   at 
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
>   at 
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
>   at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
>   at 
> org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:426)
>   at 
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
>   at org.eclipse.jetty.server.Server.handle(Server.java:534)
>   at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320)
>   at 
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
>   at 
> org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:283)
>   at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:108)
>   at 
> org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93)
>   at 
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.executeProduceConsume(ExecuteProduceConsume.java:303)
>