[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518497#comment-16518497 ] David Smiley commented on SOLR-11865: - To clarify, the "PR" (GitHub) is what I cannot "close"...

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517247#comment-16517247 ] Bruno Roustant commented on SOLR-11865: --- Thanks for your incredible help [~dsmiley]! Closing this

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507042#comment-16507042 ] ASF subversion and git services commented on SOLR-11865: Commit

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507037#comment-16507037 ] ASF subversion and git services commented on SOLR-11865: Commit

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503459#comment-16503459 ] Markus Jelsma commented on SOLR-11865: -- I am not sure this will work for me right away, but maybe i

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503428#comment-16503428 ] David Smiley commented on SOLR-11865: - Updated patch with more visibility. I reverted some of

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503360#comment-16503360 ] David Smiley commented on SOLR-11865: - Okay Markus... though I hesitate to make *every* member

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503164#comment-16503164 ] Markus Jelsma commented on SOLR-11865: -- [~dsmiley] can you change those private members to protected

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502002#comment-16502002 ] David Smiley commented on SOLR-11865: - Here's our final patch. My CHANGES.txt will be as follows:

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496788#comment-16496788 ] Bruno Roustant commented on SOLR-11865: --- You're right MapElevationProvider.buildElevationMap should

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479764#comment-16479764 ] David Smiley commented on SOLR-11865: - BTW random comment; it seems inconsistent that

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479751#comment-16479751 ] David Smiley commented on SOLR-11865: - Bruno, can you please use a GitHub PR (referencing this issue

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476032#comment-16476032 ] Bruno Roustant commented on SOLR-11865: --- Great! I agree with all your points [~dsmiley]. Indeed the 

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464442#comment-16464442 ] David Smiley commented on SOLR-11865: - Patch still in progress but want to mention some things. * New

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456587#comment-16456587 ] David Smiley commented on SOLR-11865: - _I deleted my previous comment as I did it from an old/wrong

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456470#comment-16456470 ] Bruno Roustant commented on SOLR-11865: --- Actually the TrieSubsetMatcher introduced by the next patch

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452932#comment-16452932 ] David Smiley commented on SOLR-11865: - Maybe we should make it a query param, which is more convenient

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452868#comment-16452868 ] David Smiley commented on SOLR-11865: - Ok if keepElevationPriority works that way, I think there could

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450065#comment-16450065 ] Bruno Roustant commented on SOLR-11865: --- Sorry for the delay. Yes, if you can take it from here,

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427637#comment-16427637 ] David Smiley commented on SOLR-11865: - This is looking very good Bruno. You even hid

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426847#comment-16426847 ] Lucene/Solr QA commented on SOLR-11865: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426589#comment-16426589 ] Bruno Roustant commented on SOLR-11865: --- New delta patch with the modification mentioned.

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421062#comment-16421062 ] Lucene/Solr QA commented on SOLR-11865: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420920#comment-16420920 ] David Smiley commented on SOLR-11865: - Thanks by the way for entertaining some further improvements to

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420858#comment-16420858 ] David Smiley commented on SOLR-11865: - Thanks for the update; it's looking nicer. The delta patch was

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420620#comment-16420620 ] Bruno Roustant commented on SOLR-11865: --- [~dsmiley] I uploaded a new patch. Is it better now? >

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420604#comment-16420604 ] Lucene/Solr QA commented on SOLR-11865: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420329#comment-16420329 ] Bruno Roustant commented on SOLR-11865: --- 11- subsetMatch flag in ElevatingQuery. Yes, the idea is

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420322#comment-16420322 ] Bruno Roustant commented on SOLR-11865: --- 10- seen.contains(id) == false. I didn't know this Lucene

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420319#comment-16420319 ] Bruno Roustant commented on SOLR-11865: --- 9- Make the constructor of ElevatingQuery protected. Done.

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420317#comment-16420317 ] Bruno Roustant commented on SOLR-11865: --- 8- Use a UnaryOperator instead of IndexedValueProvider.

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420313#comment-16420313 ] Bruno Roustant commented on SOLR-11865: --- 7- In parseExcludedMarkerFieldName and

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420311#comment-16420311 ] Bruno Roustant commented on SOLR-11865: --- 6- Use {{localBoosts.addAll(boosted.keySet());}} at line

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420308#comment-16420308 ] Bruno Roustant commented on SOLR-11865: --- 5- Change comparator docVal (~line 1318) to use

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420301#comment-16420301 ] Bruno Roustant commented on SOLR-11865: --- 3- The indentation around line ~671 (contents of the for

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420302#comment-16420302 ] Bruno Roustant commented on SOLR-11865: --- 4- No "Can be overridden by extending this class". Sure.

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420300#comment-16420300 ] Bruno Roustant commented on SOLR-11865: --- 2- ElevationProvider should be immutable and simplified:

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420272#comment-16420272 ] Bruno Roustant commented on SOLR-11865: --- 1- InitializationExceptionHandler &

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395493#comment-16395493 ] David Smiley commented on SOLR-11865: - BTW one thing that I'm not sure about is if it might make sense

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395483#comment-16395483 ] David Smiley commented on SOLR-11865: - Thanks Bruno. It seems there is _some_ new/changed behavior