[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437490#comment-16437490
]
ASF subversion and git services commented on SOLR-11913:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437487#comment-16437487
]
ASF subversion and git services commented on SOLR-11913:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436784#comment-16436784
]
Tapan Vaishnav commented on SOLR-11913:
---
I see, how come it didn't show anything in the following
[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436771#comment-16436771
]
David Smiley commented on SOLR-11913:
-
Here's another update. It turns out there were some problems
[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436723#comment-16436723
]
Tapan Vaishnav commented on SOLR-11913:
---
bq.Sure; I'll re-order that. There is no real code rule
[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436722#comment-16436722
]
David Smiley commented on SOLR-11913:
-
{quote}We are not using the _Override_ annotation for the
[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436519#comment-16436519
]
Tapan Vaishnav commented on SOLR-11913:
---
[~dsmiley]
Thanks for the updated patch.
{quote}Added more
[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436266#comment-16436266
]
David Smiley commented on SOLR-11913:
-
Here's an updated patch. I think it's ready.
* added a
[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428288#comment-16428288
]
Lucene/Solr QA commented on SOLR-11913:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424994#comment-16424994
]
Tapan Vaishnav commented on SOLR-11913:
---
[~dsmiley] Thanks for your reply.
I have updated few
[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415996#comment-16415996
]
David Smiley commented on SOLR-11913:
-
{quote}I tried doing so but it gave me some error stating _Rat
[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411026#comment-16411026
]
Tapan Vaishnav commented on SOLR-11913:
---
{quote}The default impl can produce a Map.Entry with a
[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410710#comment-16410710
]
David Smiley commented on SOLR-11913:
-
You're getting there Tapan!
Typo in test name:
[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410663#comment-16410663
]
Tapan Vaishnav commented on SOLR-11913:
---
{quote}1. When uploading updated patches, please use an
[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408001#comment-16408001
]
David Smiley commented on SOLR-11913:
-
1. When uploading updated patches, please use an identical
[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407783#comment-16407783
]
Tapan Vaishnav commented on SOLR-11913:
---
[~dsmiley]
Thanks for your review.
I have fixed the
[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405481#comment-16405481
]
David Smiley commented on SOLR-11913:
-
It's a start.
The key part as referenced in the description --
[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403273#comment-16403273
]
Tapan Vaishnav commented on SOLR-11913:
---
[~dsmiley] [~gus_heck]
I have added the patch. Please have
[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375926#comment-16375926
]
Tapan Vaishnav commented on SOLR-11913:
---
[~dsmiley] Thanks for your quick reply.
I think this
[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373894#comment-16373894
]
David Smiley commented on SOLR-11913:
-
For the Iterable part, that might work but I don't think a
[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372535#comment-16372535
]
Tapan Vaishnav commented on SOLR-11913:
---
>From whatever I understood(Apologies if I'm heavily wrong,
21 matches
Mail list logo
