[jira] [Commented] (SOLR-11931) fix contrib/ltr custom inner class feature/normaliser/model persistence

2018-02-09 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-11931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358812#comment-16358812
 ] 

ASF subversion and git services commented on SOLR-11931:


Commit 162dbec889b3bb85a8bfdecc06b1a8e97c4b1312 in lucene-solr's branch 
refs/heads/branch_7x from [~cpoerschke]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=162dbec ]

SOLR-11931: contrib/ltr tests: s/getCanonicalName/getName


> fix contrib/ltr custom inner class feature/normaliser/model persistence
> ---
>
> Key: SOLR-11931
> URL: https://issues.apache.org/jira/browse/SOLR-11931
> Project: Solr
>  Issue Type: Bug
>  Components: contrib - LTR
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-11931.patch
>
>
> Custom feature/normaliser/model persistence across reloads is broken if the 
> custom class is an inner class. This is because the class would be configured 
> as (say) {{com.company.solr.ltr.feature.CustomFeatures$FeatureFoo}} but the 
> stores (wrongly) persist 
> {{com.company.solr.ltr.feature.CustomFeatures.FeatureFoo}} i.e. it's about 
> the difference between {{getName()}} and {{getCanonicalName()}} -- helpful 
> link: 
> https://stackoverflow.com/questions/15202997/what-is-the-difference-between-canonical-name-simple-name-and-class-name-in-jav/15203417



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-11931) fix contrib/ltr custom inner class feature/normaliser/model persistence

2018-02-09 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-11931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358784#comment-16358784
 ] 

ASF subversion and git services commented on SOLR-11931:


Commit 1a6d0f585f35ff6c4e0b188bfd14c0c8e092b688 in lucene-solr's branch 
refs/heads/master from [~cpoerschke]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1a6d0f5 ]

SOLR-11931: contrib/ltr tests: s/getCanonicalName/getName


> fix contrib/ltr custom inner class feature/normaliser/model persistence
> ---
>
> Key: SOLR-11931
> URL: https://issues.apache.org/jira/browse/SOLR-11931
> Project: Solr
>  Issue Type: Bug
>  Components: contrib - LTR
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-11931.patch
>
>
> Custom feature/normaliser/model persistence across reloads is broken if the 
> custom class is an inner class. This is because the class would be configured 
> as (say) {{com.company.solr.ltr.feature.CustomFeatures$FeatureFoo}} but the 
> stores (wrongly) persist 
> {{com.company.solr.ltr.feature.CustomFeatures.FeatureFoo}} i.e. it's about 
> the difference between {{getName()}} and {{getCanonicalName()}} -- helpful 
> link: 
> https://stackoverflow.com/questions/15202997/what-is-the-difference-between-canonical-name-simple-name-and-class-name-in-jav/15203417



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-11931) fix contrib/ltr custom inner class feature/normaliser/model persistence

2018-02-09 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-11931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358779#comment-16358779
 ] 

ASF subversion and git services commented on SOLR-11931:


Commit 530a931c66a94ae247700adba3bc4f2395728008 in lucene-solr's branch 
refs/heads/branch_7x from [~cpoerschke]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=530a931 ]

SOLR-11931: Fix contrib/ltr custom inner class feature/normaliser/model 
persistence.


> fix contrib/ltr custom inner class feature/normaliser/model persistence
> ---
>
> Key: SOLR-11931
> URL: https://issues.apache.org/jira/browse/SOLR-11931
> Project: Solr
>  Issue Type: Bug
>  Components: contrib - LTR
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-11931.patch
>
>
> Custom feature/normaliser/model persistence across reloads is broken if the 
> custom class is an inner class. This is because the class would be configured 
> as (say) {{com.company.solr.ltr.feature.CustomFeatures$FeatureFoo}} but the 
> stores (wrongly) persist 
> {{com.company.solr.ltr.feature.CustomFeatures.FeatureFoo}} i.e. it's about 
> the difference between {{getName()}} and {{getCanonicalName()}} -- helpful 
> link: 
> https://stackoverflow.com/questions/15202997/what-is-the-difference-between-canonical-name-simple-name-and-class-name-in-jav/15203417



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-11931) fix contrib/ltr custom inner class feature/normaliser/model persistence

2018-02-09 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-11931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358769#comment-16358769
 ] 

ASF subversion and git services commented on SOLR-11931:


Commit a1a9341a9c0aeb2c3ec819b7f74153a3b31a04be in lucene-solr's branch 
refs/heads/master from [~cpoerschke]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a1a9341 ]

SOLR-11931: Fix contrib/ltr custom inner class feature/normaliser/model 
persistence.


> fix contrib/ltr custom inner class feature/normaliser/model persistence
> ---
>
> Key: SOLR-11931
> URL: https://issues.apache.org/jira/browse/SOLR-11931
> Project: Solr
>  Issue Type: Bug
>  Components: contrib - LTR
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-11931.patch
>
>
> Custom feature/normaliser/model persistence across reloads is broken if the 
> custom class is an inner class. This is because the class would be configured 
> as (say) {{com.company.solr.ltr.feature.CustomFeatures$FeatureFoo}} but the 
> stores (wrongly) persist 
> {{com.company.solr.ltr.feature.CustomFeatures.FeatureFoo}} i.e. it's about 
> the difference between {{getName()}} and {{getCanonicalName()}} -- helpful 
> link: 
> https://stackoverflow.com/questions/15202997/what-is-the-difference-between-canonical-name-simple-name-and-class-name-in-jav/15203417



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org