[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430797#comment-16430797
]
ASF subversion and git services commented on SOLR-12139:
Commit 38
[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430795#comment-16430795
]
ASF subversion and git services commented on SOLR-12139:
Commit f0
[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430614#comment-16430614
]
Andrey Kudryavtsev commented on SOLR-12139:
---
Good work, David. I just added coup
[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427592#comment-16427592
]
Lucene/Solr QA commented on SOLR-12139:
---
| (x) *{color:red}-1 overall{color}* |
\\
\
[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427391#comment-16427391
]
David Smiley commented on SOLR-12139:
-
Andrey,
Your latest patch calls objectVal() on
[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423515#comment-16423515
]
Lucene/Solr QA commented on SOLR-12139:
---
| (x) *{color:red}-1 overall{color}* |
\\
\
[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423110#comment-16423110
]
Andrey Kudryavtsev commented on SOLR-12139:
---
Have to sacrifice fancy comparator
[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422982#comment-16422982
]
David Smiley commented on SOLR-12139:
-
bq. Ok, I see. Any concerns against checking ob
[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422811#comment-16422811
]
Andrey Kudryavtsev commented on SOLR-12139:
---
Ok, I see. Any concerns against che
[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422685#comment-16422685
]
David Smiley commented on SOLR-12139:
-
bq. So it's a ValueSource which pretends to be
[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422609#comment-16422609
]
Andrey Kudryavtsev commented on SOLR-12139:
---
{quote}
And as I look at it in m
[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422608#comment-16422608
]
David Smiley commented on SOLR-12139:
-
[~mkhludnev] LOL what an understatement! You w
[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421234#comment-16421234
]
Mikhail Khludnev commented on SOLR-12139:
-
[~dsmiley], not really. I'm lost. The p
[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421174#comment-16421174
]
David Smiley commented on SOLR-12139:
-
On the eve of committing, I'm very conflicted a
[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420702#comment-16420702
]
Mikhail Khludnev commented on SOLR-12139:
-
Yes, please, [~dsmiley]. Thank you.
>
[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420626#comment-16420626
]
David Smiley commented on SOLR-12139:
-
Shall I take this one over from you [~mkhludnev
[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16419380#comment-16419380
]
Lucene/Solr QA commented on SOLR-12139:
---
| (/) *{color:green}+1 overall{color}* |
\\
[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16419108#comment-16419108
]
David Smiley commented on SOLR-12139:
-
Nice work Andrey. We'll see how this fairs in
[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16418697#comment-16418697
]
Andrey Kudryavtsev commented on SOLR-12139:
---
Yep, we can make it not only about
[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417887#comment-16417887
]
David Smiley commented on SOLR-12139:
-
Cancel that +1. My concern with this patch is
[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417780#comment-16417780
]
David Smiley commented on SOLR-12139:
-
+1 Cool; nice and simple :-)
BTW I've used the
[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415020#comment-16415020
]
Lucene/Solr QA commented on SOLR-12139:
---
| (x) *{color:red}-1 overall{color}* |
\\
\
[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413912#comment-16413912
]
Andrey Kudryavtsev commented on SOLR-12139:
---
It could be something like [^SOLR-
23 matches
Mail list logo
