[jira] [Commented] (SOLR-12333) Redundant code in JSON response writer
[ https://issues.apache.org/jira/browse/SOLR-12333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472980#comment-16472980 ] ASF subversion and git services commented on SOLR-12333: Commit 29b323605130e3173deeab06661880ef9db874e8 in lucene-solr's branch refs/heads/branch_7x from [~mkhludnev] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=29b3236 ] SOLR-12333: drop redundant lines in JSON response writers > Redundant code in JSON response writer > --- > > Key: SOLR-12333 > URL: https://issues.apache.org/jira/browse/SOLR-12333 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: Response Writers >Affects Versions: 7.4 >Reporter: Mikhail Khludnev >Priority: Major > Attachments: SOLR-12333.patch > > > https://issues.apache.org/jira/browse/SOLR-12096?focusedCommentId=16467537=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16467537 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12333) Redundant code in JSON response writer
[ https://issues.apache.org/jira/browse/SOLR-12333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472979#comment-16472979 ] ASF subversion and git services commented on SOLR-12333: Commit d020ba84e4321225fbf95c62007a278e5db793b6 in lucene-solr's branch refs/heads/master from [~mkhludnev] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d020ba8 ] SOLR-12333: drop redundant lines in JSON response writers > Redundant code in JSON response writer > --- > > Key: SOLR-12333 > URL: https://issues.apache.org/jira/browse/SOLR-12333 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: Response Writers >Affects Versions: 7.4 >Reporter: Mikhail Khludnev >Priority: Major > Attachments: SOLR-12333.patch > > > https://issues.apache.org/jira/browse/SOLR-12096?focusedCommentId=16467537=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16467537 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12333) Redundant code in JSON response writer
[ https://issues.apache.org/jira/browse/SOLR-12333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472334#comment-16472334 ] Ishan Chattopadhyaya commented on SOLR-12333: - +1.. Thanks [~dsmiley], [~mkhludnev] :-) > Redundant code in JSON response writer > --- > > Key: SOLR-12333 > URL: https://issues.apache.org/jira/browse/SOLR-12333 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: Response Writers >Affects Versions: 7.4 >Reporter: Mikhail Khludnev >Priority: Major > Attachments: SOLR-12333.patch > > > https://issues.apache.org/jira/browse/SOLR-12096?focusedCommentId=16467537=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16467537 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12333) Redundant code in JSON response writer
[ https://issues.apache.org/jira/browse/SOLR-12333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472259#comment-16472259 ] Munendra S N commented on SOLR-12333: - [~mkhludnev] LGTM, it makes sense to remove those lines. > Redundant code in JSON response writer > --- > > Key: SOLR-12333 > URL: https://issues.apache.org/jira/browse/SOLR-12333 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: Response Writers >Affects Versions: 7.4 >Reporter: Mikhail Khludnev >Priority: Major > Attachments: SOLR-12333.patch > > > https://issues.apache.org/jira/browse/SOLR-12096?focusedCommentId=16467537=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16467537 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12333) Redundant code in JSON response writer
[ https://issues.apache.org/jira/browse/SOLR-12333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472182#comment-16472182 ] Mikhail Khludnev commented on SOLR-12333: - [~munendrasn], [~ichattopadhyaya], I want to strip those lines, do you have a concern? > Redundant code in JSON response writer > --- > > Key: SOLR-12333 > URL: https://issues.apache.org/jira/browse/SOLR-12333 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: Response Writers >Affects Versions: 7.4 >Reporter: Mikhail Khludnev >Priority: Major > Attachments: SOLR-12333.patch > > > https://issues.apache.org/jira/browse/SOLR-12096?focusedCommentId=16467537=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16467537 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12333) Redundant code in JSON response writer
[
https://issues.apache.org/jira/browse/SOLR-12333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471478#comment-16471478
]
Lucene/Solr QA commented on SOLR-12333:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
47s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 4m 51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 4m 51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 4m 51s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}120m 58s{color}
| {color:red} core in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}137m 22s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.cloud.ZkControllerTest |
| | solr.cloud.autoscaling.SearchRateTriggerIntegrationTest |
| | solr.cloud.autoscaling.sim.TestTriggerIntegration |
| | solr.handler.TestSolrConfigHandlerCloud |
| | solr.cloud.autoscaling.sim.TestLargeCluster |
| | solr.cloud.autoscaling.NodeAddedTriggerTest |
| | solr.cloud.ConcurrentCreateRoutedAliasTest |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12333 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12922633/SOLR-12333.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 8a697ee |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 8 2015 |
| Default Java | 1.8.0_172 |
| unit |
https://builds.apache.org/job/PreCommit-SOLR-Build/88/artifact/out/patch-unit-solr_core.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/88/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/88/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Redundant code in JSON response writer
> ---
>
> Key: SOLR-12333
> URL: https://issues.apache.org/jira/browse/SOLR-12333
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Response Writers
>Affects Versions: 7.4
>Reporter: Mikhail Khludnev
>Priority: Major
> Attachments: SOLR-12333.patch
>
>
> https://issues.apache.org/jira/browse/SOLR-12096?focusedCommentId=16467537=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16467537
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
