[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506172#comment-16506172
]
ASF subversion and git services commented on SOLR-12338:
Commit
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506166#comment-16506166
]
ASF subversion and git services commented on SOLR-12338:
Commit
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506171#comment-16506171
]
ASF subversion and git services commented on SOLR-12338:
Commit
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494652#comment-16494652
]
ASF subversion and git services commented on SOLR-12338:
Commit
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494650#comment-16494650
]
ASF subversion and git services commented on SOLR-12338:
Commit
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494631#comment-16494631
]
Cao Manh Dat commented on SOLR-12338:
-
Thank [~dsmiley] !
> Replay buffering tlog in parallel
>
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494618#comment-16494618
]
David Smiley commented on SOLR-12338:
-
My intention with changing the loop is to reduce duplication
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494515#comment-16494515
]
Cao Manh Dat commented on SOLR-12338:
-
Attached a new patch for this ticket.
> Replay buffering tlog
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494504#comment-16494504
]
Cao Manh Dat commented on SOLR-12338:
-
{quote}But then I wonder if we can move the
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494172#comment-16494172
]
David Smiley commented on SOLR-12338:
-
ah; I think I can see why we acquire the size semaphore after
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494162#comment-16494162
]
David Smiley commented on SOLR-12338:
-
Please consider this alternative utility class:
{code:java}
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493180#comment-16493180
]
Cao Manh Dat commented on SOLR-12338:
-
The latest patch for this ticket. Including some cleanup and
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492749#comment-16492749
]
Cao Manh Dat commented on SOLR-12338:
-
Attached a patch base on [~dsmiley]'s review.
> Replay
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492538#comment-16492538
]
Cao Manh Dat commented on SOLR-12338:
-
{quote}
The hot while loop of map.putIfAbsent seems fishy to
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492410#comment-16492410
]
Cao Manh Dat commented on SOLR-12338:
-
Thanks a lot for your review [~dsmiley], I was too busy
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480089#comment-16480089
]
Yonik Seeley commented on SOLR-12338:
-
{quote}This is a very costly/risky logic to handle reordered
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480078#comment-16480078
]
Cao Manh Dat commented on SOLR-12338:
-
[~ysee...@gmail.com] The need to order things come from how we
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479675#comment-16479675
]
Yonik Seeley commented on SOLR-12338:
-
I haven't been following this issue, but the need to order
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479197#comment-16479197
]
David Smiley commented on SOLR-12338:
-
Maybe you can propose {{SetBlockingQueue}} (or whatever name we
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479131#comment-16479131
]
Cao Manh Dat commented on SOLR-12338:
-
bq. BTW I've twice gotten confused in this issue conversation
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479083#comment-16479083
]
David Smiley commented on SOLR-12338:
-
{quote}Upload a patch that makes a change from using an array
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478357#comment-16478357
]
Cao Manh Dat commented on SOLR-12338:
-
[~dsmiley] What do you think about the new patch?
> Replay
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475965#comment-16475965
]
Cao Manh Dat commented on SOLR-12338:
-
Interesting result, when I change from {{SetBlockingQueue}} to
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475814#comment-16475814
]
Cao Manh Dat commented on SOLR-12338:
-
Upload the patch that makes a change from using an array of
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475423#comment-16475423
]
Cao Manh Dat commented on SOLR-12338:
-
[~dsmiley] an annoying problem with ExecutorService is that
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474832#comment-16474832
]
David Smiley commented on SOLR-12338:
-
I looked at this again (after a few days of vacation) and I
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471502#comment-16471502
]
Mark Miller commented on SOLR-12338:
bq. Yeah, but we do not need that flag for the case of
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471495#comment-16471495
]
Cao Manh Dat commented on SOLR-12338:
-
{quote}
Given that some machines these days have dozens of
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471481#comment-16471481
]
Mark Miller commented on SOLR-12338:
{noformat}
+ private OrderedExecutor replayUpdatesExecutor = new
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471392#comment-16471392
]
Cao Manh Dat commented on SOLR-12338:
-
{quote}I have doubts on the use of a new
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470528#comment-16470528
]
David Smiley commented on SOLR-12338:
-
Also if you submit without an ID, then it should probably
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470518#comment-16470518
]
David Smiley commented on SOLR-12338:
-
This OrderedExecutor thing is nifty. It needs class-level
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470110#comment-16470110
]
Cao Manh Dat commented on SOLR-12338:
-
Attached a patch for this ticket, here are some notes:
- Thanks
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470098#comment-16470098
]
Cao Manh Dat commented on SOLR-12338:
-
Hi [~ichattopadhyaya] yeah I think this is a good idea to do
[
https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469869#comment-16469869
]
Ishan Chattopadhyaya commented on SOLR-12338:
-
There are some situations where if in-place
35 matches
Mail list logo
