[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842306#comment-16842306 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841547#comment-16841547 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841535#comment-16841535 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841485#comment-16841485 ] Andrzej Bialecki commented on SOLR-12833: -- Looks like this hasn't been merged to 7x or 7_7 : *

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841459#comment-16841459 ] Jan Høydahl commented on SOLR-12833: This was reopened in April, more commits made in May, but is

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835804#comment-16835804 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835805#comment-16835805 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835806#comment-16835806 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833671#comment-16833671 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833672#comment-16833672 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833670#comment-16833670 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833640#comment-16833640 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833639#comment-16833639 ] Andrzej Bialecki commented on SOLR-12833: -- I think it's easier to just set the system property

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833207#comment-16833207 ] jefferyyuan commented on SOLR-12833: [~ichattopadhyaya] Please check the PR at 

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833192#comment-16833192 ] Ishan Chattopadhyaya commented on SOLR-12833: - There are some reproducible failures. Could it

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832868#comment-16832868 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832719#comment-16832719 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832031#comment-16832031 ] jefferyyuan commented on SOLR-12833: [~ichattopadhyaya] The error was related with unreleased

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831992#comment-16831992 ] Ishan Chattopadhyaya commented on SOLR-12833: - bq. .. but I saw some error: not sure whether

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831976#comment-16831976 ] jefferyyuan commented on SOLR-12833: [~ab] [~ichattopadhyaya]Sorry for the bug. Please check pr at 

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831974#comment-16831974 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831973#comment-16831973 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831972#comment-16831972 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831953#comment-16831953 ] Ishan Chattopadhyaya commented on SOLR-12833: - Thanks for the PR, [~yuanyun.cn].

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831922#comment-16831922 ] jefferyyuan commented on SOLR-12833: [~ichattopadhyaya]  [~aivanise] Found the issue and I will

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831909#comment-16831909 ] Ishan Chattopadhyaya commented on SOLR-12833: - Just wanted to point to these discussions [0],

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831886#comment-16831886 ] Ishan Chattopadhyaya commented on SOLR-12833: - Seems like this was already released with 8.0

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831788#comment-16831788 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831786#comment-16831786 ] jefferyyuan commented on SOLR-12833: Thanks for the ingo [~ab], I am checking it now and will focus

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831778#comment-16831778 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831703#comment-16831703 ] Andrzej Bialecki commented on SOLR-12833: -- [~yuanyun.cn] Hmm, I'm seeing occasional lock-ups

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831170#comment-16831170 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831166#comment-16831166 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831164#comment-16831164 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830852#comment-16830852 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830688#comment-16830688 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830669#comment-16830669 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829823#comment-16829823 ] Andrzej Bialecki commented on SOLR-12833: -- LGTM :) [~markrmil...@gmail.com] - would you like

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825415#comment-16825415 ] jefferyyuan commented on SOLR-12833: [~ab] [~markrmil...@gmail.com] I cleaned the code and added the

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825043#comment-16825043 ] Andrzej Bialecki commented on SOLR-12833: -- Nice! I like this refactoring. Minor issue: I think

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824565#comment-16824565 ] jefferyyuan commented on SOLR-12833: [~ab] [~markrmil...@gmail.com] thanks for your update and sorry

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824110#comment-16824110 ] Andrzej Bialecki commented on SOLR-12833: -- Also, I was able to confirm that removing the {{int

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824104#comment-16824104 ] Andrzej Bialecki commented on SOLR-12833: -- Looking closer at the code I don't think it can be

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820911#comment-16820911 ] Andrzej Bialecki commented on SOLR-12833: -- [~yuanyun.cn] - any updates? the PR as it is now

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815113#comment-16815113 ] Andrzej Bialecki commented on SOLR-12833: -- Thanks [~yuanyun.cn]. As I mentioned before, this

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815081#comment-16815081 ] jefferyyuan commented on SOLR-12833: [~ab]Based on your suggestion, I removed 

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814993#comment-16814993 ] jefferyyuan commented on SOLR-12833: [~ab] I will create the pr by end of tomorrow. Thanks. > Use

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814236#comment-16814236 ] Andrzej Bialecki commented on SOLR-12833: -- [~yuanyun.cn] are you working on an updated patch?

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812642#comment-16812642 ] Andrzej Bialecki commented on SOLR-12833: -- Ok, thanks for the explanation. IMHO we should

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810203#comment-16810203 ] jefferyyuan commented on SOLR-12833: [~ab] vinfo.lockForUpdate() is using the readLock().lock(), so 

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809650#comment-16809650 ] Andrzej Bialecki commented on SOLR-12833: -- bq. if there is not a lot of competition on same

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809012#comment-16809012 ] jefferyyuan commented on SOLR-12833: thanks for the findings, [~ab], [~markrmil...@gmail.com] as you

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808686#comment-16808686 ] Andrzej Bialecki commented on SOLR-12833: -- It's not much, but we can get rid of the int (4

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807970#comment-16807970 ] Mark Miller commented on SOLR-12833: Yes, we should fight to minimize this cost and add documentation

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807868#comment-16807868 ] Andrzej Bialecki commented on SOLR-12833: -- There is one unfortunate consequence of this change

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763030#comment-16763030 ] Cassandra Targett commented on SOLR-12833: -- [~markrmil...@gmail.com], I think this be resolved?

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712579#comment-16712579 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711589#comment-16711589 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711586#comment-16711586 ] ASF subversion and git services commented on SOLR-12833: Commit

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709103#comment-16709103 ] jefferyyuan commented on SOLR-12833: It looks great for me and thanks, [~markrmil...@gmail.com]. >

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708910#comment-16708910 ] Mark Miller commented on SOLR-12833: Hey [~yuanyun.cn], how does this approach look to you? It keeps

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698416#comment-16698416 ] Mark Miller commented on SOLR-12833: Let me mess with this a bit and put up a patch building on yours

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688695#comment-16688695 ] Mark Miller commented on SOLR-12833: Yeah, it's confusing because Java already has the ida of tryLock

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688670#comment-16688670 ] jefferyyuan commented on SOLR-12833: Hi, [~markrmil...@gmail.com], the tryGetVersionBucketLock will

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687573#comment-16687573 ] Mark Miller commented on SOLR-12833: Hey [~yuanyun.cn], I was looking through the patch and I have

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684131#comment-16684131 ] Mark Miller commented on SOLR-12833: Cool, I'll try and get this in soon. > Use timed-out lock in

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663804#comment-16663804 ] Mark Miller commented on SOLR-12833: bq. The default value can be -1, so it behaves same - wait

[jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor

[ https://issues.apache.org/jira/browse/SOLR-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639043#comment-16639043 ] jefferyyuan commented on SOLR-12833: Here is the PR: