[jira] [Commented] (SOLR-13008) JSON Document Transformer doesn't heed "indent" parameter

2019-01-21 Thread Gus Heck (JIRA)


[ 
https://issues.apache.org/jira/browse/SOLR-13008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748006#comment-16748006
 ] 

Gus Heck commented on SOLR-13008:
-

I'm wondering if it might be better to have this set on a per field basis i.e. 
{{:[json indent=true]}}. That one stupidly large field might make you scroll 
forever to find the field you actually want to read... This should in theory be 
not too hard since IIRC these parse with the same code as LocalParams (just [ 
instead of { ) and other transformers have args (i.e. {{val}} and {{explain}}) 

> JSON Document Transformer doesn't heed "indent" parameter
> -
>
> Key: SOLR-13008
> URL: https://issues.apache.org/jira/browse/SOLR-13008
> Project: Solr
>  Issue Type: Improvement
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Response Writers
>Affects Versions: 7.5
>Reporter: Eric Pugh
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> A query like "wt=json=id,subject:[json]=true", will return the 
> field subject as JSON, however the indent parameter is ignored on the nested 
> JSON.   This can lead to a very wide response that you have to scroll over.  
> Often I add indent=true becasue I want to see the structure of my embedded 
> JSON text, and I need to cut'n'paste over to another editor.   This would let 
> the nested JSON object be pretty printed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-13008) JSON Document Transformer doesn't heed "indent" parameter

2018-11-28 Thread Eric Pugh (JIRA)


[ 
https://issues.apache.org/jira/browse/SOLR-13008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701991#comment-16701991
 ] 

Eric Pugh commented on SOLR-13008:
--

Thanks [~elyograg] for looking at this.   I was thinking as I worked on the 
patch, of also expanding the documentation.  It's a really powerful feature 
that isn't well known!  Do you think that should be a separate SOLR issue, or 
add additional documentation, including the `indent=true` impact as part of 
this issue?   

As far as the precommit, I did get the error you suspected.   So I added the 
SHA checksum file.   However, reading through the 
`./solr/licenses/README.committers.txt` file, it appears I should add a 
`jackson-dataformat-xml-LICENSE-ASL.txt` and an empty 
`jackson-dataformat-xml-NOTICE.txt` file?   Or is adding that the 
responsibility of the commiter who actually commits this patch?

> JSON Document Transformer doesn't heed "indent" parameter
> -
>
> Key: SOLR-13008
> URL: https://issues.apache.org/jira/browse/SOLR-13008
> Project: Solr
>  Issue Type: Improvement
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Response Writers
>Affects Versions: 7.5
>Reporter: Eric Pugh
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> A query like "wt=json=id,subject:[json]=true", will return the 
> field subject as JSON, however the indent parameter is ignored on the nested 
> JSON.   This can lead to a very wide response that you have to scroll over.  
> Often I add indent=true becasue I want to see the structure of my embedded 
> JSON text, and I need to cut'n'paste over to another editor.   This would let 
> the nested JSON object be pretty printed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (SOLR-13008) JSON Document Transformer doesn't heed "indent" parameter

2018-11-27 Thread Shawn Heisey (JIRA)


[ 
https://issues.apache.org/jira/browse/SOLR-13008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701227#comment-16701227
 ] 

Shawn Heisey commented on SOLR-13008:
-

I had to go look at the docs to figure out what adding {{:[json]}} to a field 
in the fl param does.

The docs are not terribly clear on it, though.  The PDF I looked at (7.5) says 
that you get "the actual raw XML or JSON structure instead of just the string 
value."  But exactly what that means is not really clear to me, and there's no 
output shown for clarification of what it actually does.

The premise sounds reasonable, but my understanding of the code and the impact 
of the suggested change is pretty low.

Minor note:  The patch would fail precommit, because there's no checksum file 
for the added jar.  If I remember right, that's added with "ant jar-checksums".

> JSON Document Transformer doesn't heed "indent" parameter
> -
>
> Key: SOLR-13008
> URL: https://issues.apache.org/jira/browse/SOLR-13008
> Project: Solr
>  Issue Type: Improvement
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Response Writers
>Affects Versions: 7.5
>Reporter: Eric Pugh
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> A query like "wt=json=id,subject:[json]=true", will return the 
> field subject as JSON, however the indent parameter is ignored on the nested 
> JSON.   This can lead to a very wide response that you have to scroll over.  
> Often I add indent=true becasue I want to see the structure of my embedded 
> JSON text, and I need to cut'n'paste over to another editor.   This would let 
> the nested JSON object be pretty printed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org