[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830929#comment-16830929 ] ASF subversion and git services commented on SOLR-13335: Commit 6d048703d68aa64937a51f75d434aa87dce8da38 in lucene-solr's branch refs/heads/branch_8_1 from Ishan Chattopadhyaya [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=6d04870 ] SOLR-13335: Fix addVersion.py script that references velocity versions > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > Attachments: SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch, > SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch > > Time Spent: 20m > Remaining Estimate: 0h > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang > Copy some detail from SOLR-9079 investigation: > * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang > * velocity 1.7 was released - 2010-11-29 > * LUCENE-5249 from 2013 was the last time velocity was changed in > lucene/ivy-versions.properties > * velocity-tools 2.0 has an optional dependency on commons-lang > * velocity 1.7 has a hard dependency on commons-lang. > Upgrading velocity 1.7 -> 2.0 > * http://velocity.apache.org/engine/2.0/upgrading.html > * Change velocity to velocity-engine-core > * upgrades commons-lang to commons-lang3 > So if we want to finish removing commons-lang, we need to upgrade velocity. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830928#comment-16830928 ] ASF subversion and git services commented on SOLR-13335: Commit 37f0e1c68a6b6a5214a462a924ba7c1f2aa5bd19 in lucene-solr's branch refs/heads/branch_8_1 from Ishan Chattopadhyaya [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=37f0e1c ] SOLR-13335: Fix addVersion.py script that references velocity versions > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > Attachments: SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch, > SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch > > Time Spent: 20m > Remaining Estimate: 0h > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang > Copy some detail from SOLR-9079 investigation: > * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang > * velocity 1.7 was released - 2010-11-29 > * LUCENE-5249 from 2013 was the last time velocity was changed in > lucene/ivy-versions.properties > * velocity-tools 2.0 has an optional dependency on commons-lang > * velocity 1.7 has a hard dependency on commons-lang. > Upgrading velocity 1.7 -> 2.0 > * http://velocity.apache.org/engine/2.0/upgrading.html > * Change velocity to velocity-engine-core > * upgrades commons-lang to commons-lang3 > So if we want to finish removing commons-lang, we need to upgrade velocity. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830926#comment-16830926 ] ASF subversion and git services commented on SOLR-13335: Commit 53eafe75f35c8b3ac46b77a817e64eaef85b343a in lucene-solr's branch refs/heads/master from Ishan Chattopadhyaya [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=53eafe7 ] SOLR-13335: Fix addVersion.py script that references velocity versions > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > Attachments: SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch, > SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch > > Time Spent: 20m > Remaining Estimate: 0h > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang > Copy some detail from SOLR-9079 investigation: > * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang > * velocity 1.7 was released - 2010-11-29 > * LUCENE-5249 from 2013 was the last time velocity was changed in > lucene/ivy-versions.properties > * velocity-tools 2.0 has an optional dependency on commons-lang > * velocity 1.7 has a hard dependency on commons-lang. > Upgrading velocity 1.7 -> 2.0 > * http://velocity.apache.org/engine/2.0/upgrading.html > * Change velocity to velocity-engine-core > * upgrades commons-lang to commons-lang3 > So if we want to finish removing commons-lang, we need to upgrade velocity. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830927#comment-16830927 ] ASF subversion and git services commented on SOLR-13335: Commit 0d8243a132fd2894f8c5409aaade5c3d0349e746 in lucene-solr's branch refs/heads/master from Ishan Chattopadhyaya [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=0d8243a ] SOLR-13335: Fix addVersion.py script that references velocity versions > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > Attachments: SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch, > SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch > > Time Spent: 20m > Remaining Estimate: 0h > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang > Copy some detail from SOLR-9079 investigation: > * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang > * velocity 1.7 was released - 2010-11-29 > * LUCENE-5249 from 2013 was the last time velocity was changed in > lucene/ivy-versions.properties > * velocity-tools 2.0 has an optional dependency on commons-lang > * velocity 1.7 has a hard dependency on commons-lang. > Upgrading velocity 1.7 -> 2.0 > * http://velocity.apache.org/engine/2.0/upgrading.html > * Change velocity to velocity-engine-core > * upgrades commons-lang to commons-lang3 > So if we want to finish removing commons-lang, we need to upgrade velocity. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830925#comment-16830925 ] ASF subversion and git services commented on SOLR-13335: Commit 4bc33a881910b98639380fcc0465b367a6f84ef5 in lucene-solr's branch refs/heads/branch_8x from Ishan Chattopadhyaya [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=4bc33a8 ] SOLR-13335: Fix addVersion.py script that references velocity versions > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > Attachments: SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch, > SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch > > Time Spent: 20m > Remaining Estimate: 0h > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang > Copy some detail from SOLR-9079 investigation: > * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang > * velocity 1.7 was released - 2010-11-29 > * LUCENE-5249 from 2013 was the last time velocity was changed in > lucene/ivy-versions.properties > * velocity-tools 2.0 has an optional dependency on commons-lang > * velocity 1.7 has a hard dependency on commons-lang. > Upgrading velocity 1.7 -> 2.0 > * http://velocity.apache.org/engine/2.0/upgrading.html > * Change velocity to velocity-engine-core > * upgrades commons-lang to commons-lang3 > So if we want to finish removing commons-lang, we need to upgrade velocity. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830923#comment-16830923 ] ASF subversion and git services commented on SOLR-13335: Commit 079b084fbd06bf2cd8b53cab397c67006d37a2cf in lucene-solr's branch refs/heads/branch_8x from Ishan Chattopadhyaya [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=079b084 ] SOLR-13335: Fix addVersion.py script that references velocity versions > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > Attachments: SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch, > SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch > > Time Spent: 20m > Remaining Estimate: 0h > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang > Copy some detail from SOLR-9079 investigation: > * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang > * velocity 1.7 was released - 2010-11-29 > * LUCENE-5249 from 2013 was the last time velocity was changed in > lucene/ivy-versions.properties > * velocity-tools 2.0 has an optional dependency on commons-lang > * velocity 1.7 has a hard dependency on commons-lang. > Upgrading velocity 1.7 -> 2.0 > * http://velocity.apache.org/engine/2.0/upgrading.html > * Change velocity to velocity-engine-core > * upgrades commons-lang to commons-lang3 > So if we want to finish removing commons-lang, we need to upgrade velocity. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[
https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830922#comment-16830922
]
Ishan Chattopadhyaya commented on SOLR-13335:
-
Seems like the addVersion script was broken due to this. It errors out on
master and branch_8x like this:
{code}
[ishan@x260 lucene-solr] $ python3 -u dev-tools/scripts/addVersion.py 8.2.0
branch_type is BranchType.stable
Adding new version 8.2.0
adding new section to lucene/CHANGES.txt...uptodate
Traceback (most recent call last):
File "dev-tools/scripts/addVersion.py", line 244, in
main()
File "dev-tools/scripts/addVersion.py", line 217, in main
update_changes('solr/CHANGES.txt', newconf.version, get_solr_init_changes())
File "dev-tools/scripts/addVersion.py", line 209, in get_solr_init_changes
''' % parse_properties_file('lucene/ivy-versions.properties'))
KeyError: '/org.apache.velocity/velocity'
{code}
I'm looking into a fix for this.
> Upgrade to velocity 2.0 and velocity-tools 3.0
> --
>
> Key: SOLR-13335
> URL: https://issues.apache.org/jira/browse/SOLR-13335
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 8.1, master (9.0)
>
> Attachments: SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch,
> SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As part of looking to remove old commons-lang in SOLR-9079, found that
> velocity depends on it. Upgrading Velocity would allow completely removing
> commons-lang
> Copy some detail from SOLR-9079 investigation:
> * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang
> * velocity 1.7 was released - 2010-11-29
> * LUCENE-5249 from 2013 was the last time velocity was changed in
> lucene/ivy-versions.properties
> * velocity-tools 2.0 has an optional dependency on commons-lang
> * velocity 1.7 has a hard dependency on commons-lang.
> Upgrading velocity 1.7 -> 2.0
> * http://velocity.apache.org/engine/2.0/upgrading.html
> * Change velocity to velocity-engine-core
> * upgrades commons-lang to commons-lang3
> So if we want to finish removing commons-lang, we need to upgrade velocity.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800722#comment-16800722 ] ASF subversion and git services commented on SOLR-13335: Commit f545e64061b839c99e37cd6832431f13a806429a in lucene-solr's branch refs/heads/branch_8x from Kevin Risden [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=f545e64 ] SOLR-13335: Upgrade to velocity 2.0 and velocity-tools 3.0 Signed-off-by: Kevin Risden > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > Attachments: SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch, > SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch > > Time Spent: 20m > Remaining Estimate: 0h > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang > Copy some detail from SOLR-9079 investigation: > * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang > * velocity 1.7 was released - 2010-11-29 > * LUCENE-5249 from 2013 was the last time velocity was changed in > lucene/ivy-versions.properties > * velocity-tools 2.0 has an optional dependency on commons-lang > * velocity 1.7 has a hard dependency on commons-lang. > Upgrading velocity 1.7 -> 2.0 > * http://velocity.apache.org/engine/2.0/upgrading.html > * Change velocity to velocity-engine-core > * upgrades commons-lang to commons-lang3 > So if we want to finish removing commons-lang, we need to upgrade velocity. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800704#comment-16800704 ] ASF subversion and git services commented on SOLR-13335: Commit 4e230388ba239ca732aee7f61bc182644c5f0c3f in lucene-solr's branch refs/heads/master from Kevin Risden [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=4e23038 ] SOLR-13335: Upgrade to velocity 2.0 and velocity-tools 3.0 Signed-off-by: Kevin Risden > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > Attachments: SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch, > SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch > > Time Spent: 10m > Remaining Estimate: 0h > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang > Copy some detail from SOLR-9079 investigation: > * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang > * velocity 1.7 was released - 2010-11-29 > * LUCENE-5249 from 2013 was the last time velocity was changed in > lucene/ivy-versions.properties > * velocity-tools 2.0 has an optional dependency on commons-lang > * velocity 1.7 has a hard dependency on commons-lang. > Upgrading velocity 1.7 -> 2.0 > * http://velocity.apache.org/engine/2.0/upgrading.html > * Change velocity to velocity-engine-core > * upgrades commons-lang to commons-lang3 > So if we want to finish removing commons-lang, we need to upgrade velocity. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800647#comment-16800647 ] Kevin Risden commented on SOLR-13335: - Latest patch is based on master after dom4j removal from SOLR-13342 > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > Attachments: SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch, > SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch > > Time Spent: 10m > Remaining Estimate: 0h > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang > Copy some detail from SOLR-9079 investigation: > * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang > * velocity 1.7 was released - 2010-11-29 > * LUCENE-5249 from 2013 was the last time velocity was changed in > lucene/ivy-versions.properties > * velocity-tools 2.0 has an optional dependency on commons-lang > * velocity 1.7 has a hard dependency on commons-lang. > Upgrading velocity 1.7 -> 2.0 > * http://velocity.apache.org/engine/2.0/upgrading.html > * Change velocity to velocity-engine-core > * upgrades commons-lang to commons-lang3 > So if we want to finish removing commons-lang, we need to upgrade velocity. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[
https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800321#comment-16800321
]
Lucene/Solr QA commented on SOLR-13335:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check configsets' lucene version
{color} | {color:green} 1m 10s{color} | {color:green} the patch passed {color}
|
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check licenses {color} | {color:green}
1m 26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate ref guide {color} |
{color:green} 1m 10s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
24s{color} | {color:green} velocity in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 6m 47s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13335 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12963400/SOLR-13335.patch |
| Optional Tests | checklicenses validatesourcepatterns ratsources compile
javac unit checkforbiddenapis checkluceneversion validaterefguide |
| uname | Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon
Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / dad414c |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | 1.8.0_191 |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/352/testReport/ |
| modules | C: lucene solr solr/contrib/velocity solr/server
solr/solr-ref-guide U: . |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/352/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Upgrade to velocity 2.0 and velocity-tools 3.0
> --
>
> Key: SOLR-13335
> URL: https://issues.apache.org/jira/browse/SOLR-13335
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 8.1, master (9.0)
>
> Attachments: SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch,
> SOLR-13335.patch, SOLR-13335.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As part of looking to remove old commons-lang in SOLR-9079, found that
> velocity depends on it. Upgrading Velocity would allow completely removing
> commons-lang
> Copy some detail from SOLR-9079 investigation:
> * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang
> * velocity 1.7 was released - 2010-11-29
> * LUCENE-5249 from 2013 was the last time velocity was changed in
> lucene/ivy-versions.properties
> * velocity-tools 2.0 has an optional dependency on commons-lang
> * velocity 1.7 has a hard dependency on commons-lang.
> Upgrading velocity 1.7 -> 2.0
> * http://velocity.apache.org/engine/2.0/upgrading.html
> * Change velocity to velocity-engine-core
> * upgrades commons-lang to commons-lang3
> So if we want to finish removing commons-lang, we need to upgrade velocity.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail:
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799382#comment-16799382 ] Kevin Risden commented on SOLR-13335: - Velocity upgrade also removes the need for dom4j. See SOLR-13342 > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > Attachments: SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch, > SOLR-13335.patch, SOLR-13335.patch > > Time Spent: 10m > Remaining Estimate: 0h > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang > Copy some detail from SOLR-9079 investigation: > * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang > * velocity 1.7 was released - 2010-11-29 > * LUCENE-5249 from 2013 was the last time velocity was changed in > lucene/ivy-versions.properties > * velocity-tools 2.0 has an optional dependency on commons-lang > * velocity 1.7 has a hard dependency on commons-lang. > Upgrading velocity 1.7 -> 2.0 > * http://velocity.apache.org/engine/2.0/upgrading.html > * Change velocity to velocity-engine-core > * upgrades commons-lang to commons-lang3 > So if we want to finish removing commons-lang, we need to upgrade velocity. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798930#comment-16798930 ] Kevin Risden commented on SOLR-13335: - Sorry I definitely missed that comment somehow. I'll revert the changes and return the StringReader in the SolrParamResourceLoader case. > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > Attachments: SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch, > SOLR-13335.patch > > Time Spent: 10m > Remaining Estimate: 0h > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang > Copy some detail from SOLR-9079 investigation: > * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang > * velocity 1.7 was released - 2010-11-29 > * LUCENE-5249 from 2013 was the last time velocity was changed in > lucene/ivy-versions.properties > * velocity-tools 2.0 has an optional dependency on commons-lang > * velocity 1.7 has a hard dependency on commons-lang. > Upgrading velocity 1.7 -> 2.0 > * http://velocity.apache.org/engine/2.0/upgrading.html > * Change velocity to velocity-engine-core > * upgrades commons-lang to commons-lang3 > So if we want to finish removing commons-lang, we need to upgrade velocity. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798832#comment-16798832 ] Uwe Schindler commented on SOLR-13335: -- Sorry, as said before: In SolrParamResourceLoader: If something is a String already, there is no reason to convert it to an InputStream and then convert it back to a reader again. Here the enocing supplied by Velocity is to be ignored. Just reurn a StringReader. Actually, in Velocity 1.x it was a hack! For the SolrResourceLoader case all is fine! Great! > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > Attachments: SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch, > SOLR-13335.patch > > Time Spent: 10m > Remaining Estimate: 0h > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang > Copy some detail from SOLR-9079 investigation: > * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang > * velocity 1.7 was released - 2010-11-29 > * LUCENE-5249 from 2013 was the last time velocity was changed in > lucene/ivy-versions.properties > * velocity-tools 2.0 has an optional dependency on commons-lang > * velocity 1.7 has a hard dependency on commons-lang. > Upgrading velocity 1.7 -> 2.0 > * http://velocity.apache.org/engine/2.0/upgrading.html > * Change velocity to velocity-engine-core > * upgrades commons-lang to commons-lang3 > So if we want to finish removing commons-lang, we need to upgrade velocity. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[
https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798694#comment-16798694
]
Lucene/Solr QA commented on SOLR-13335:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
44s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check configsets' lucene version
{color} | {color:green} 2m 3s{color} | {color:green} the patch passed {color}
|
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 2m 8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 2m 3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check licenses {color} | {color:green}
2m 15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 2m 3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate ref guide {color} |
{color:green} 2m 3s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
48s{color} | {color:green} velocity in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 14m 38s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13335 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12963286/SOLR-13335.patch |
| Optional Tests | checklicenses validatesourcepatterns ratsources compile
javac unit checkforbiddenapis checkluceneversion validaterefguide |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / bca22d5 |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| Default Java | 1.8.0_191 |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/348/testReport/ |
| modules | C: lucene solr solr/contrib/velocity solr/server
solr/solr-ref-guide U: . |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/348/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Upgrade to velocity 2.0 and velocity-tools 3.0
> --
>
> Key: SOLR-13335
> URL: https://issues.apache.org/jira/browse/SOLR-13335
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 8.1, master (9.0)
>
> Attachments: SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch,
> SOLR-13335.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As part of looking to remove old commons-lang in SOLR-9079, found that
> velocity depends on it. Upgrading Velocity would allow completely removing
> commons-lang
> Copy some detail from SOLR-9079 investigation:
> * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang
> * velocity 1.7 was released - 2010-11-29
> * LUCENE-5249 from 2013 was the last time velocity was changed in
> lucene/ivy-versions.properties
> * velocity-tools 2.0 has an optional dependency on commons-lang
> * velocity 1.7 has a hard dependency on commons-lang.
> Upgrading velocity 1.7 -> 2.0
> * http://velocity.apache.org/engine/2.0/upgrading.html
> * Change velocity to velocity-engine-core
> * upgrades commons-lang to commons-lang3
> So if we want to finish removing commons-lang, we need to upgrade velocity.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail:
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798202#comment-16798202 ] Kevin Risden commented on SOLR-13335: - Latest patch uses buildReader for both SolrParamResourceLoader and SolrVelocityResourceLoader. Fixes the null issues in the Solr templates identified above. Tested and there were no velocity errors in the logs from the Velocity UI. > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > Attachments: SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch, > SOLR-13335.patch > > Time Spent: 10m > Remaining Estimate: 0h > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang > Copy some detail from SOLR-9079 investigation: > * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang > * velocity 1.7 was released - 2010-11-29 > * LUCENE-5249 from 2013 was the last time velocity was changed in > lucene/ivy-versions.properties > * velocity-tools 2.0 has an optional dependency on commons-lang > * velocity 1.7 has a hard dependency on commons-lang. > Upgrading velocity 1.7 -> 2.0 > * http://velocity.apache.org/engine/2.0/upgrading.html > * Change velocity to velocity-engine-core > * upgrades commons-lang to commons-lang3 > So if we want to finish removing commons-lang, we need to upgrade velocity. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798175#comment-16798175 ] Kevin Risden commented on SOLR-13335: - Thanks for keeping me honest [~thetaphi]. I'll make sure to reread the javadocs and fix the reader. I have been testing the Velocity UI to make sure that "real" templates are loading. > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > Attachments: SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch > > Time Spent: 10m > Remaining Estimate: 0h > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang > Copy some detail from SOLR-9079 investigation: > * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang > * velocity 1.7 was released - 2010-11-29 > * LUCENE-5249 from 2013 was the last time velocity was changed in > lucene/ivy-versions.properties > * velocity-tools 2.0 has an optional dependency on commons-lang > * velocity 1.7 has a hard dependency on commons-lang. > Upgrading velocity 1.7 -> 2.0 > * http://velocity.apache.org/engine/2.0/upgrading.html > * Change velocity to velocity-engine-core > * upgrades commons-lang to commons-lang3 > So if we want to finish removing commons-lang, we need to upgrade velocity. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[
https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798157#comment-16798157
]
Uwe Schindler commented on SOLR-13335:
--
Hi Kevin,
according to Javadocs, you should not build your reader that way. To do it
correctly, the base class of ResoureLoader has a protected method that takes an
input stream and the encoding to build a reader. So actually after you have the
InputStream from our SolrResourceLoader, you should call: {{return
buildReader(reader, encoding);}} (see
[https://velocity.apache.org/engine/2.0/apidocs/org/apache/velocity/runtime/resource/loader/ResourceLoader.html#buildReader-java.io.InputStream-java.lang.String-])
> Upgrade to velocity 2.0 and velocity-tools 3.0
> --
>
> Key: SOLR-13335
> URL: https://issues.apache.org/jira/browse/SOLR-13335
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 8.1, master (9.0)
>
> Attachments: SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As part of looking to remove old commons-lang in SOLR-9079, found that
> velocity depends on it. Upgrading Velocity would allow completely removing
> commons-lang
> Copy some detail from SOLR-9079 investigation:
> * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang
> * velocity 1.7 was released - 2010-11-29
> * LUCENE-5249 from 2013 was the last time velocity was changed in
> lucene/ivy-versions.properties
> * velocity-tools 2.0 has an optional dependency on commons-lang
> * velocity 1.7 has a hard dependency on commons-lang.
> Upgrading velocity 1.7 -> 2.0
> * http://velocity.apache.org/engine/2.0/upgrading.html
> * Change velocity to velocity-engine-core
> * upgrades commons-lang to commons-lang3
> So if we want to finish removing commons-lang, we need to upgrade velocity.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[
https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798141#comment-16798141
]
Kevin Risden commented on SOLR-13335:
-
Velocity UI testing:
{code:java}
./bin/solr start -e techproducts
open http://localhost:8983/solr/techproducts/browse
# Clicked around a bunch
#checked logs for errors
grep -F ERROR ./example/techproducts/logs/solr.log
./example/techproducts/logs/solr-8983-console.log
./bin/solr stop -all
{code}
Here are the errors that occurred with the attached patch.
{code:java}
./example/techproducts/logs/solr.log:2019-03-21 14:23:56.052 ERROR
(qtp776700275-22) [ x:techproducts] o.a.v.rendering Left side
($list.size($request.params.getParams('fq'))) of comparison operation has null
value at VM_global_library.vm[line 36, column 102]
./example/techproducts/logs/solr.log:2019-03-21 14:23:56.049 ERROR
(qtp776700275-22) [ x:techproducts] o.a.v.rendering Left side
($list.size($p)) of comparison operation has null value at
VM_global_library.vm[line 44, column 88]
./example/techproducts/logs/solr.log:2019-03-21 14:23:56.050 ERROR
(qtp776700275-22) [ x:techproducts] o.a.v.rendering Left side
($collations.size()) of comparison operation has null value at
did_you_mean.vm[line 6, column 25]
{code}
For reference here are the errors from Solr 8.0 using the same test.
{code:java}
./example/techproducts/logs/solr.log:2019-03-21 14:32:54.262 ERROR
(qtp572593338-15) [ x:techproducts] o.a.s.r.VelocityResponseWriter Left side
($collations.size()) of '>' operation has null value at did_you_mean.vm[line 6,
column 25]
{code}
So there are 2 new errors. I'll see what it takes to fix all 3 though. Look
like they are of the same flavor.
> Upgrade to velocity 2.0 and velocity-tools 3.0
> --
>
> Key: SOLR-13335
> URL: https://issues.apache.org/jira/browse/SOLR-13335
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 8.1, master (9.0)
>
> Attachments: SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As part of looking to remove old commons-lang in SOLR-9079, found that
> velocity depends on it. Upgrading Velocity would allow completely removing
> commons-lang
> Copy some detail from SOLR-9079 investigation:
> * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang
> * velocity 1.7 was released - 2010-11-29
> * LUCENE-5249 from 2013 was the last time velocity was changed in
> lucene/ivy-versions.properties
> * velocity-tools 2.0 has an optional dependency on commons-lang
> * velocity 1.7 has a hard dependency on commons-lang.
> Upgrading velocity 1.7 -> 2.0
> * http://velocity.apache.org/engine/2.0/upgrading.html
> * Change velocity to velocity-engine-core
> * upgrades commons-lang to commons-lang3
> So if we want to finish removing commons-lang, we need to upgrade velocity.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798124#comment-16798124 ] Kevin Risden commented on SOLR-13335: - Latest patch fixes charset issue brought up by [~thetaphi] and fixes ref guide links to Velocity version. I think this needs one more pass - build, test, check velocity UI but it is getting close. > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > Attachments: SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch > > Time Spent: 10m > Remaining Estimate: 0h > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang > Copy some detail from SOLR-9079 investigation: > * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang > * velocity 1.7 was released - 2010-11-29 > * LUCENE-5249 from 2013 was the last time velocity was changed in > lucene/ivy-versions.properties > * velocity-tools 2.0 has an optional dependency on commons-lang > * velocity 1.7 has a hard dependency on commons-lang. > Upgrading velocity 1.7 -> 2.0 > * http://velocity.apache.org/engine/2.0/upgrading.html > * Change velocity to velocity-engine-core > * upgrades commons-lang to commons-lang3 > So if we want to finish removing commons-lang, we need to upgrade velocity. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798075#comment-16798075 ] Uwe Schindler commented on SOLR-13335: -- Of course for the one reading it from a String using StringReader, the encoding passed must be ignored. But the one (as above) from the ResourceLoader should use the passed encoding. > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > Attachments: SOLR-13335.patch, SOLR-13335.patch > > Time Spent: 10m > Remaining Estimate: 0h > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang > Copy some detail from SOLR-9079 investigation: > * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang > * velocity 1.7 was released - 2010-11-29 > * LUCENE-5249 from 2013 was the last time velocity was changed in > lucene/ivy-versions.properties > * velocity-tools 2.0 has an optional dependency on commons-lang > * velocity 1.7 has a hard dependency on commons-lang. > Upgrading velocity 1.7 -> 2.0 > * http://velocity.apache.org/engine/2.0/upgrading.html > * Change velocity to velocity-engine-core > * upgrades commons-lang to commons-lang3 > So if we want to finish removing commons-lang, we need to upgrade velocity. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798067#comment-16798067 ] Kevin Risden commented on SOLR-13335: - Ah yea you are right. I took the previous version which didn't pass encoding and copy/pasted to new version with minor tweaks. Previous version assumed UTF-8. I'll fix this. > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > Attachments: SOLR-13335.patch, SOLR-13335.patch > > Time Spent: 10m > Remaining Estimate: 0h > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang > Copy some detail from SOLR-9079 investigation: > * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang > * velocity 1.7 was released - 2010-11-29 > * LUCENE-5249 from 2013 was the last time velocity was changed in > lucene/ivy-versions.properties > * velocity-tools 2.0 has an optional dependency on commons-lang > * velocity 1.7 has a hard dependency on commons-lang. > Upgrading velocity 1.7 -> 2.0 > * http://velocity.apache.org/engine/2.0/upgrading.html > * Change velocity to velocity-engine-core > * upgrades commons-lang to commons-lang3 > So if we want to finish removing commons-lang, we need to upgrade velocity. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[
https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798061#comment-16798061
]
Uwe Schindler commented on SOLR-13335:
--
One thing:
{noformat}
+ public Reader getResourceReader(String source, String encoding) throws
ResourceNotFoundException {
try {
- return loader.openResource("velocity/" + template_name);
+ return new InputStreamReader(loader.openResource("velocity/" + source),
StandardCharsets.UTF_8);
} catch (IOException ioe) {
throw new ResourceNotFoundException(ioe);
}
{noformat}
Should this not use the charset as passed in the parameter to
getResourceReader()? This hardcodes to UTF-8, but this looks wrong, at least
because velocity passes a charset as parameter!
> Upgrade to velocity 2.0 and velocity-tools 3.0
> --
>
> Key: SOLR-13335
> URL: https://issues.apache.org/jira/browse/SOLR-13335
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 8.1, master (9.0)
>
> Attachments: SOLR-13335.patch, SOLR-13335.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As part of looking to remove old commons-lang in SOLR-9079, found that
> velocity depends on it. Upgrading Velocity would allow completely removing
> commons-lang
> Copy some detail from SOLR-9079 investigation:
> * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang
> * velocity 1.7 was released - 2010-11-29
> * LUCENE-5249 from 2013 was the last time velocity was changed in
> lucene/ivy-versions.properties
> * velocity-tools 2.0 has an optional dependency on commons-lang
> * velocity 1.7 has a hard dependency on commons-lang.
> Upgrading velocity 1.7 -> 2.0
> * http://velocity.apache.org/engine/2.0/upgrading.html
> * Change velocity to velocity-engine-core
> * upgrades commons-lang to commons-lang3
> So if we want to finish removing commons-lang, we need to upgrade velocity.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[
https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797995#comment-16797995
]
Lucene/Solr QA commented on SOLR-13335:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
16s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check licenses {color} | {color:green}
1m 42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 25s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
26s{color} | {color:green} velocity in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 6m 27s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13335 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12963199/SOLR-13335.patch |
| Optional Tests | checklicenses validatesourcepatterns ratsources compile
javac unit checkforbiddenapis |
| uname | Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon
Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 6222abf |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | 1.8.0_191 |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/346/testReport/ |
| modules | C: lucene solr solr/contrib/velocity U: . |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/346/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Upgrade to velocity 2.0 and velocity-tools 3.0
> --
>
> Key: SOLR-13335
> URL: https://issues.apache.org/jira/browse/SOLR-13335
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 8.1, master (9.0)
>
> Attachments: SOLR-13335.patch, SOLR-13335.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As part of looking to remove old commons-lang in SOLR-9079, found that
> velocity depends on it. Upgrading Velocity would allow completely removing
> commons-lang
> Copy some detail from SOLR-9079 investigation:
> * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang
> * velocity 1.7 was released - 2010-11-29
> * LUCENE-5249 from 2013 was the last time velocity was changed in
> lucene/ivy-versions.properties
> * velocity-tools 2.0 has an optional dependency on commons-lang
> * velocity 1.7 has a hard dependency on commons-lang.
> Upgrading velocity 1.7 -> 2.0
> * http://velocity.apache.org/engine/2.0/upgrading.html
> * Change velocity to velocity-engine-core
> * upgrades commons-lang to commons-lang3
> So if we want to finish removing commons-lang, we need to upgrade velocity.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797974#comment-16797974 ] Erik Hatcher commented on SOLR-13335: - +1 to upgrading Velocity and removing commons-lang. > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > Attachments: SOLR-13335.patch, SOLR-13335.patch > > Time Spent: 10m > Remaining Estimate: 0h > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang > Copy some detail from SOLR-9079 investigation: > * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang > * velocity 1.7 was released - 2010-11-29 > * LUCENE-5249 from 2013 was the last time velocity was changed in > lucene/ivy-versions.properties > * velocity-tools 2.0 has an optional dependency on commons-lang > * velocity 1.7 has a hard dependency on commons-lang. > Upgrading velocity 1.7 -> 2.0 > * http://velocity.apache.org/engine/2.0/upgrading.html > * Change velocity to velocity-engine-core > * upgrades commons-lang to commons-lang3 > So if we want to finish removing commons-lang, we need to upgrade velocity. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797696#comment-16797696 ] Kevin Risden commented on SOLR-13335: - [~ehatcher] I know from SOLR-10705 you were in favor of keeping Velocity. Any thoughts on this change? > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > Attachments: SOLR-13335.patch, SOLR-13335.patch > > Time Spent: 10m > Remaining Estimate: 0h > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang > Copy some detail from SOLR-9079 investigation: > * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang > * velocity 1.7 was released - 2010-11-29 > * LUCENE-5249 from 2013 was the last time velocity was changed in > lucene/ivy-versions.properties > * velocity-tools 2.0 has an optional dependency on commons-lang > * velocity 1.7 has a hard dependency on commons-lang. > Upgrading velocity 1.7 -> 2.0 > * http://velocity.apache.org/engine/2.0/upgrading.html > * Change velocity to velocity-engine-core > * upgrades commons-lang to commons-lang3 > So if we want to finish removing commons-lang, we need to upgrade velocity. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797694#comment-16797694 ] Kevin Risden commented on SOLR-13335: - Updated patch after SOLR-9079 which finishes removal of commons-lang as part of this Velocity upgrade. > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > Attachments: SOLR-13335.patch, SOLR-13335.patch > > Time Spent: 10m > Remaining Estimate: 0h > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang > Copy some detail from SOLR-9079 investigation: > * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang > * velocity 1.7 was released - 2010-11-29 > * LUCENE-5249 from 2013 was the last time velocity was changed in > lucene/ivy-versions.properties > * velocity-tools 2.0 has an optional dependency on commons-lang > * velocity 1.7 has a hard dependency on commons-lang. > Upgrading velocity 1.7 -> 2.0 > * http://velocity.apache.org/engine/2.0/upgrading.html > * Change velocity to velocity-engine-core > * upgrades commons-lang to commons-lang3 > So if we want to finish removing commons-lang, we need to upgrade velocity. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797170#comment-16797170 ] Kevin Risden commented on SOLR-13335: - No new tests since this is just dependency changes. Need to look and see what reference guide changes might need to be made. > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > Attachments: SOLR-13335.patch > > Time Spent: 10m > Remaining Estimate: 0h > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[
https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796931#comment-16796931
]
Lucene/Solr QA commented on SOLR-13335:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
18s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 2m 57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 2m 57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check licenses {color} | {color:green}
3m 47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 2m 57s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
54s{color} | {color:green} velocity in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 10s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13335 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12963030/SOLR-13335.patch |
| Optional Tests | checklicenses validatesourcepatterns ratsources compile
javac unit checkforbiddenapis |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 2a1ed6e |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| Default Java | 1.8.0_191 |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/343/testReport/ |
| modules | C: lucene solr solr/contrib/velocity U: . |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/343/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Upgrade to velocity 2.0 and velocity-tools 3.0
> --
>
> Key: SOLR-13335
> URL: https://issues.apache.org/jira/browse/SOLR-13335
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 8.1, master (9.0)
>
> Attachments: SOLR-13335.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As part of looking to remove old commons-lang in SOLR-9079, found that
> velocity depends on it. Upgrading Velocity would allow completely removing
> commons-lang
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796465#comment-16796465 ] Kevin Risden commented on SOLR-13335: - Need to make sure reference guide configs get updated too if we upgrade velocity. > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796433#comment-16796433 ] Kevin Risden commented on SOLR-13335: - Upgrading velocity will remove commons-lang as a dependency requirement. > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13335) Upgrade to velocity 2.0 and velocity-tools 3.0
[ https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796427#comment-16796427 ] Kevin Risden commented on SOLR-13335: - upgraded velocity and velocity tools and checked https://lucene.apache.org/solr/guide/7_6/velocity-search-ui.html UI looked the same as with Solr 8.0.0. > Upgrade to velocity 2.0 and velocity-tools 3.0 > -- > > Key: SOLR-13335 > URL: https://issues.apache.org/jira/browse/SOLR-13335 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 8.1, master (9.0) > > > As part of looking to remove old commons-lang in SOLR-9079, found that > velocity depends on it. Upgrading Velocity would allow completely removing > commons-lang -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
