[jira] [Commented] (SOLR-13401) Metrics showing wring 'spins' property after override
[ https://issues.apache.org/jira/browse/SOLR-13401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818755#comment-16818755 ] Shalin Shekhar Mangar commented on SOLR-13401: -- Fair enough, I will mark this issue as invalid. > Metrics showing wring 'spins' property after override > - > > Key: SOLR-13401 > URL: https://issues.apache.org/jira/browse/SOLR-13401 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Affects Versions: 8.0 >Reporter: Amrit Sarkar >Priority: Major > Labels: metrics > > Even after setting required param to "false" acc to documentation – > https://lucene.apache.org/solr/guide/7_4/taking-solr-to-production.html#dynamic-defaults-for-concurrentmergescheduler > Alternatively, the boolean system property {{lucene.cms.override_spins}} can > be set in the SOLR_OPTS variable in the include file to override the > auto-detected value. Similarly, the system property > {{lucene.cms.override_core_count}} can be set to the number of CPU cores to > override the auto-detected processor count. > Container.fs.spins and Core.fs.spins are calculated as "true". > {code} > { > "responseHeader":{ > "status":0, > "QTime":90}, > "metrics":{ > "solr.jetty":{ > "org.eclipse.jetty.server.handler.DefaultHandler.1xx-responses":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.2xx-responses":{ > "count":749, > "meanRate":0.26577854703424414, > "1minRate":0.20563648170407736, > "5minRate":0.2340577654572216, > "15minRate":0.24729247425529033}, > "org.eclipse.jetty.server.handler.DefaultHandler.3xx-responses":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.4xx-responses":{ > "count":1, > "meanRate":3.548445163413177E-4, > "1minRate":6.64685036699106E-18, > "5minRate":2.7733971887474625E-6, > "15minRate":1.0450429716535352E-4}, > "org.eclipse.jetty.server.handler.DefaultHandler.5xx-responses":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.active-dispatches":0, > "org.eclipse.jetty.server.handler.DefaultHandler.active-requests":0, > "org.eclipse.jetty.server.handler.DefaultHandler.active-suspended":0, > "org.eclipse.jetty.server.handler.DefaultHandler.async-dispatches":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.async-timeouts":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.connect-requests":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0, > "min_ms":0.0, > "max_ms":0.0, > "mean_ms":0.0, > "median_ms":0.0, > "stddev_ms":0.0, > "p75_ms":0.0, > "p95_ms":0.0, > "p99_ms":0.0, > "p999_ms":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.delete-requests":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0, > "min_ms":0.0, > "max_ms":0.0, > "mean_ms":0.0, > "median_ms":0.0, > "stddev_ms":0.0, > "p75_ms":0.0, > "p95_ms":0.0, > "p99_ms":0.0, > "p999_ms":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.dispatches":{ > "count":750, > "meanRate":0.26613247165752213, > "1minRate":0.20563648170407736, > "5minRate":0.23406053885441036, > "15minRate":0.24739697855245568, > "min_ms":1.0, > "max_ms":8231.0, > "mean_ms":1.9138611068896936, > "median_ms":1.0, > "stddev_ms":4.227101567072412, > "p75_ms":2.0, > "p95_ms":2.0, > "p99_ms":34.0, > "p999_ms":48.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.get-requests":{ > "count":427, > "meanRate":0.15151854520088134, > "1minRate":0.12770720959194207, > "5minRate":0.13538027663316224, > "15minRate":0.13928403821024407, > "min_ms":1.0, > "max_ms":1759.0, >
[jira] [Commented] (SOLR-13401) Metrics showing wring 'spins' property after override
[ https://issues.apache.org/jira/browse/SOLR-13401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818713#comment-16818713 ] Andrzej Bialecki commented on SOLR-13401: -- bq. After all, that is what is actually being used by Lucene ... *in CMS*. I don't think it should override the node-level value reported by metrics. After all, the CMS-specific cpu property doesn't override the number of CPUs reported by metrics, nor it should. If you want to check whether the property was correctly set you can do this using the metrics API, which also reports system properties. > Metrics showing wring 'spins' property after override > - > > Key: SOLR-13401 > URL: https://issues.apache.org/jira/browse/SOLR-13401 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Affects Versions: 8.0 >Reporter: Amrit Sarkar >Priority: Major > Labels: metrics > > Even after setting required param to "false" acc to documentation – > https://lucene.apache.org/solr/guide/7_4/taking-solr-to-production.html#dynamic-defaults-for-concurrentmergescheduler > Alternatively, the boolean system property {{lucene.cms.override_spins}} can > be set in the SOLR_OPTS variable in the include file to override the > auto-detected value. Similarly, the system property > {{lucene.cms.override_core_count}} can be set to the number of CPU cores to > override the auto-detected processor count. > Container.fs.spins and Core.fs.spins are calculated as "true". > {code} > { > "responseHeader":{ > "status":0, > "QTime":90}, > "metrics":{ > "solr.jetty":{ > "org.eclipse.jetty.server.handler.DefaultHandler.1xx-responses":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.2xx-responses":{ > "count":749, > "meanRate":0.26577854703424414, > "1minRate":0.20563648170407736, > "5minRate":0.2340577654572216, > "15minRate":0.24729247425529033}, > "org.eclipse.jetty.server.handler.DefaultHandler.3xx-responses":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.4xx-responses":{ > "count":1, > "meanRate":3.548445163413177E-4, > "1minRate":6.64685036699106E-18, > "5minRate":2.7733971887474625E-6, > "15minRate":1.0450429716535352E-4}, > "org.eclipse.jetty.server.handler.DefaultHandler.5xx-responses":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.active-dispatches":0, > "org.eclipse.jetty.server.handler.DefaultHandler.active-requests":0, > "org.eclipse.jetty.server.handler.DefaultHandler.active-suspended":0, > "org.eclipse.jetty.server.handler.DefaultHandler.async-dispatches":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.async-timeouts":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.connect-requests":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0, > "min_ms":0.0, > "max_ms":0.0, > "mean_ms":0.0, > "median_ms":0.0, > "stddev_ms":0.0, > "p75_ms":0.0, > "p95_ms":0.0, > "p99_ms":0.0, > "p999_ms":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.delete-requests":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0, > "min_ms":0.0, > "max_ms":0.0, > "mean_ms":0.0, > "median_ms":0.0, > "stddev_ms":0.0, > "p75_ms":0.0, > "p95_ms":0.0, > "p99_ms":0.0, > "p999_ms":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.dispatches":{ > "count":750, > "meanRate":0.26613247165752213, > "1minRate":0.20563648170407736, > "5minRate":0.23406053885441036, > "15minRate":0.24739697855245568, > "min_ms":1.0, > "max_ms":8231.0, > "mean_ms":1.9138611068896936, > "median_ms":1.0, > "stddev_ms":4.227101567072412, > "p75_ms":2.0, > "p95_ms":2.0, > "p99_ms":34.0, >
[jira] [Commented] (SOLR-13401) Metrics showing wring 'spins' property after override
[ https://issues.apache.org/jira/browse/SOLR-13401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818573#comment-16818573 ] Shalin Shekhar Mangar commented on SOLR-13401: -- Ah, I thought that the metrics API will show the computed value if the parameter is present. I guess there is no way to verify the settings took effect until we actually create a core and check the default values of ConcurrentMergeScheduler? How about we show the overriden value for spins instead? After all, that is what is actually being used by Lucene. > Metrics showing wring 'spins' property after override > - > > Key: SOLR-13401 > URL: https://issues.apache.org/jira/browse/SOLR-13401 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Affects Versions: 8.0 >Reporter: Amrit Sarkar >Priority: Major > Labels: metrics > > Even after setting required param to "false" acc to documentation – > https://lucene.apache.org/solr/guide/7_4/taking-solr-to-production.html#dynamic-defaults-for-concurrentmergescheduler > Alternatively, the boolean system property {{lucene.cms.override_spins}} can > be set in the SOLR_OPTS variable in the include file to override the > auto-detected value. Similarly, the system property > {{lucene.cms.override_core_count}} can be set to the number of CPU cores to > override the auto-detected processor count. > Container.fs.spins and Core.fs.spins are calculated as "true". > {code} > { > "responseHeader":{ > "status":0, > "QTime":90}, > "metrics":{ > "solr.jetty":{ > "org.eclipse.jetty.server.handler.DefaultHandler.1xx-responses":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.2xx-responses":{ > "count":749, > "meanRate":0.26577854703424414, > "1minRate":0.20563648170407736, > "5minRate":0.2340577654572216, > "15minRate":0.24729247425529033}, > "org.eclipse.jetty.server.handler.DefaultHandler.3xx-responses":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.4xx-responses":{ > "count":1, > "meanRate":3.548445163413177E-4, > "1minRate":6.64685036699106E-18, > "5minRate":2.7733971887474625E-6, > "15minRate":1.0450429716535352E-4}, > "org.eclipse.jetty.server.handler.DefaultHandler.5xx-responses":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.active-dispatches":0, > "org.eclipse.jetty.server.handler.DefaultHandler.active-requests":0, > "org.eclipse.jetty.server.handler.DefaultHandler.active-suspended":0, > "org.eclipse.jetty.server.handler.DefaultHandler.async-dispatches":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.async-timeouts":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.connect-requests":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0, > "min_ms":0.0, > "max_ms":0.0, > "mean_ms":0.0, > "median_ms":0.0, > "stddev_ms":0.0, > "p75_ms":0.0, > "p95_ms":0.0, > "p99_ms":0.0, > "p999_ms":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.delete-requests":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0, > "min_ms":0.0, > "max_ms":0.0, > "mean_ms":0.0, > "median_ms":0.0, > "stddev_ms":0.0, > "p75_ms":0.0, > "p95_ms":0.0, > "p99_ms":0.0, > "p999_ms":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.dispatches":{ > "count":750, > "meanRate":0.26613247165752213, > "1minRate":0.20563648170407736, > "5minRate":0.23406053885441036, > "15minRate":0.24739697855245568, > "min_ms":1.0, > "max_ms":8231.0, > "mean_ms":1.9138611068896936, > "median_ms":1.0, > "stddev_ms":4.227101567072412, > "p75_ms":2.0, > "p95_ms":2.0, > "p99_ms":34.0, > "p999_ms":48.0}, >
[jira] [Commented] (SOLR-13401) Metrics showing wring 'spins' property after override
[ https://issues.apache.org/jira/browse/SOLR-13401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818338#comment-16818338 ] Andrzej Bialecki commented on SOLR-13401: -- These parameter overrides are specific to {{ConcurrentMergeScheduler}}, the override is not supported by the metrics subsystem - metrics report the actual value. > Metrics showing wring 'spins' property after override > - > > Key: SOLR-13401 > URL: https://issues.apache.org/jira/browse/SOLR-13401 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Affects Versions: 8.0 >Reporter: Amrit Sarkar >Priority: Major > Labels: metrics > > Even after setting required param to "false" acc to documentation – > https://lucene.apache.org/solr/guide/7_4/taking-solr-to-production.html#dynamic-defaults-for-concurrentmergescheduler > Alternatively, the boolean system property {{lucene.cms.override_spins}} can > be set in the SOLR_OPTS variable in the include file to override the > auto-detected value. Similarly, the system property > {{lucene.cms.override_core_count}} can be set to the number of CPU cores to > override the auto-detected processor count. > Container.fs.spins and Core.fs.spins are calculated as "true". > {code} > { > "responseHeader":{ > "status":0, > "QTime":90}, > "metrics":{ > "solr.jetty":{ > "org.eclipse.jetty.server.handler.DefaultHandler.1xx-responses":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.2xx-responses":{ > "count":749, > "meanRate":0.26577854703424414, > "1minRate":0.20563648170407736, > "5minRate":0.2340577654572216, > "15minRate":0.24729247425529033}, > "org.eclipse.jetty.server.handler.DefaultHandler.3xx-responses":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.4xx-responses":{ > "count":1, > "meanRate":3.548445163413177E-4, > "1minRate":6.64685036699106E-18, > "5minRate":2.7733971887474625E-6, > "15minRate":1.0450429716535352E-4}, > "org.eclipse.jetty.server.handler.DefaultHandler.5xx-responses":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.active-dispatches":0, > "org.eclipse.jetty.server.handler.DefaultHandler.active-requests":0, > "org.eclipse.jetty.server.handler.DefaultHandler.active-suspended":0, > "org.eclipse.jetty.server.handler.DefaultHandler.async-dispatches":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.async-timeouts":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.connect-requests":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0, > "min_ms":0.0, > "max_ms":0.0, > "mean_ms":0.0, > "median_ms":0.0, > "stddev_ms":0.0, > "p75_ms":0.0, > "p95_ms":0.0, > "p99_ms":0.0, > "p999_ms":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.delete-requests":{ > "count":0, > "meanRate":0.0, > "1minRate":0.0, > "5minRate":0.0, > "15minRate":0.0, > "min_ms":0.0, > "max_ms":0.0, > "mean_ms":0.0, > "median_ms":0.0, > "stddev_ms":0.0, > "p75_ms":0.0, > "p95_ms":0.0, > "p99_ms":0.0, > "p999_ms":0.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.dispatches":{ > "count":750, > "meanRate":0.26613247165752213, > "1minRate":0.20563648170407736, > "5minRate":0.23406053885441036, > "15minRate":0.24739697855245568, > "min_ms":1.0, > "max_ms":8231.0, > "mean_ms":1.9138611068896936, > "median_ms":1.0, > "stddev_ms":4.227101567072412, > "p75_ms":2.0, > "p95_ms":2.0, > "p99_ms":34.0, > "p999_ms":48.0}, > "org.eclipse.jetty.server.handler.DefaultHandler.get-requests":{ > "count":427, > "meanRate":0.15151854520088134, > "1minRate":0.12770720959194207, >