[jira] [Commented] (SOLR-13507) Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint.
[ https://issues.apache.org/jira/browse/SOLR-13507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879432#comment-16879432 ] ASF subversion and git services commented on SOLR-13507: Commit 5d3a84fcd0f3d4bded24e6db0c78bbdcba6f3b2a in lucene-solr's branch refs/heads/branch_8x from Anshum Gupta [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=5d3a84f ] SOLR-13507: Remove support for addr parameter from the /solr/admin/zookeeper endpoint. (#759) (#766) > Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint. > -- > > Key: SOLR-13507 > URL: https://issues.apache.org/jira/browse/SOLR-13507 > Project: Solr > Issue Type: Improvement >Reporter: Anshum Gupta >Assignee: Anshum Gupta >Priority: Major > Fix For: 8.2 > > Attachments: SOLR-13507.02.patch, SOLR-13507.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > The addr parameter isn't needed and it should be removed from the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13507) Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint.
[ https://issues.apache.org/jira/browse/SOLR-13507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878028#comment-16878028 ] ASF subversion and git services commented on SOLR-13507: Commit b7090d9c25ba430442628b0dc77c7c700cb35b33 in lucene-solr's branch refs/heads/master from Anshum Gupta [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=b7090d9 ] SOLR-13507: Remove support for addr parameter from the /solr/admin/zookeeper endpoint. (#759) > Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint. > -- > > Key: SOLR-13507 > URL: https://issues.apache.org/jira/browse/SOLR-13507 > Project: Solr > Issue Type: Improvement >Reporter: Anshum Gupta >Assignee: Anshum Gupta >Priority: Major > Attachments: SOLR-13507.02.patch, SOLR-13507.patch > > Time Spent: 50m > Remaining Estimate: 0h > > The addr parameter isn't needed and it should be removed from the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13507) Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint.
[
https://issues.apache.org/jira/browse/SOLR-13507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877852#comment-16877852
]
Lucene/Solr QA commented on SOLR-13507:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} SOLR-13507 does not apply to master. Rebase required? Wrong
Branch? See
https://wiki.apache.org/solr/HowToContribute#Creating_the_patch_file for help.
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13507 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12971373/SOLR-13507.02.patch |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/478/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint.
> --
>
> Key: SOLR-13507
> URL: https://issues.apache.org/jira/browse/SOLR-13507
> Project: Solr
> Issue Type: Improvement
>Reporter: Anshum Gupta
>Assignee: Anshum Gupta
>Priority: Major
> Attachments: SOLR-13507.02.patch, SOLR-13507.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The addr parameter isn't needed and it should be removed from the code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13507) Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint.
[ https://issues.apache.org/jira/browse/SOLR-13507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877500#comment-16877500 ] Anshum Gupta commented on SOLR-13507: - [~janhoy] - I'm trying out switching to GitHub pull requests instead of the patch files so just being extra cautious. Here's the PR: [https://github.com/apache/lucene-solr/pull/759] (wasn't sure if the PR would get auto tagged here, but seems like that isn't the case). Also, considering this isn't a bug fix, let's only release this with 8.2 and not 8.1.x. wdyt ? > Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint. > -- > > Key: SOLR-13507 > URL: https://issues.apache.org/jira/browse/SOLR-13507 > Project: Solr > Issue Type: Improvement >Reporter: Anshum Gupta >Assignee: Anshum Gupta >Priority: Major > Attachments: SOLR-13507.02.patch, SOLR-13507.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The addr parameter isn't needed and it should be removed from the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13507) Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint.
[ https://issues.apache.org/jira/browse/SOLR-13507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877332#comment-16877332 ] Anshum Gupta commented on SOLR-13507: - Missed the notification about this and then was traveling until yesterday. Thanks for the reminder. I'll commit this tonight. > Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint. > -- > > Key: SOLR-13507 > URL: https://issues.apache.org/jira/browse/SOLR-13507 > Project: Solr > Issue Type: Improvement >Reporter: Anshum Gupta >Assignee: Anshum Gupta >Priority: Major > Attachments: SOLR-13507.02.patch, SOLR-13507.patch > > > The addr parameter isn't needed and it should be removed from the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13507) Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint.
[ https://issues.apache.org/jira/browse/SOLR-13507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877319#comment-16877319 ] Jan Høydahl commented on SOLR-13507: Are you committing this for 8.1.2 & 8.2? > Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint. > -- > > Key: SOLR-13507 > URL: https://issues.apache.org/jira/browse/SOLR-13507 > Project: Solr > Issue Type: Improvement >Reporter: Anshum Gupta >Assignee: Anshum Gupta >Priority: Major > Attachments: SOLR-13507.02.patch, SOLR-13507.patch > > > The addr parameter isn't needed and it should be removed from the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13507) Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint.
[ https://issues.apache.org/jira/browse/SOLR-13507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860377#comment-16860377 ] Jan Høydahl commented on SOLR-13507: Just go ahead, it's all yours :) > Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint. > -- > > Key: SOLR-13507 > URL: https://issues.apache.org/jira/browse/SOLR-13507 > Project: Solr > Issue Type: Improvement >Reporter: Anshum Gupta >Assignee: Anshum Gupta >Priority: Major > Attachments: SOLR-13507.02.patch, SOLR-13507.patch > > > The addr parameter isn't needed and it should be removed from the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13507) Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint.
[ https://issues.apache.org/jira/browse/SOLR-13507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860297#comment-16860297 ] Anshum Gupta commented on SOLR-13507: - [~janhoy] - I've uploaded the patch that you shared earlier and the tests are all passing. I'll commit if if you don't get to it in some time :) > Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint. > -- > > Key: SOLR-13507 > URL: https://issues.apache.org/jira/browse/SOLR-13507 > Project: Solr > Issue Type: Improvement >Reporter: Anshum Gupta >Assignee: Anshum Gupta >Priority: Major > Attachments: SOLR-13507.02.patch, SOLR-13507.patch > > > The addr parameter isn't needed and it should be removed from the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13507) Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint.
[ https://issues.apache.org/jira/browse/SOLR-13507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856934#comment-16856934 ] Erick Erickson commented on SOLR-13507: --- Well, they sure _look_ similar ;). But I think you're right. > Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint. > -- > > Key: SOLR-13507 > URL: https://issues.apache.org/jira/browse/SOLR-13507 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Anshum Gupta >Assignee: Anshum Gupta >Priority: Major > Attachments: SOLR-13507.patch > > > The addr parameter isn't needed and it should be removed from the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13507) Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint.
[ https://issues.apache.org/jira/browse/SOLR-13507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856871#comment-16856871 ] Jan Høydahl commented on SOLR-13507: Hi, I think you confuse this with another issue. In this issue we’ll remove the http parameter “addr” from the /solr/admin/zookeeper endpoint, nothing to do with 4lw > Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint. > -- > > Key: SOLR-13507 > URL: https://issues.apache.org/jira/browse/SOLR-13507 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Anshum Gupta >Assignee: Anshum Gupta >Priority: Major > Attachments: SOLR-13507.patch > > > The addr parameter isn't needed and it should be removed from the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13507) Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint.
[ https://issues.apache.org/jira/browse/SOLR-13507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856818#comment-16856818 ] Erick Erickson commented on SOLR-13507: --- We should probably also add comments to the code to warn devs in future against adding "addr" back in, or specifying "*". NOTE: currently SolrTestCaseJ4 sets this property to "*". I was "iffy" about that. Attached a straw-man patch, could you take it from here? Haven't even tried to compile, but it was faster than explaining ;) > Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint. > -- > > Key: SOLR-13507 > URL: https://issues.apache.org/jira/browse/SOLR-13507 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Anshum Gupta >Assignee: Anshum Gupta >Priority: Major > Attachments: SOLR-13507.patch > > > The addr parameter isn't needed and it should be removed from the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13507) Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint.
[ https://issues.apache.org/jira/browse/SOLR-13507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856799#comment-16856799 ] Anshum Gupta commented on SOLR-13507: - [~erickerickson] - correct, but from a user perspective, let's keep this Jira and mark this as resolved. We can either add this information to the Changelog entry for SOLR-8346, or we can have this as a separate line and explicitly mention the remove of support for "addr". wdyt ? > Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint. > -- > > Key: SOLR-13507 > URL: https://issues.apache.org/jira/browse/SOLR-13507 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Anshum Gupta >Assignee: Anshum Gupta >Priority: Major > > The addr parameter isn't needed and it should be removed from the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13507) Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint.
[ https://issues.apache.org/jira/browse/SOLR-13507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854001#comment-16854001 ] Erick Erickson commented on SOLR-13507: --- As of SOLR-8346, this really becomes "don't add 'addr' to the whitelist", which will be the current state then. The only three 4-letter words added so far are: ruok, conf, and mntr > Remove support for "addr" parameter from the "/solr/admin/zookeeper" endpoint. > -- > > Key: SOLR-13507 > URL: https://issues.apache.org/jira/browse/SOLR-13507 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Anshum Gupta >Assignee: Anshum Gupta >Priority: Major > > The addr parameter isn't needed and it should be removed from the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
