[
https://issues.apache.org/jira/browse/SOLR-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582180#comment-15582180
]
Alexandre Rafalovitch commented on SOLR-1648:
---------------------------------------------
I think the 7-year-old naming decision is here to stay. Close the case until a
real need shows up for this?
> Rename XMLWriter (and XMLResponseWriter) to SolrXmlResponseWriter
> -----------------------------------------------------------------
>
> Key: SOLR-1648
> URL: https://issues.apache.org/jira/browse/SOLR-1648
> Project: Solr
> Issue Type: Improvement
> Components: Response Writers
> Affects Versions: 1.2, 1.3, 1.4
> Environment: My local MacBook pro over the Christmas Break.
> Reporter: Chris A. Mattmann
> Fix For: 4.9, 6.0
>
>
> The current XMLWriter class is kind of a misnomer. It's not a generic
> XMLWriter by any means, and that's not its intention. Its intention is to
> write instances (as responses) of a particular XML schema that SOLR clients
> (written in Java, Python, pick-your-favorite-programming-language) that speak
> its XML protocol can understand. So, we should rename it to
> SolrXmlResponseWriter to indicate its unique XML speak.
> Morever, as part of the next issue I'm going to report (refactoring all
> ResponseWriters to be a bit more friendly), we should probably do away with
> the current XmlResponseWriter (which simply delegates to XmlWriter -- eeep)
> and just stick with SolrXmlResponseWriter. Patch forthcoming.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
