[jira] [Commented] (SOLR-7798) Improve robustness of ExpandComponent

2019-07-26 Thread Michael Gibney (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893958#comment-16893958 ] Michael Gibney commented on SOLR-7798: -- [~joel.bernstein], I circled back to this, and squash-rebased 

[jira] [Commented] (SOLR-7798) Improve robustness of ExpandComponent

2018-02-23 Thread Michael Gibney (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374861#comment-16374861 ] Michael Gibney commented on SOLR-7798: -- Sorry, yes! I see. The test case was from [~joergr]'s patch

[jira] [Commented] (SOLR-7798) Improve robustness of ExpandComponent

2018-02-23 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374513#comment-16374513 ] Joel Bernstein commented on SOLR-7798: -- There were a couple issues I ran into. First I worked with the

[jira] [Commented] (SOLR-7798) Improve robustness of ExpandComponent

2018-02-22 Thread Michael Gibney (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373938#comment-16373938 ] Michael Gibney commented on SOLR-7798: -- It looks like the randomness comes from [Line 58 or

[jira] [Commented] (SOLR-7798) Improve robustness of ExpandComponent

2018-02-22 Thread Michael Gibney (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373889#comment-16373889 ] Michael Gibney commented on SOLR-7798: -- I was able to reproduce an NPE with the above command; but the

[jira] [Commented] (SOLR-7798) Improve robustness of ExpandComponent

2018-02-22 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373618#comment-16373618 ] Joel Bernstein commented on SOLR-7798: -- try: ant test -Dtestcase=TestExpandComponent > Improve

[jira] [Commented] (SOLR-7798) Improve robustness of ExpandComponent

2018-02-22 Thread Michael Gibney (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373489#comment-16373489 ] Michael Gibney commented on SOLR-7798: -- I was indeed developing on master. Which test case is failing

[jira] [Commented] (SOLR-7798) Improve robustness of ExpandComponent

2018-02-22 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373370#comment-16373370 ] Joel Bernstein commented on SOLR-7798: -- The test case is failing for me. What version are you working

[jira] [Commented] (SOLR-7798) Improve robustness of ExpandComponent

2018-02-22 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373246#comment-16373246 ] Joel Bernstein commented on SOLR-7798: -- I've got the branch locally. I'll do a little more reviewing,

[jira] [Commented] (SOLR-7798) Improve robustness of ExpandComponent

2018-02-22 Thread Michael Gibney (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373197#comment-16373197 ] Michael Gibney commented on SOLR-7798: -- Right, sounds good! Thanks for the explanation of the 200

[jira] [Commented] (SOLR-7798) Improve robustness of ExpandComponent

2018-02-22 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373096#comment-16373096 ] Joel Bernstein commented on SOLR-7798: -- Actually there can't be duplicate values in the ordBytes Map,

[jira] [Commented] (SOLR-7798) Improve robustness of ExpandComponent

2018-02-22 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373072#comment-16373072 ] Joel Bernstein commented on SOLR-7798: -- I believe the patch will indeed make things more robust. It

[jira] [Commented] (SOLR-7798) Improve robustness of ExpandComponent

2018-02-22 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373055#comment-16373055 ] Joel Bernstein commented on SOLR-7798: -- Just getting reacquainted with the code. I believe the 200

[jira] [Commented] (SOLR-7798) Improve robustness of ExpandComponent

2018-02-22 Thread Michael Gibney (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372962#comment-16372962 ] Michael Gibney commented on SOLR-7798: -- Thanks, [~joel.bernstein]. I'm happy to prep a PR, but would

[jira] [Commented] (SOLR-7798) Improve robustness of ExpandComponent

2018-02-21 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372251#comment-16372251 ] Joel Bernstein commented on SOLR-7798: -- Thanks for the patch. If you can setup a pull request I should

[jira] [Commented] (SOLR-7798) Improve robustness of ExpandComponent

2018-02-21 Thread Michael Gibney (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371599#comment-16371599 ] Michael Gibney commented on SOLR-7798: -- Although [~joergr]'s initial description mentions an NPE in