[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506475#comment-15506475 ] Jason Gerlowski commented on SOLR-8097: --- I created SOLR-9535 to address the recent co

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15489278#comment-15489278 ] Anshum Gupta commented on SOLR-8097: >From how I'm looking at this, it's a bug really a

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15489273#comment-15489273 ] Anshum Gupta commented on SOLR-8097: I can't recollect right now and I'm not looking at

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15487748#comment-15487748 ] Jason Gerlowski commented on SOLR-8097: --- I'll create a separate issue for changing th

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15485839#comment-15485839 ] Shawn Heisey commented on SOLR-8097: bq. the Builder could be extended instead of exten

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15485554#comment-15485554 ] Anshum Gupta commented on SOLR-8097: Right, we can open up the constructor for subclass

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15485336#comment-15485336 ] Shawn Heisey commented on SOLR-8097: What is your *specific* goal in creating a subclas

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15485083#comment-15485083 ] Perrin Bignoli commented on SOLR-8097: -- What was the result of that discussion? I am

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15484908#comment-15484908 ] Anshum Gupta commented on SOLR-8097: Here's the discussion about that: https://issues.

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1548#comment-1548 ] Perrin Bignoli commented on SOLR-8097: -- Why is the the visibility of the following con

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294070#comment-15294070 ] ASF subversion and git services commented on SOLR-8097: --- Commit 9645d

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280639#comment-15280639 ] Anshum Gupta commented on SOLR-8097: Yes but it was only fixed for 6.1. > Implement a

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280444#comment-15280444 ] Hoss Man commented on SOLR-8097: [~anshumg] - shouldn't this issue be resolved? > Implemen

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237870#comment-15237870 ] Jason Gerlowski commented on SOLR-8097: --- I created SOLR-8975 for this work, with a sh

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237798#comment-15237798 ] Shawn Heisey commented on SOLR-8097: I personally would never change those things after

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237676#comment-15237676 ] Anshum Gupta commented on SOLR-8097: Collection, perhaps yes. But I don't change any of

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237634#comment-15237634 ] Jason Gerlowski commented on SOLR-8097: --- I thought about doing that as a part of my p

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237456#comment-15237456 ] Anshum Gupta commented on SOLR-8097: Sure > Implement a builder pattern for constructi

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237124#comment-15237124 ] Shalin Shekhar Mangar commented on SOLR-8097: - Can we deprecate the various set

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232845#comment-15232845 ] ASF subversion and git services commented on SOLR-8097: --- Commit f479f

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231355#comment-15231355 ] Anshum Gupta commented on SOLR-8097: Thanks Jason and Shawn. I'll commit this to 6x tom

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231325#comment-15231325 ] ASF subversion and git services commented on SOLR-8097: --- Commit b02b0

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228549#comment-15228549 ] Shawn Heisey commented on SOLR-8097: I didn't think of potential naming conflicts. Ful

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228430#comment-15228430 ] Jason Gerlowski commented on SOLR-8097: --- So, I've got an updated patch that does ever

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227369#comment-15227369 ] Anshum Gupta commented on SOLR-8097: from my previous comment: bq. Deprecation to the n

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227338#comment-15227338 ] Shawn Heisey commented on SOLR-8097: Further research on this turns up both methods as

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227291#comment-15227291 ] Shawn Heisey commented on SOLR-8097: We could completely eliminate all the public const

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227044#comment-15227044 ] Anshum Gupta commented on SOLR-8097: Thanks Jason > Implement a builder pattern for co

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227040#comment-15227040 ] Jason Gerlowski commented on SOLR-8097: --- Yep, working on updating the patch now. It

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226950#comment-15226950 ] Anshum Gupta commented on SOLR-8097: I don't think that difficulty in anonymous extensi

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226947#comment-15226947 ] Anshum Gupta commented on SOLR-8097: [~gerlowskija] can you upda > Implement a builder

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207366#comment-15207366 ] Anshum Gupta commented on SOLR-8097: We should not be using deprecated code for anythin

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207360#comment-15207360 ] Jason Gerlowski commented on SOLR-8097: --- I didn't forget, but I was unsure whether th

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207314#comment-15207314 ] Anshum Gupta commented on SOLR-8097: Seems like you forgot to change the usage of depre

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200383#comment-15200383 ] Anshum Gupta commented on SOLR-8097: I'll take a look at this later today. > Implement

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15188773#comment-15188773 ] Anshum Gupta commented on SOLR-8097: Thanks Jason. Looks good overall. * Change maybeC

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179287#comment-15179287 ] Jason Gerlowski commented on SOLR-8097: --- Hmm, still seeing some test failures with th

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176410#comment-15176410 ] Jason Gerlowski commented on SOLR-8097: --- bq. we need to continue testing the current

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176292#comment-15176292 ] Anshum Gupta commented on SOLR-8097: Seems like there's some issue with the patch as it

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176276#comment-15176276 ] Anshum Gupta commented on SOLR-8097: Thanks Jason. Looking at it now. Let's not move al

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170749#comment-15170749 ] Jason Gerlowski commented on SOLR-8097: --- So, looking close at these builder classes,

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170695#comment-15170695 ] Jason Gerlowski commented on SOLR-8097: --- Thanks for the review Anshum. Sorry it took

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170676#comment-15170676 ] Jason Gerlowski commented on SOLR-8097: --- Gonna revert my different name (updateLeader

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157463#comment-15157463 ] Anshum Gupta commented on SOLR-8097: Thanks Hoss. I'll work on adding support for this

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157414#comment-15157414 ] Hoss Man commented on SOLR-8097: I'm guessing mark is remembering SOLR-6312. I don't have

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157403#comment-15157403 ] Mark Miller commented on SOLR-8097: --- Yup, looks like someone just made it default to true

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157394#comment-15157394 ] Anshum Gupta commented on SOLR-8097: Ah ok. I was just looking at the code and it might

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157378#comment-15157378 ] Mark Miller commented on SOLR-8097: --- I don't think you are right. All it does it prefer l

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157365#comment-15157365 ] Anshum Gupta commented on SOLR-8097: I think we should not use 'prefer' as it's not a p

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157357#comment-15157357 ] Mark Miller commented on SOLR-8097: --- bq. updateLeadersOnly If you want to make it more

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157327#comment-15157327 ] Anshum Gupta commented on SOLR-8097: Thanks Jason. This looks good to me, how ever I'm

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15156283#comment-15156283 ] Anshum Gupta commented on SOLR-8097: I'll take a look tomorrow as I'd be away from the

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15156251#comment-15156251 ] Jason Gerlowski commented on SOLR-8097: --- Just wanted to give this issue a little 'bum

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139189#comment-15139189 ] Anshum Gupta commented on SOLR-8097: Thanks for the patch Jason. The patch doesn't appl

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138268#comment-15138268 ] Shawn Heisey commented on SOLR-8097: We get semi-regular questions about EmbeddedSolrSe

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138253#comment-15138253 ] Jason Gerlowski commented on SOLR-8097: --- Looks like the only remaining *Server varian

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138100#comment-15138100 ] Shawn Heisey commented on SOLR-8097: In master (6.0), most of the *Server variants shou

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137983#comment-15137983 ] Jason Gerlowski commented on SOLR-8097: --- Hey Shawn, thanks for the review. I hadn't

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137480#comment-15137480 ] Shawn Heisey commented on SOLR-8097: I like the idea of going with a builder pattern.

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137198#comment-15137198 ] Jason Gerlowski commented on SOLR-8097: --- Hi all, Just wanted to give this issue a li

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091375#comment-15091375 ] Shawn Heisey commented on SOLR-8097: Code written and compiled with a particular versio

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091257#comment-15091257 ] Jason Gerlowski commented on SOLR-8097: --- My comment above implies some questions abou

[jira] [Commented] (SOLR-8097) Implement a builder pattern for constructing a Solrj client

[ https://issues.apache.org/jira/browse/SOLR-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090826#comment-15090826 ] Jason Gerlowski commented on SOLR-8097: --- I'm gonna take a first pass at this. Is the