[jira] [Commented] (SOLR-9545) DataImportHandler throws NPE to logs when pk attribute is not present when delta query is used
[ https://issues.apache.org/jira/browse/SOLR-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15907819#comment-15907819 ] Ishan Chattopadhyaya commented on SOLR-9545: Moving to 6.5, since 6.4 has already been released. > DataImportHandler throws NPE to logs when pk attribute is not present when > delta query is used > -- > > Key: SOLR-9545 > URL: https://issues.apache.org/jira/browse/SOLR-9545 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - DataImportHandler >Affects Versions: 6.2.1 >Reporter: Rafał Kuć >Priority: Minor > Fix For: 6.4, master (7.0) > > Attachments: SOLR-9545.patch > > > Hi, > Currently, when running a delta query from the Data Import Handler and pk > parameter is not specified Solr just logs NullPointerExeception, not > providing any information on what was expected. > Patch coming soon. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9545) DataImportHandler throws NPE to logs when pk attribute is not present when delta query is used
[ https://issues.apache.org/jira/browse/SOLR-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510753#comment-15510753 ] Rafał Kuć commented on SOLR-9545: - Sure, will modify the code and provide a proper patch :) > DataImportHandler throws NPE to logs when pk attribute is not present when > delta query is used > -- > > Key: SOLR-9545 > URL: https://issues.apache.org/jira/browse/SOLR-9545 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - DataImportHandler >Affects Versions: 6.2.1 >Reporter: Rafał Kuć >Priority: Minor > Fix For: 6.3 > > Attachments: SOLR-9545.patch > > > Hi, > Currently, when running a delta query from the Data Import Handler and pk > parameter is not specified Solr just logs NullPointerExeception, not > providing any information on what was expected. > Patch coming soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9545) DataImportHandler throws NPE to logs when pk attribute is not present when delta query is used
[ https://issues.apache.org/jira/browse/SOLR-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510749#comment-15510749 ] Tomás Fernández Löbbe commented on SOLR-9545: - Thanks for the patch [~gro], If I understand correctly, this code is executed when requesting a delta update but a "deltaImportQuery" was not configured, correct? In that case, the exception message is not correct. Also, could you make the exception a SolrException instead of a plain RuntimeException? and ideally add a unit test. > DataImportHandler throws NPE to logs when pk attribute is not present when > delta query is used > -- > > Key: SOLR-9545 > URL: https://issues.apache.org/jira/browse/SOLR-9545 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - DataImportHandler >Affects Versions: 6.2.1 >Reporter: Rafał Kuć >Priority: Minor > Fix For: 6.3 > > Attachments: SOLR-9545.patch > > > Hi, > Currently, when running a delta query from the Data Import Handler and pk > parameter is not specified Solr just logs NullPointerExeception, not > providing any information on what was expected. > Patch coming soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
