[jira] [Commented] (SOLR-9632) Add a deleteAllCollections() method to MiniSolrCloudCluster
[ https://issues.apache.org/jira/browse/SOLR-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585236#comment-15585236 ] ASF subversion and git services commented on SOLR-9632: --- Commit d6dc1321a9010752463ae2a54a0b940e6877b3df in lucene-solr's branch refs/heads/branch_6x from [~romseygeek] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d6dc132 ] SOLR-9632: Add deleteAllCollections method to MiniSolrCloudCluster > Add a deleteAllCollections() method to MiniSolrCloudCluster > --- > > Key: SOLR-9632 > URL: https://issues.apache.org/jira/browse/SOLR-9632 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alan Woodward >Assignee: Alan Woodward > Attachments: SOLR-9632.patch > > > This would make test tearDown easier in lots of places. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9632) Add a deleteAllCollections() method to MiniSolrCloudCluster
[ https://issues.apache.org/jira/browse/SOLR-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585238#comment-15585238 ] ASF subversion and git services commented on SOLR-9632: --- Commit 20ea5355c91e61617d59310ea51ca5cb5383c490 in lucene-solr's branch refs/heads/master from [~romseygeek] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=20ea535 ] SOLR-9632: Add deleteAllCollections method to MiniSolrCloudCluster > Add a deleteAllCollections() method to MiniSolrCloudCluster > --- > > Key: SOLR-9632 > URL: https://issues.apache.org/jira/browse/SOLR-9632 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alan Woodward >Assignee: Alan Woodward > Attachments: SOLR-9632.patch > > > This would make test tearDown easier in lots of places. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9632) Add a deleteAllCollections() method to MiniSolrCloudCluster
[ https://issues.apache.org/jira/browse/SOLR-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568746#comment-15568746 ] Alan Woodward commented on SOLR-9632: - >From the mailing list, re SOLR-9132: [~hossman] wrote: It's not immediately obvious to me why these collection deletions can't be done in an @After method -- but if they need to live in each test method can we at least have an @After method that asserts no collections exist (via a STATUS call) so if someone writes a new test method but forgets to delete that collection then the @After method will catch it and give them a self explanatory failure instead of some future confusing/trappy error that depends on test order or what not? [~romseygeek] wrote: They all have different collection names, which is why we can’t do it in an @After method, but you’re right, it is trappy. How about instead we add a .deleteAllCollections() command to MiniSolrCloudCluster, which will ensure that each test starts up in an empty cluster? > Add a deleteAllCollections() method to MiniSolrCloudCluster > --- > > Key: SOLR-9632 > URL: https://issues.apache.org/jira/browse/SOLR-9632 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alan Woodward >Assignee: Alan Woodward > > This would make test tearDown easier in lots of places. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
