[jira] [Updated] (LUCENE-6908) TestGeoUtils.testGeoRelations is buggy with irregular rectangles
[
https://issues.apache.org/jira/browse/LUCENE-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicholas Knize updated LUCENE-6908:
---
Attachment: LUCENE-6908.patch
Updated patch includes:
* space segmentation for irregular rectangles at the poles
* utility method for computing bearing from two given lat/lon points
* explicitly tested against failed seeds and nightly beasting
* updated javadocs
> TestGeoUtils.testGeoRelations is buggy with irregular rectangles
>
>
> Key: LUCENE-6908
> URL: https://issues.apache.org/jira/browse/LUCENE-6908
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Nicholas Knize
> Attachments: LUCENE-6908.patch, LUCENE-6908.patch, LUCENE-6908.patch,
> LUCENE-6908.patch, LUCENE-6908.patch
>
>
> The {{.testGeoRelations}} method doesn't exactly test the behavior of
> GeoPoint*Query as its using the BKD split technique (instead of quad cell
> division) to divide the space on each pass. For "large" distance queries this
> can create a lot of irregular rectangles producing large radial distortion
> error when using the cartesian approximation methods provided by
> {{GeoUtils}}. This issue improves the accuracy of GeoUtils cartesian
> approximation methods on irregular rectangles without having to cut over to
> an expensive oblate geometry approach.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-6908) TestGeoUtils.testGeoRelations is buggy with irregular rectangles
[
https://issues.apache.org/jira/browse/LUCENE-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicholas Knize updated LUCENE-6908:
---
Attachment: LUCENE-6908.patch
Thanks [~mikemccand]! Fixed the patch to include GeoRelationUtils and changes
to SloppyMath.
> TestGeoUtils.testGeoRelations is buggy with irregular rectangles
>
>
> Key: LUCENE-6908
> URL: https://issues.apache.org/jira/browse/LUCENE-6908
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Nicholas Knize
> Attachments: LUCENE-6908.patch, LUCENE-6908.patch, LUCENE-6908.patch
>
>
> The {{.testGeoRelations}} method doesn't exactly test the behavior of
> GeoPoint*Query as its using the BKD split technique (instead of quad cell
> division) to divide the space on each pass. For "large" distance queries this
> can create a lot of irregular rectangles producing large radial distortion
> error when using the cartesian approximation methods provided by
> {{GeoUtils}}. This issue improves the accuracy of GeoUtils cartesian
> approximation methods on irregular rectangles without having to cut over to
> an expensive oblate geometry approach.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-6908) TestGeoUtils.testGeoRelations is buggy with irregular rectangles
[
https://issues.apache.org/jira/browse/LUCENE-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicholas Knize updated LUCENE-6908:
---
Attachment: LUCENE-6908.patch
Thanks [~mikemccand]. In {{isClosestPointOnRectWithinRange}} it was still using
{{SloppyMath.haversin}} where it should have been using the Sinnott haversine.
Looks like it was caused by a premature diff from my benchmark workspace.
A quick interesting benchmark re: distance methods. Using 2M iterations I
benchmarked average computation time, average spatial error, and maximum
spatial error between 5 different geospatial distance methods:
* Vincenty
* Karney - Modified Vincenty that uses Newton's series expansion to fix
problems w/ antipodal points
* HaverECF - Same as {{SloppyMath.haversin}} but uses ECEF to accurately
compute semi-major axis at the given latitude.
* Sinnott's Haversine - Implementation from the original haversine publicatoin
* SloppyMath
|| Distance Method || Avg Computation (ns) || Avg Error (%) || Max Error (%) ||
| Vincenty | 1286.5529689998828 | 8.4561794778802E-11 | 7.2565793775802E-10 |
| Karney | 31770.47920646 | 8.4561794778802E-11 | 7.2565793775802E-10 |
| HaverECF | 717.113985152 | 0.18409042301798453 | 0.6681179192384695 |
| SloppyMath.haverin | 159.309524995 | 0.22594450803222424 |
0.6539314586426048 |
| Sinnott Haversine | 146.8123669738 | 0.18158435835918563 |
0.4931242857748373 |
I need to run some better descriptive statistics before drawing any
conclusions. At the moment, the discrepancy between {{Sloppymath.haversin}} and
Sinnott's implementation is consistent with the error described in the original
publication (which is where the tolerance of 0.5% originated).
More to come
> TestGeoUtils.testGeoRelations is buggy with irregular rectangles
>
>
> Key: LUCENE-6908
> URL: https://issues.apache.org/jira/browse/LUCENE-6908
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Nicholas Knize
> Attachments: LUCENE-6908.patch, LUCENE-6908.patch, LUCENE-6908.patch,
> LUCENE-6908.patch
>
>
> The {{.testGeoRelations}} method doesn't exactly test the behavior of
> GeoPoint*Query as its using the BKD split technique (instead of quad cell
> division) to divide the space on each pass. For "large" distance queries this
> can create a lot of irregular rectangles producing large radial distortion
> error when using the cartesian approximation methods provided by
> {{GeoUtils}}. This issue improves the accuracy of GeoUtils cartesian
> approximation methods on irregular rectangles without having to cut over to
> an expensive oblate geometry approach.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-6908) TestGeoUtils.testGeoRelations is buggy with irregular rectangles
[
https://issues.apache.org/jira/browse/LUCENE-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicholas Knize updated LUCENE-6908:
---
Attachment: LUCENE-6908.patch
Updated patch includes the following:
* Pushes down approximation fixes to the Geo utility APIs
* Refactors relation logic from {{GeoUtils}} into separate {{GeoRelationUtils}}
class
* Improves GeoDistance pole crossing by re-projecting to Earth Centered Earth
Fixed (ECEF)
* Adds {{approx}} flag to bypass advanced relation logic (useful for
{{GeoPointField}} since approximations are already handled at the grid level
* Removes {{AwaitsFix}} from {{TestGeoUtils.testGeoRelations}}
Next step is to test w/ BKD integration.
> TestGeoUtils.testGeoRelations is buggy with irregular rectangles
>
>
> Key: LUCENE-6908
> URL: https://issues.apache.org/jira/browse/LUCENE-6908
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Nicholas Knize
> Attachments: LUCENE-6908.patch, LUCENE-6908.patch
>
>
> The {{.testGeoRelations}} method doesn't exactly test the behavior of
> GeoPoint*Query as its using the BKD split technique (instead of quad cell
> division) to divide the space on each pass. For "large" distance queries this
> can create a lot of irregular rectangles producing large radial distortion
> error when using the cartesian approximation methods provided by
> {{GeoUtils}}. This issue improves the accuracy of GeoUtils cartesian
> approximation methods on irregular rectangles without having to cut over to
> an expensive oblate geometry approach.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-6908) TestGeoUtils.testGeoRelations is buggy with irregular rectangles
[
https://issues.apache.org/jira/browse/LUCENE-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicholas Knize updated LUCENE-6908:
---
Description: The {{.testGeoRelations}} method doesn't exactly test the
behavior of GeoPoint*Query as its using the BKD split technique (instead of
quad cell division) to divide the space on each pass. For "large" distance
queries this can create a lot of irregular rectangles producing large radial
distortion error when using the cartesian approximation methods provided by
{{GeoUtils}}. This issue improves the accuracy of GeoUtils cartesian
approximation methods on irregular rectangles without having to cut over to an
expensive oblate geometry approach. (was: The {{.testGeoRelations}} method
doesn't exactly test the behavior of GeoPoint*Query as its using the BKD split
technique (instead of quad cell division) to divide the space on each pass. For
"large" distance queries this can create a lot of irregular rectangles
producing large radial distortion error when using the cartesian approximation
methods provided by {{GeoUtils}}. This issue will better divide the space
enabling use of the fast cartesian approximation methods instead of having to
convert to an expensive oblate geometry approach.)
> TestGeoUtils.testGeoRelations is buggy with irregular rectangles
>
>
> Key: LUCENE-6908
> URL: https://issues.apache.org/jira/browse/LUCENE-6908
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Nicholas Knize
> Attachments: LUCENE-6908.patch
>
>
> The {{.testGeoRelations}} method doesn't exactly test the behavior of
> GeoPoint*Query as its using the BKD split technique (instead of quad cell
> division) to divide the space on each pass. For "large" distance queries this
> can create a lot of irregular rectangles producing large radial distortion
> error when using the cartesian approximation methods provided by
> {{GeoUtils}}. This issue improves the accuracy of GeoUtils cartesian
> approximation methods on irregular rectangles without having to cut over to
> an expensive oblate geometry approach.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-6908) TestGeoUtils.testGeoRelations is buggy with irregular rectangles
[
https://issues.apache.org/jira/browse/LUCENE-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicholas Knize updated LUCENE-6908:
---
Attachment: LUCENE-6908.patch
Patch includes:
* update {{testGeoRelations}} to rewrite longitudinal span queries into 4
slices to reduce radial distortion error in {{GeoUtils}} cartesian
approximation methods - this would be needed for BKD queries due to the nature
of the split algorithm for large distance queries.
* Incorporate distance error on {{isClosestPointOnRectWIthinRange}} for better
approximation within BKD.
* added comments and javadocs.
> TestGeoUtils.testGeoRelations is buggy with irregular rectangles
>
>
> Key: LUCENE-6908
> URL: https://issues.apache.org/jira/browse/LUCENE-6908
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Nicholas Knize
> Attachments: LUCENE-6908.patch
>
>
> The {{.testGeoRelations}} method doesn't exactly test the behavior of
> GeoPoint*Query as its using the BKD split technique (instead of quad cell
> division) to divide the space on each pass. For "large" distance queries this
> can create a lot of irregular rectangles producing large radial distortion
> error when using the cartesian approximation methods provided by
> {{GeoUtils}}. This issue will better divide the space enabling use of the
> fast cartesian approximation methods instead of having to convert to an
> expensive oblate geometry approach.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
