[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: LUCENE-7906-Generator_update.patch Hi [~daddywri], I have realized there is something no correct in the random shape generator. Currently it is only building shapes in a portion of the planet! (lat and lon between 0 and 1) Attached is the fix to build shapes in the whole planet. I "beasted" the test and there were no surpises and performance seems to improve. > Spatial relationship between Geoshapes > -- > > Key: LUCENE-7906 > URL: https://issues.apache.org/jira/browse/LUCENE-7906 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7906-AreaShape.patch, > LUCENE-7906-Generator_update.patch, LUCENE-7906.patch, > LUCENE-7906-test.patch, LUCENE-7906-test.patch, LUCENE-7906-test.patch, > test-degenerate_point.patch > > > Hi, > Working with geosahpes and trying to resolve spatial relationships between > them I came accross a big limitation when trying to solve the relationship > between two geopolygons. This object does not expose the internal structure. > In particular at some point, it is necessary to check if one polygon > intersects the edges of the other polygon which currently is not possible as > edges are not exposed. > To be able to perform such operation it can be several options. The ones I > can think of are: > 1) Expose the edges of the polygon ( and probably the notable points for the > edges) adding getters in the GeoPolygon interface. Easy to implement and > leave users the responsability of coding the spatial relationship. > 2) Extends GeoPolygon interface to extends geoarea and leave the object make > the spatial relationship. > 3) Extends GeoShape interface so all shapes can infer the spatial > relationship with other GeoShapes. > I might be bias as my interest is in 2d Shapes in the unit sphere and there > might be some cases which what I propose cannot be implemented or are againts > the aim of the library. > What do you think? > Cheers, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: LUCENE-7906-test.patch I have recreated the patch from scratch and it is generated using plain git command. This should work. sorry again! > Spatial relationship between Geoshapes > -- > > Key: LUCENE-7906 > URL: https://issues.apache.org/jira/browse/LUCENE-7906 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7906-AreaShape.patch, LUCENE-7906.patch, > LUCENE-7906-test.patch, LUCENE-7906-test.patch, LUCENE-7906-test.patch, > test-degenerate_point.patch > > > Hi, > Working with geosahpes and trying to resolve spatial relationships between > them I came accross a big limitation when trying to solve the relationship > between two geopolygons. This object does not expose the internal structure. > In particular at some point, it is necessary to check if one polygon > intersects the edges of the other polygon which currently is not possible as > edges are not exposed. > To be able to perform such operation it can be several options. The ones I > can think of are: > 1) Expose the edges of the polygon ( and probably the notable points for the > edges) adding getters in the GeoPolygon interface. Easy to implement and > leave users the responsability of coding the spatial relationship. > 2) Extends GeoPolygon interface to extends geoarea and leave the object make > the spatial relationship. > 3) Extends GeoShape interface so all shapes can infer the spatial > relationship with other GeoShapes. > I might be bias as my interest is in 2d Shapes in the unit sphere and there > might be some cases which what I propose cannot be implemented or are againts > the aim of the library. > What do you think? > Cheers, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: LUCENE-7906-test.patch sorry about this [~kwri...@metacarta.com], I have the feeling I generated the patch and the project was not clean. Attached a new version, I hope this work. Thanks! > Spatial relationship between Geoshapes > -- > > Key: LUCENE-7906 > URL: https://issues.apache.org/jira/browse/LUCENE-7906 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7906-AreaShape.patch, LUCENE-7906.patch, > LUCENE-7906-test.patch, LUCENE-7906-test.patch, test-degenerate_point.patch > > > Hi, > Working with geosahpes and trying to resolve spatial relationships between > them I came accross a big limitation when trying to solve the relationship > between two geopolygons. This object does not expose the internal structure. > In particular at some point, it is necessary to check if one polygon > intersects the edges of the other polygon which currently is not possible as > edges are not exposed. > To be able to perform such operation it can be several options. The ones I > can think of are: > 1) Expose the edges of the polygon ( and probably the notable points for the > edges) adding getters in the GeoPolygon interface. Easy to implement and > leave users the responsability of coding the spatial relationship. > 2) Extends GeoPolygon interface to extends geoarea and leave the object make > the spatial relationship. > 3) Extends GeoShape interface so all shapes can infer the spatial > relationship with other GeoShapes. > I might be bias as my interest is in 2d Shapes in the unit sphere and there > might be some cases which what I propose cannot be implemented or are againts > the aim of the library. > What do you think? > Cheers, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: LUCENE-7906-test.patch Hi [~kwri...@metacarta.com], I attach a new version of the random shape generator class. I think it belongs to this ticket. Main changes are: * Rename the class to "Geo3d" * Added two new shapes, GeoPointShape and degenerate path. * Improve test by providing feedback in case they fail I "beasted" the test and run precommit successfully. Thanks! > Spatial relationship between Geoshapes > -- > > Key: LUCENE-7906 > URL: https://issues.apache.org/jira/browse/LUCENE-7906 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7906-AreaShape.patch, LUCENE-7906.patch, > LUCENE-7906-test.patch, test-degenerate_point.patch > > > Hi, > Working with geosahpes and trying to resolve spatial relationships between > them I came accross a big limitation when trying to solve the relationship > between two geopolygons. This object does not expose the internal structure. > In particular at some point, it is necessary to check if one polygon > intersects the edges of the other polygon which currently is not possible as > edges are not exposed. > To be able to perform such operation it can be several options. The ones I > can think of are: > 1) Expose the edges of the polygon ( and probably the notable points for the > edges) adding getters in the GeoPolygon interface. Easy to implement and > leave users the responsability of coding the spatial relationship. > 2) Extends GeoPolygon interface to extends geoarea and leave the object make > the spatial relationship. > 3) Extends GeoShape interface so all shapes can infer the spatial > relationship with other GeoShapes. > I might be bias as my interest is in 2d Shapes in the unit sphere and there > might be some cases which what I propose cannot be implemented or are againts > the aim of the library. > What do you think? > Cheers, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: test-degenerate_point.patch I think I found an issue with degenerate geopoints. If the degenerate Geopoint lays on the boundary of a shape, the relationships between the objects are not symetrical: The bounding box thinks it contains the degenerated point. The degenerated point thinks it intersects the shape. Not sure what is the right answer: If the answer is WITHIN/CONTAINS: Method intersects(Plane plane, ) should always return false. If the answer is OVERLAPS/OVERLAPS: Method intersects(GeoShape geoShape) should pass a plane for a degenerated GeoPoint. In this case I think we should consider creating a Geoshape containing a point and the plane. Thanks, I. > Spatial relationship between Geoshapes > -- > > Key: LUCENE-7906 > URL: https://issues.apache.org/jira/browse/LUCENE-7906 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7906-AreaShape.patch, LUCENE-7906.patch, > test-degenerate_point.patch > > > Hi, > Working with geosahpes and trying to resolve spatial relationships between > them I came accross a big limitation when trying to solve the relationship > between two geopolygons. This object does not expose the internal structure. > In particular at some point, it is necessary to check if one polygon > intersects the edges of the other polygon which currently is not possible as > edges are not exposed. > To be able to perform such operation it can be several options. The ones I > can think of are: > 1) Expose the edges of the polygon ( and probably the notable points for the > edges) adding getters in the GeoPolygon interface. Easy to implement and > leave users the responsability of coding the spatial relationship. > 2) Extends GeoPolygon interface to extends geoarea and leave the object make > the spatial relationship. > 3) Extends GeoShape interface so all shapes can infer the spatial > relationship with other GeoShapes. > I might be bias as my interest is in 2d Shapes in the unit sphere and there > might be some cases which what I propose cannot be implemented or are againts > the aim of the library. > What do you think? > Cheers, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: LUCENE-7906-AreaShape.patch Attached a new version. The compiler warnings should be gone now. I lower the iterations so the complete suit typically runs in ~30 sec. The slower test in the new suite is the contains because sometimes it takes a few seconds to find the right shape. you can control iteration under the class RandomGeoShapeRelationshipTest. At the moment is set to 5 except for contains which is not repeated. > Spatial relationship between Geoshapes > -- > > Key: LUCENE-7906 > URL: https://issues.apache.org/jira/browse/LUCENE-7906 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7906-AreaShape.patch, LUCENE-7906.patch > > > Hi, > Working with geosahpes and trying to resolve spatial relationships between > them I came accross a big limitation when trying to solve the relationship > between two geopolygons. This object does not expose the internal structure. > In particular at some point, it is necessary to check if one polygon > intersects the edges of the other polygon which currently is not possible as > edges are not exposed. > To be able to perform such operation it can be several options. The ones I > can think of are: > 1) Expose the edges of the polygon ( and probably the notable points for the > edges) adding getters in the GeoPolygon interface. Easy to implement and > leave users the responsability of coding the spatial relationship. > 2) Extends GeoPolygon interface to extends geoarea and leave the object make > the spatial relationship. > 3) Extends GeoShape interface so all shapes can infer the spatial > relationship with other GeoShapes. > I might be bias as my interest is in 2d Shapes in the unit sphere and there > might be some cases which what I propose cannot be implemented or are againts > the aim of the library. > What do you think? > Cheers, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: (was: LUCENE-7906-AreaShape.patch) > Spatial relationship between Geoshapes > -- > > Key: LUCENE-7906 > URL: https://issues.apache.org/jira/browse/LUCENE-7906 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7906-AreaShape.patch, LUCENE-7906.patch > > > Hi, > Working with geosahpes and trying to resolve spatial relationships between > them I came accross a big limitation when trying to solve the relationship > between two geopolygons. This object does not expose the internal structure. > In particular at some point, it is necessary to check if one polygon > intersects the edges of the other polygon which currently is not possible as > edges are not exposed. > To be able to perform such operation it can be several options. The ones I > can think of are: > 1) Expose the edges of the polygon ( and probably the notable points for the > edges) adding getters in the GeoPolygon interface. Easy to implement and > leave users the responsability of coding the spatial relationship. > 2) Extends GeoPolygon interface to extends geoarea and leave the object make > the spatial relationship. > 3) Extends GeoShape interface so all shapes can infer the spatial > relationship with other GeoShapes. > I might be bias as my interest is in 2d Shapes in the unit sphere and there > might be some cases which what I propose cannot be implemented or are againts > the aim of the library. > What do you think? > Cheers, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: LUCENE-7906-AreaShape.patch Hi [~daddywri], Attached is a new Patch with the new proposed interface GeoAreaShape. It was trivial to add this new interface for existing Shapes. I created a new composite for GeoAreaShape and use it as the base class for GeoCompositePolygon. > Spatial relationship between Geoshapes > -- > > Key: LUCENE-7906 > URL: https://issues.apache.org/jira/browse/LUCENE-7906 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7906-AreaShape.patch, LUCENE-7906.patch > > > Hi, > Working with geosahpes and trying to resolve spatial relationships between > them I came accross a big limitation when trying to solve the relationship > between two geopolygons. This object does not expose the internal structure. > In particular at some point, it is necessary to check if one polygon > intersects the edges of the other polygon which currently is not possible as > edges are not exposed. > To be able to perform such operation it can be several options. The ones I > can think of are: > 1) Expose the edges of the polygon ( and probably the notable points for the > edges) adding getters in the GeoPolygon interface. Easy to implement and > leave users the responsability of coding the spatial relationship. > 2) Extends GeoPolygon interface to extends geoarea and leave the object make > the spatial relationship. > 3) Extends GeoShape interface so all shapes can infer the spatial > relationship with other GeoShapes. > I might be bias as my interest is in 2d Shapes in the unit sphere and there > might be some cases which what I propose cannot be implemented or are againts > the aim of the library. > What do you think? > Cheers, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: LUCENE-7906.patch > Spatial relationship between Geoshapes > -- > > Key: LUCENE-7906 > URL: https://issues.apache.org/jira/browse/LUCENE-7906 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7906.patch > > > Hi, > Working with geosahpes and trying to resolve spatial relationships between > them I came accross a big limitation when trying to solve the relationship > between two geopolygons. This object does not expose the internal structure. > In particular at some point, it is necessary to check if one polygon > intersects the edges of the other polygon which currently is not possible as > edges are not exposed. > To be able to perform such operation it can be several options. The ones I > can think of are: > 1) Expose the edges of the polygon ( and probably the notable points for the > edges) adding getters in the GeoPolygon interface. Easy to implement and > leave users the responsability of coding the spatial relationship. > 2) Extends GeoPolygon interface to extends geoarea and leave the object make > the spatial relationship. > 3) Extends GeoShape interface so all shapes can infer the spatial > relationship with other GeoShapes. > I might be bias as my interest is in 2d Shapes in the unit sphere and there > might be some cases which what I propose cannot be implemented or are againts > the aim of the library. > What do you think? > Cheers, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: (was: LUCENE-7906.patch) > Spatial relationship between Geoshapes > -- > > Key: LUCENE-7906 > URL: https://issues.apache.org/jira/browse/LUCENE-7906 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7906.patch > > > Hi, > Working with geosahpes and trying to resolve spatial relationships between > them I came accross a big limitation when trying to solve the relationship > between two geopolygons. This object does not expose the internal structure. > In particular at some point, it is necessary to check if one polygon > intersects the edges of the other polygon which currently is not possible as > edges are not exposed. > To be able to perform such operation it can be several options. The ones I > can think of are: > 1) Expose the edges of the polygon ( and probably the notable points for the > edges) adding getters in the GeoPolygon interface. Easy to implement and > leave users the responsability of coding the spatial relationship. > 2) Extends GeoPolygon interface to extends geoarea and leave the object make > the spatial relationship. > 3) Extends GeoShape interface so all shapes can infer the spatial > relationship with other GeoShapes. > I might be bias as my interest is in 2d Shapes in the unit sphere and there > might be some cases which what I propose cannot be implemented or are againts > the aim of the library. > What do you think? > Cheers, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: (was: LUCENE-7906.patch) > Spatial relationship between Geoshapes > -- > > Key: LUCENE-7906 > URL: https://issues.apache.org/jira/browse/LUCENE-7906 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7906.patch > > > Hi, > Working with geosahpes and trying to resolve spatial relationships between > them I came accross a big limitation when trying to solve the relationship > between two geopolygons. This object does not expose the internal structure. > In particular at some point, it is necessary to check if one polygon > intersects the edges of the other polygon which currently is not possible as > edges are not exposed. > To be able to perform such operation it can be several options. The ones I > can think of are: > 1) Expose the edges of the polygon ( and probably the notable points for the > edges) adding getters in the GeoPolygon interface. Easy to implement and > leave users the responsability of coding the spatial relationship. > 2) Extends GeoPolygon interface to extends geoarea and leave the object make > the spatial relationship. > 3) Extends GeoShape interface so all shapes can infer the spatial > relationship with other GeoShapes. > I might be bias as my interest is in 2d Shapes in the unit sphere and there > might be some cases which what I propose cannot be implemented or are againts > the aim of the library. > What do you think? > Cheers, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: LUCENE-7906.patch Move the getRelationship method down to the GeoBasePolygon. > Spatial relationship between Geoshapes > -- > > Key: LUCENE-7906 > URL: https://issues.apache.org/jira/browse/LUCENE-7906 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7906.patch, LUCENE-7906.patch > > > Hi, > Working with geosahpes and trying to resolve spatial relationships between > them I came accross a big limitation when trying to solve the relationship > between two geopolygons. This object does not expose the internal structure. > In particular at some point, it is necessary to check if one polygon > intersects the edges of the other polygon which currently is not possible as > edges are not exposed. > To be able to perform such operation it can be several options. The ones I > can think of are: > 1) Expose the edges of the polygon ( and probably the notable points for the > edges) adding getters in the GeoPolygon interface. Easy to implement and > leave users the responsability of coding the spatial relationship. > 2) Extends GeoPolygon interface to extends geoarea and leave the object make > the spatial relationship. > 3) Extends GeoShape interface so all shapes can infer the spatial > relationship with other GeoShapes. > I might be bias as my interest is in 2d Shapes in the unit sphere and there > might be some cases which what I propose cannot be implemented or are againts > the aim of the library. > What do you think? > Cheers, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: (was: LUCENE-7906.patch) > Spatial relationship between Geoshapes > -- > > Key: LUCENE-7906 > URL: https://issues.apache.org/jira/browse/LUCENE-7906 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7906.patch > > > Hi, > Working with geosahpes and trying to resolve spatial relationships between > them I came accross a big limitation when trying to solve the relationship > between two geopolygons. This object does not expose the internal structure. > In particular at some point, it is necessary to check if one polygon > intersects the edges of the other polygon which currently is not possible as > edges are not exposed. > To be able to perform such operation it can be several options. The ones I > can think of are: > 1) Expose the edges of the polygon ( and probably the notable points for the > edges) adding getters in the GeoPolygon interface. Easy to implement and > leave users the responsability of coding the spatial relationship. > 2) Extends GeoPolygon interface to extends geoarea and leave the object make > the spatial relationship. > 3) Extends GeoShape interface so all shapes can infer the spatial > relationship with other GeoShapes. > I might be bias as my interest is in 2d Shapes in the unit sphere and there > might be some cases which what I propose cannot be implemented or are againts > the aim of the library. > What do you think? > Cheers, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: LUCENE-7906.patch Yes, you are right. I fixed the spelling mistake and improve coding style. > Spatial relationship between Geoshapes > -- > > Key: LUCENE-7906 > URL: https://issues.apache.org/jira/browse/LUCENE-7906 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7906.patch, LUCENE-7906.patch > > > Hi, > Working with geosahpes and trying to resolve spatial relationships between > them I came accross a big limitation when trying to solve the relationship > between two geopolygons. This object does not expose the internal structure. > In particular at some point, it is necessary to check if one polygon > intersects the edges of the other polygon which currently is not possible as > edges are not exposed. > To be able to perform such operation it can be several options. The ones I > can think of are: > 1) Expose the edges of the polygon ( and probably the notable points for the > edges) adding getters in the GeoPolygon interface. Easy to implement and > leave users the responsability of coding the spatial relationship. > 2) Extends GeoPolygon interface to extends geoarea and leave the object make > the spatial relationship. > 3) Extends GeoShape interface so all shapes can infer the spatial > relationship with other GeoShapes. > I might be bias as my interest is in 2d Shapes in the unit sphere and there > might be some cases which what I propose cannot be implemented or are againts > the aim of the library. > What do you think? > Cheers, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: (was: LUCENE-7906.patch) > Spatial relationship between Geoshapes > -- > > Key: LUCENE-7906 > URL: https://issues.apache.org/jira/browse/LUCENE-7906 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7906.patch > > > Hi, > Working with geosahpes and trying to resolve spatial relationships between > them I came accross a big limitation when trying to solve the relationship > between two geopolygons. This object does not expose the internal structure. > In particular at some point, it is necessary to check if one polygon > intersects the edges of the other polygon which currently is not possible as > edges are not exposed. > To be able to perform such operation it can be several options. The ones I > can think of are: > 1) Expose the edges of the polygon ( and probably the notable points for the > edges) adding getters in the GeoPolygon interface. Easy to implement and > leave users the responsability of coding the spatial relationship. > 2) Extends GeoPolygon interface to extends geoarea and leave the object make > the spatial relationship. > 3) Extends GeoShape interface so all shapes can infer the spatial > relationship with other GeoShapes. > I might be bias as my interest is in 2d Shapes in the unit sphere and there > might be some cases which what I propose cannot be implemented or are againts > the aim of the library. > What do you think? > Cheers, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: LUCENE-7906.patch Yes, adding a new interface method to the polygon interface does the trick. I have added the method GeoPolygon.intersects(Geshape geoshape) and it is working as expected. Patch attached > Spatial relationship between Geoshapes > -- > > Key: LUCENE-7906 > URL: https://issues.apache.org/jira/browse/LUCENE-7906 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7906.patch > > > Hi, > Working with geosahpes and trying to resolve spatial relationships between > them I came accross a big limitation when trying to solve the relationship > between two geopolygons. This object does not expose the internal structure. > In particular at some point, it is necessary to check if one polygon > intersects the edges of the other polygon which currently is not possible as > edges are not exposed. > To be able to perform such operation it can be several options. The ones I > can think of are: > 1) Expose the edges of the polygon ( and probably the notable points for the > edges) adding getters in the GeoPolygon interface. Easy to implement and > leave users the responsability of coding the spatial relationship. > 2) Extends GeoPolygon interface to extends geoarea and leave the object make > the spatial relationship. > 3) Extends GeoShape interface so all shapes can infer the spatial > relationship with other GeoShapes. > I might be bias as my interest is in 2d Shapes in the unit sphere and there > might be some cases which what I propose cannot be implemented or are againts > the aim of the library. > What do you think? > Cheers, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: (was: LUCENE-7906-test.patch) > Spatial relationship between Geoshapes > -- > > Key: LUCENE-7906 > URL: https://issues.apache.org/jira/browse/LUCENE-7906 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7906.patch > > > Hi, > Working with geosahpes and trying to resolve spatial relationships between > them I came accross a big limitation when trying to solve the relationship > between two geopolygons. This object does not expose the internal structure. > In particular at some point, it is necessary to check if one polygon > intersects the edges of the other polygon which currently is not possible as > edges are not exposed. > To be able to perform such operation it can be several options. The ones I > can think of are: > 1) Expose the edges of the polygon ( and probably the notable points for the > edges) adding getters in the GeoPolygon interface. Easy to implement and > leave users the responsability of coding the spatial relationship. > 2) Extends GeoPolygon interface to extends geoarea and leave the object make > the spatial relationship. > 3) Extends GeoShape interface so all shapes can infer the spatial > relationship with other GeoShapes. > I might be bias as my interest is in 2d Shapes in the unit sphere and there > might be some cases which what I propose cannot be implemented or are againts > the aim of the library. > What do you think? > Cheers, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: (was: LUCENE-7906-test.patch) > Spatial relationship between Geoshapes > -- > > Key: LUCENE-7906 > URL: https://issues.apache.org/jira/browse/LUCENE-7906 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7906.patch, LUCENE-7906-test.patch > > > Hi, > Working with geosahpes and trying to resolve spatial relationships between > them I came accross a big limitation when trying to solve the relationship > between two geopolygons. This object does not expose the internal structure. > In particular at some point, it is necessary to check if one polygon > intersects the edges of the other polygon which currently is not possible as > edges are not exposed. > To be able to perform such operation it can be several options. The ones I > can think of are: > 1) Expose the edges of the polygon ( and probably the notable points for the > edges) adding getters in the GeoPolygon interface. Easy to implement and > leave users the responsability of coding the spatial relationship. > 2) Extends GeoPolygon interface to extends geoarea and leave the object make > the spatial relationship. > 3) Extends GeoShape interface so all shapes can infer the spatial > relationship with other GeoShapes. > I might be bias as my interest is in 2d Shapes in the unit sphere and there > might be some cases which what I propose cannot be implemented or are againts > the aim of the library. > What do you think? > Cheers, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: LUCENE-7906-test.patch > Spatial relationship between Geoshapes > -- > > Key: LUCENE-7906 > URL: https://issues.apache.org/jira/browse/LUCENE-7906 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7906.patch, LUCENE-7906-test.patch > > > Hi, > Working with geosahpes and trying to resolve spatial relationships between > them I came accross a big limitation when trying to solve the relationship > between two geopolygons. This object does not expose the internal structure. > In particular at some point, it is necessary to check if one polygon > intersects the edges of the other polygon which currently is not possible as > edges are not exposed. > To be able to perform such operation it can be several options. The ones I > can think of are: > 1) Expose the edges of the polygon ( and probably the notable points for the > edges) adding getters in the GeoPolygon interface. Easy to implement and > leave users the responsability of coding the spatial relationship. > 2) Extends GeoPolygon interface to extends geoarea and leave the object make > the spatial relationship. > 3) Extends GeoShape interface so all shapes can infer the spatial > relationship with other GeoShapes. > I might be bias as my interest is in 2d Shapes in the unit sphere and there > might be some cases which what I propose cannot be implemented or are againts > the aim of the library. > What do you think? > Cheers, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-7906) Spatial relationship between Geoshapes
[ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-7906: - Attachment: LUCENE-7906.patch LUCENE-7906-test.patch Hi [~daddywri], Attached is the patches implementing GeoArea for polygons. I provide extended testing, Some notes: a) I have to modified the method getEdgePoints() from GeoCompositeMembershipShape. It ewas returning only the edge points for the first shape which seems incorrect. My implementation is not very efficient but works. b)To be able able to bound the intersection of convex polygons I create the conves counter part. Maybe there is more efficient way of doing that. c) Would it be worthy to push the geoArea interface down to GeoShape? Cheers, I. > Spatial relationship between Geoshapes > -- > > Key: LUCENE-7906 > URL: https://issues.apache.org/jira/browse/LUCENE-7906 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d >Reporter: Ignacio Vera >Assignee: Karl Wright > Attachments: LUCENE-7906.patch, LUCENE-7906-test.patch > > > Hi, > Working with geosahpes and trying to resolve spatial relationships between > them I came accross a big limitation when trying to solve the relationship > between two geopolygons. This object does not expose the internal structure. > In particular at some point, it is necessary to check if one polygon > intersects the edges of the other polygon which currently is not possible as > edges are not exposed. > To be able to perform such operation it can be several options. The ones I > can think of are: > 1) Expose the edges of the polygon ( and probably the notable points for the > edges) adding getters in the GeoPolygon interface. Easy to implement and > leave users the responsability of coding the spatial relationship. > 2) Extends GeoPolygon interface to extends geoarea and leave the object make > the spatial relationship. > 3) Extends GeoShape interface so all shapes can infer the spatial > relationship with other GeoShapes. > I might be bias as my interest is in 2d Shapes in the unit sphere and there > might be some cases which what I propose cannot be implemented or are againts > the aim of the library. > What do you think? > Cheers, > Ignacio -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
