[jira] [Updated] (SOLR-10114) child documents lack _version_, susceptible to reordered delete-by-query
[
https://issues.apache.org/jira/browse/SOLR-10114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mano Kovacs updated SOLR-10114:
---
Attachment: SOLR-10114-2.patch
Attaching second patch with more tests. First patch was missing a commit.
Includes additional tests in {{PeerSyncTest.java}}, also made every branch of
the test running, instead of randomization.
This includes the test-cleanup patch too.
> child documents lack _version_, susceptible to reordered delete-by-query
> -
>
> Key: SOLR-10114
> URL: https://issues.apache.org/jira/browse/SOLR-10114
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 4.5
>Reporter: Yonik Seeley
>Assignee: Yonik Seeley
> Fix For: master (7.0)
>
> Attachments: SOLR-10114-2.patch, SOLR-10114.patch, SOLR-10114.patch,
> SOLR-10114-test-cleanup.patch, SOLR-10114-validation.patch
>
>
> It looks like when a block of documents is indexed, child documents get no
> \_version\_ field. This means (among other potential issues) that a
> delete-by-query that is reordered will cause matching child documents to be
> deleted. DBQ normally prevents deleting newer docs by including a
> restriction on \_version\_, which doesn't work for anything lacking that
> field. Re-ordered delete-by-term of any child docs would also be affected
> (although it should be a much rarer issue.)
> The leading candidate for a fix is to use the exact same \_version\_ for all
> child docs.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10114) child documents lack _version_, susceptible to reordered delete-by-query
[ https://issues.apache.org/jira/browse/SOLR-10114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mano Kovacs updated SOLR-10114: --- Attachment: SOLR-10114-test-cleanup.patch Failed to upload the latest patch yesterday, attaching cleanup patch. > child documents lack _version_, susceptible to reordered delete-by-query > - > > Key: SOLR-10114 > URL: https://issues.apache.org/jira/browse/SOLR-10114 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 4.5 >Reporter: Yonik Seeley >Assignee: Yonik Seeley > Fix For: master (7.0) > > Attachments: SOLR-10114.patch, SOLR-10114.patch, > SOLR-10114-test-cleanup.patch, SOLR-10114-validation.patch > > > It looks like when a block of documents is indexed, child documents get no > \_version\_ field. This means (among other potential issues) that a > delete-by-query that is reordered will cause matching child documents to be > deleted. DBQ normally prevents deleting newer docs by including a > restriction on \_version\_, which doesn't work for anything lacking that > field. Re-ordered delete-by-term of any child docs would also be affected > (although it should be a much rarer issue.) > The leading candidate for a fix is to use the exact same \_version\_ for all > child docs. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10114) child documents lack _version_, susceptible to reordered delete-by-query
[ https://issues.apache.org/jira/browse/SOLR-10114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley updated SOLR-10114: Affects Version/s: 4.5 > child documents lack _version_, susceptible to reordered delete-by-query > - > > Key: SOLR-10114 > URL: https://issues.apache.org/jira/browse/SOLR-10114 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 4.5 >Reporter: Yonik Seeley >Assignee: Yonik Seeley > Fix For: master (7.0) > > Attachments: SOLR-10114.patch, SOLR-10114.patch, > SOLR-10114-validation.patch > > > It looks like when a block of documents is indexed, child documents get no > \_version\_ field. This means (among other potential issues) that a > delete-by-query that is reordered will cause matching child documents to be > deleted. DBQ normally prevents deleting newer docs by including a > restriction on \_version\_, which doesn't work for anything lacking that > field. Re-ordered delete-by-term of any child docs would also be affected > (although it should be a much rarer issue.) > The leading candidate for a fix is to use the exact same \_version\_ for all > child docs. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10114) child documents lack _version_, susceptible to reordered delete-by-query
[
https://issues.apache.org/jira/browse/SOLR-10114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mano Kovacs updated SOLR-10114:
---
Attachment: SOLR-10114.patch
Using {{ThrowingRunnable}} in tests.
> child documents lack _version_, susceptible to reordered delete-by-query
> -
>
> Key: SOLR-10114
> URL: https://issues.apache.org/jira/browse/SOLR-10114
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Yonik Seeley
> Attachments: SOLR-10114.patch, SOLR-10114.patch,
> SOLR-10114-validation.patch
>
>
> It looks like when a block of documents is indexed, child documents get no
> \_version\_ field. This means (among other potential issues) that a
> delete-by-query that is reordered will cause matching child documents to be
> deleted. DBQ normally prevents deleting newer docs by including a
> restriction on \_version\_, which doesn't work for anything lacking that
> field. Re-ordered delete-by-term of any child docs would also be affected
> (although it should be a much rarer issue.)
> The leading candidate for a fix is to use the exact same \_version\_ for all
> child docs.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10114) child documents lack _version_, susceptible to reordered delete-by-query
[ https://issues.apache.org/jira/browse/SOLR-10114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mano Kovacs updated SOLR-10114: --- Attachment: SOLR-10114.patch Adding patch with - fix by adding version for childdocs if there is - fix by using same insert-or-update logic when handling reordered DBQ - recovery and peersync tests. > child documents lack _version_, susceptible to reordered delete-by-query > - > > Key: SOLR-10114 > URL: https://issues.apache.org/jira/browse/SOLR-10114 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Yonik Seeley > Attachments: SOLR-10114.patch, SOLR-10114-validation.patch > > > It looks like when a block of documents is indexed, child documents get no > \_version\_ field. This means (among other potential issues) that a > delete-by-query that is reordered will cause matching child documents to be > deleted. DBQ normally prevents deleting newer docs by including a > restriction on \_version\_, which doesn't work for anything lacking that > field. Re-ordered delete-by-term of any child docs would also be affected > (although it should be a much rarer issue.) > The leading candidate for a fix is to use the exact same \_version\_ for all > child docs. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10114) child documents lack _version_, susceptible to reordered delete-by-query
[ https://issues.apache.org/jira/browse/SOLR-10114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mano Kovacs updated SOLR-10114: --- Attachment: SOLR-10114-validation.patch Adding SOLR-10114-validation.patch with 4 new tests, 3 of them are failing currently. This is not the actual patch, just to reproduce incorrect behaviors. Uploading fix shortly. > child documents lack _version_, susceptible to reordered delete-by-query > - > > Key: SOLR-10114 > URL: https://issues.apache.org/jira/browse/SOLR-10114 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Yonik Seeley > Attachments: SOLR-10114-validation.patch > > > It looks like when a block of documents is indexed, child documents get no > \_version\_ field. This means (among other potential issues) that a > delete-by-query that is reordered will cause matching child documents to be > deleted. DBQ normally prevents deleting newer docs by including a > restriction on \_version\_, which doesn't work for anything lacking that > field. Re-ordered delete-by-term of any child docs would also be affected > (although it should be a much rarer issue.) > The leading candidate for a fix is to use the exact same \_version\_ for all > child docs. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
