[jira] [Updated] (SOLR-10628) Less verbose output from bin/solr create
[
https://issues.apache.org/jira/browse/SOLR-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-10628:
---
Attachment: SOLR-10628.patch
Attaching updated patch
* Call {{StartupLogginUtils.changeLogLevel}} to keep log modification in one
place. Also moved that class to o.a.s.util and made it public
* Tested on my Mac, works like a charm
Thanks Jason, I'll commit this now for 7.1
> Less verbose output from bin/solr create
>
>
> Key: SOLR-10628
> URL: https://issues.apache.org/jira/browse/SOLR-10628
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Reporter: Jan Høydahl
>Assignee: Jan Høydahl
> Fix For: master (8.0), 7.1
>
> Attachments: SOLR-10628.patch, SOLR-10628.patch, SOLR-10628.patch,
> SOLR-10628.patch, SOLR-10628.patch, solr_script_outputs.txt,
> updated_command_output.txt
>
>
> Creating a collection with {{bin/solr create}} today is too verbose:
> {noformat}
> $ bin/solr create -c foo
> Connecting to ZooKeeper at localhost:9983 ...
> INFO - 2017-05-08 09:06:54.409;
> org.apache.solr.client.solrj.impl.ZkClientClusterStateProvider; Cluster at
> localhost:9983 ready
> Uploading
> /Users/janhoy/git/lucene-solr/solr/server/solr/configsets/data_driven_schema_configs/conf
> for config foo to ZooKeeper at localhost:9983
> Creating new collection 'foo' using command:
> http://localhost:8983/solr/admin/collections?action=CREATE&name=foo&numShards=1&replicationFactor=1&maxShardsPerNode=1&collection.configName=foo
> {
> "responseHeader":{
> "status":0,
> "QTime":4178},
> "success":{"192.168.127.248:8983_solr":{
> "responseHeader":{
> "status":0,
> "QTime":2959},
> "core":"foo_shard1_replica1"}}}
> {noformat}
> A normal user don't need all this info. Propose to move all the details to
> verbose mode ({{-V)}} and let the default be the following instead:
> {noformat}
> $ bin/solr create -c foo
> Connecting to ZooKeeper at localhost:9983 ...
> Created collection 'foo' with 1 shard(s), 1 replica(s) using config-set
> 'data_driven_schema_configs'
> {noformat}
> Error messages must of course still be verbose.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10628) Less verbose output from bin/solr create
[
https://issues.apache.org/jira/browse/SOLR-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-10628:
---
Fix Version/s: 7.1
master (8.0)
> Less verbose output from bin/solr create
>
>
> Key: SOLR-10628
> URL: https://issues.apache.org/jira/browse/SOLR-10628
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Reporter: Jan Høydahl
>Assignee: Jan Høydahl
> Fix For: master (8.0), 7.1
>
> Attachments: SOLR-10628.patch, SOLR-10628.patch, SOLR-10628.patch,
> SOLR-10628.patch, solr_script_outputs.txt, updated_command_output.txt
>
>
> Creating a collection with {{bin/solr create}} today is too verbose:
> {noformat}
> $ bin/solr create -c foo
> Connecting to ZooKeeper at localhost:9983 ...
> INFO - 2017-05-08 09:06:54.409;
> org.apache.solr.client.solrj.impl.ZkClientClusterStateProvider; Cluster at
> localhost:9983 ready
> Uploading
> /Users/janhoy/git/lucene-solr/solr/server/solr/configsets/data_driven_schema_configs/conf
> for config foo to ZooKeeper at localhost:9983
> Creating new collection 'foo' using command:
> http://localhost:8983/solr/admin/collections?action=CREATE&name=foo&numShards=1&replicationFactor=1&maxShardsPerNode=1&collection.configName=foo
> {
> "responseHeader":{
> "status":0,
> "QTime":4178},
> "success":{"192.168.127.248:8983_solr":{
> "responseHeader":{
> "status":0,
> "QTime":2959},
> "core":"foo_shard1_replica1"}}}
> {noformat}
> A normal user don't need all this info. Propose to move all the details to
> verbose mode ({{-V)}} and let the default be the following instead:
> {noformat}
> $ bin/solr create -c foo
> Connecting to ZooKeeper at localhost:9983 ...
> Created collection 'foo' with 1 shard(s), 1 replica(s) using config-set
> 'data_driven_schema_configs'
> {noformat}
> Error messages must of course still be verbose.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10628) Less verbose output from bin/solr create
[
https://issues.apache.org/jira/browse/SOLR-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-10628:
---
Attachment: SOLR-10628.patch
Latest patch makes similar changes to solr.cmd, the Windows version of the
script.
I did test out each command on a borrowed Windows box to verify that the output
looked appropriate. That said, I'd appreciate it if anyone could give me a
double check on the Windows side of things, as I'm not nearly as familiar with
the subtleties of the Windows batch scripting language as I am with {{bash}}.
Tests and precommit pass.
> Less verbose output from bin/solr create
>
>
> Key: SOLR-10628
> URL: https://issues.apache.org/jira/browse/SOLR-10628
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Reporter: Jan Høydahl
>Assignee: Jan Høydahl
> Attachments: SOLR-10628.patch, SOLR-10628.patch, SOLR-10628.patch,
> SOLR-10628.patch, solr_script_outputs.txt, updated_command_output.txt
>
>
> Creating a collection with {{bin/solr create}} today is too verbose:
> {noformat}
> $ bin/solr create -c foo
> Connecting to ZooKeeper at localhost:9983 ...
> INFO - 2017-05-08 09:06:54.409;
> org.apache.solr.client.solrj.impl.ZkClientClusterStateProvider; Cluster at
> localhost:9983 ready
> Uploading
> /Users/janhoy/git/lucene-solr/solr/server/solr/configsets/data_driven_schema_configs/conf
> for config foo to ZooKeeper at localhost:9983
> Creating new collection 'foo' using command:
> http://localhost:8983/solr/admin/collections?action=CREATE&name=foo&numShards=1&replicationFactor=1&maxShardsPerNode=1&collection.configName=foo
> {
> "responseHeader":{
> "status":0,
> "QTime":4178},
> "success":{"192.168.127.248:8983_solr":{
> "responseHeader":{
> "status":0,
> "QTime":2959},
> "core":"foo_shard1_replica1"}}}
> {noformat}
> A normal user don't need all this info. Propose to move all the details to
> verbose mode ({{-V)}} and let the default be the following instead:
> {noformat}
> $ bin/solr create -c foo
> Connecting to ZooKeeper at localhost:9983 ...
> Created collection 'foo' with 1 shard(s), 1 replica(s) using config-set
> 'data_driven_schema_configs'
> {noformat}
> Error messages must of course still be verbose.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10628) Less verbose output from bin/solr create
[
https://issues.apache.org/jira/browse/SOLR-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated SOLR-10628:
---
Component/s: scripts and tools
> Less verbose output from bin/solr create
>
>
> Key: SOLR-10628
> URL: https://issues.apache.org/jira/browse/SOLR-10628
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Reporter: Jan Høydahl
>Assignee: Jan Høydahl
> Attachments: SOLR-10628.patch, SOLR-10628.patch, SOLR-10628.patch,
> solr_script_outputs.txt, updated_command_output.txt
>
>
> Creating a collection with {{bin/solr create}} today is too verbose:
> {noformat}
> $ bin/solr create -c foo
> Connecting to ZooKeeper at localhost:9983 ...
> INFO - 2017-05-08 09:06:54.409;
> org.apache.solr.client.solrj.impl.ZkClientClusterStateProvider; Cluster at
> localhost:9983 ready
> Uploading
> /Users/janhoy/git/lucene-solr/solr/server/solr/configsets/data_driven_schema_configs/conf
> for config foo to ZooKeeper at localhost:9983
> Creating new collection 'foo' using command:
> http://localhost:8983/solr/admin/collections?action=CREATE&name=foo&numShards=1&replicationFactor=1&maxShardsPerNode=1&collection.configName=foo
> {
> "responseHeader":{
> "status":0,
> "QTime":4178},
> "success":{"192.168.127.248:8983_solr":{
> "responseHeader":{
> "status":0,
> "QTime":2959},
> "core":"foo_shard1_replica1"}}}
> {noformat}
> A normal user don't need all this info. Propose to move all the details to
> verbose mode ({{-V)}} and let the default be the following instead:
> {noformat}
> $ bin/solr create -c foo
> Connecting to ZooKeeper at localhost:9983 ...
> Created collection 'foo' with 1 shard(s), 1 replica(s) using config-set
> 'data_driven_schema_configs'
> {noformat}
> Error messages must of course still be verbose.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10628) Less verbose output from bin/solr create
[
https://issues.apache.org/jira/browse/SOLR-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-10628:
---
Attachment: updated_command_output.txt
SOLR-10628.patch
Attached a patch with the changes discussed above.
Also attached a text file with examples of the new outputs, just in case there
was any miscommunication.
> Less verbose output from bin/solr create
>
>
> Key: SOLR-10628
> URL: https://issues.apache.org/jira/browse/SOLR-10628
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Jan Høydahl
>Assignee: Jan Høydahl
> Attachments: SOLR-10628.patch, SOLR-10628.patch, SOLR-10628.patch,
> solr_script_outputs.txt, updated_command_output.txt
>
>
> Creating a collection with {{bin/solr create}} today is too verbose:
> {noformat}
> $ bin/solr create -c foo
> Connecting to ZooKeeper at localhost:9983 ...
> INFO - 2017-05-08 09:06:54.409;
> org.apache.solr.client.solrj.impl.ZkClientClusterStateProvider; Cluster at
> localhost:9983 ready
> Uploading
> /Users/janhoy/git/lucene-solr/solr/server/solr/configsets/data_driven_schema_configs/conf
> for config foo to ZooKeeper at localhost:9983
> Creating new collection 'foo' using command:
> http://localhost:8983/solr/admin/collections?action=CREATE&name=foo&numShards=1&replicationFactor=1&maxShardsPerNode=1&collection.configName=foo
> {
> "responseHeader":{
> "status":0,
> "QTime":4178},
> "success":{"192.168.127.248:8983_solr":{
> "responseHeader":{
> "status":0,
> "QTime":2959},
> "core":"foo_shard1_replica1"}}}
> {noformat}
> A normal user don't need all this info. Propose to move all the details to
> verbose mode ({{-V)}} and let the default be the following instead:
> {noformat}
> $ bin/solr create -c foo
> Connecting to ZooKeeper at localhost:9983 ...
> Created collection 'foo' with 1 shard(s), 1 replica(s) using config-set
> 'data_driven_schema_configs'
> {noformat}
> Error messages must of course still be verbose.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10628) Less verbose output from bin/solr create
[
https://issues.apache.org/jira/browse/SOLR-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-10628:
---
Attachment: solr_script_outputs.txt
I've attached a text file with the "normal" output for each of the {{bin/solr}}
commands. Figured it'd be a useful reference as we're tweaking the normal and
"verbose" outputs.
Some notes on the attached outputs:
- many commands have identical "Connecting to ZooKeeper at" lines that probably
best belong in verbose mode. We should probably change each of these to
verbose-mode-only
- {{start}}/{{stop}}/{{restart}} have a "... waiting up to 180 seconds"
message. We _could_ move this to verbose mode, though my personal opinion is
that it's helpful enough to leave as-is for those commands. I'll defer to your
preference though if you'd like to see that changed to display only in
"verbose" mode.
- {{delete}} has output very similar to {{create}} (without our patch). I'd
propose we should make the same changes to {{delete}} as we did to {{create}}
- {{auth}} is pretty chatty. I'd propose we move the printing of security.json
to only occur in verbose mode.
I'll plan on uploading a patch tomorrow with the tentative changes mentioned
above, pending feedback from anyone here.
> Less verbose output from bin/solr create
>
>
> Key: SOLR-10628
> URL: https://issues.apache.org/jira/browse/SOLR-10628
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Jan Høydahl
>Assignee: Jan Høydahl
> Attachments: SOLR-10628.patch, SOLR-10628.patch,
> solr_script_outputs.txt
>
>
> Creating a collection with {{bin/solr create}} today is too verbose:
> {noformat}
> $ bin/solr create -c foo
> Connecting to ZooKeeper at localhost:9983 ...
> INFO - 2017-05-08 09:06:54.409;
> org.apache.solr.client.solrj.impl.ZkClientClusterStateProvider; Cluster at
> localhost:9983 ready
> Uploading
> /Users/janhoy/git/lucene-solr/solr/server/solr/configsets/data_driven_schema_configs/conf
> for config foo to ZooKeeper at localhost:9983
> Creating new collection 'foo' using command:
> http://localhost:8983/solr/admin/collections?action=CREATE&name=foo&numShards=1&replicationFactor=1&maxShardsPerNode=1&collection.configName=foo
> {
> "responseHeader":{
> "status":0,
> "QTime":4178},
> "success":{"192.168.127.248:8983_solr":{
> "responseHeader":{
> "status":0,
> "QTime":2959},
> "core":"foo_shard1_replica1"}}}
> {noformat}
> A normal user don't need all this info. Propose to move all the details to
> verbose mode ({{-V)}} and let the default be the following instead:
> {noformat}
> $ bin/solr create -c foo
> Connecting to ZooKeeper at localhost:9983 ...
> Created collection 'foo' with 1 shard(s), 1 replica(s) using config-set
> 'data_driven_schema_configs'
> {noformat}
> Error messages must of course still be verbose.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10628) Less verbose output from bin/solr create
[
https://issues.apache.org/jira/browse/SOLR-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-10628:
---
Attachment: SOLR-10628.patch
Oh, sorry to overlap your effort. I'm never sure whether to interpret the
"Assigned" field as meaning: "I'm actively working on this", or "I'm interested
enough in this to start it eventually, or will review whatever someone else
comes up with". Different people seem to mean different things.
Anyways, I've made the change you suggested regarding the "Connecting to
ZooKeeper" output. Feel free to use your own version if you prefer it.
Tests and precommit still pass.
> Less verbose output from bin/solr create
>
>
> Key: SOLR-10628
> URL: https://issues.apache.org/jira/browse/SOLR-10628
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Jan Høydahl
>Assignee: Jan Høydahl
> Attachments: SOLR-10628.patch, SOLR-10628.patch
>
>
> Creating a collection with {{bin/solr create}} today is too verbose:
> {noformat}
> $ bin/solr create -c foo
> Connecting to ZooKeeper at localhost:9983 ...
> INFO - 2017-05-08 09:06:54.409;
> org.apache.solr.client.solrj.impl.ZkClientClusterStateProvider; Cluster at
> localhost:9983 ready
> Uploading
> /Users/janhoy/git/lucene-solr/solr/server/solr/configsets/data_driven_schema_configs/conf
> for config foo to ZooKeeper at localhost:9983
> Creating new collection 'foo' using command:
> http://localhost:8983/solr/admin/collections?action=CREATE&name=foo&numShards=1&replicationFactor=1&maxShardsPerNode=1&collection.configName=foo
> {
> "responseHeader":{
> "status":0,
> "QTime":4178},
> "success":{"192.168.127.248:8983_solr":{
> "responseHeader":{
> "status":0,
> "QTime":2959},
> "core":"foo_shard1_replica1"}}}
> {noformat}
> A normal user don't need all this info. Propose to move all the details to
> verbose mode ({{-V)}} and let the default be the following instead:
> {noformat}
> $ bin/solr create -c foo
> Connecting to ZooKeeper at localhost:9983 ...
> Created collection 'foo' with 1 shard(s), 1 replica(s) using config-set
> 'data_driven_schema_configs'
> {noformat}
> Error messages must of course still be verbose.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10628) Less verbose output from bin/solr create
[
https://issues.apache.org/jira/browse/SOLR-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-10628:
---
Attachment: SOLR-10628.patch
Patch demonstrating how this could be done. Tests/precommit pass.
*Notes*
- When Solr starts up, it looks at the {{solr.log.level}} system property, and
overrides the configured log-level based on that. This patch adds similar
logic to {{SolrCLI}} (but based on a "verbose" flag instead of
{{solr.log.level}}). I did the log-level overriding in this patch the same way
Solr does it on startup: via a direct call to the "forbidden" LogManager log4j
class (which then requires a SuppressForbidden annotation). This might be OK,
since it lines up with precedent elsewhere. But it might be nice to find a
better way to override the log level. Happy to receive some direction on that.
See
[StartupLoggingUtils|https://github.com/apache/lucene-solr/blob/e2521b2a8baabdaf43b92192588f51e042d21e97/solr/core/src/java/org/apache/solr/servlet/StartupLoggingUtils.java#L86]
for more context
> Less verbose output from bin/solr create
>
>
> Key: SOLR-10628
> URL: https://issues.apache.org/jira/browse/SOLR-10628
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Jan Høydahl
>Assignee: Jan Høydahl
> Attachments: SOLR-10628.patch
>
>
> Creating a collection with {{bin/solr create}} today is too verbose:
> {noformat}
> $ bin/solr create -c foo
> Connecting to ZooKeeper at localhost:9983 ...
> INFO - 2017-05-08 09:06:54.409;
> org.apache.solr.client.solrj.impl.ZkClientClusterStateProvider; Cluster at
> localhost:9983 ready
> Uploading
> /Users/janhoy/git/lucene-solr/solr/server/solr/configsets/data_driven_schema_configs/conf
> for config foo to ZooKeeper at localhost:9983
> Creating new collection 'foo' using command:
> http://localhost:8983/solr/admin/collections?action=CREATE&name=foo&numShards=1&replicationFactor=1&maxShardsPerNode=1&collection.configName=foo
> {
> "responseHeader":{
> "status":0,
> "QTime":4178},
> "success":{"192.168.127.248:8983_solr":{
> "responseHeader":{
> "status":0,
> "QTime":2959},
> "core":"foo_shard1_replica1"}}}
> {noformat}
> A normal user don't need all this info. Propose to move all the details to
> verbose mode ({{-V)}} and let the default be the following instead:
> {noformat}
> $ bin/solr create -c foo
> Connecting to ZooKeeper at localhost:9983 ...
> Created collection 'foo' with 1 shard(s), 1 replica(s) using config-set
> 'data_driven_schema_configs'
> {noformat}
> Error messages must of course still be verbose.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
