[jira] [Updated] (SOLR-2665) Solr Post Group Faceting
[ https://issues.apache.org/jira/browse/SOLR-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated SOLR-2665: Attachment: SOLR-2665.patch Attached updated patch. I hooked group.truncate into random grouping test. This revealed some bugs which have been fixed. I think we're getting close to get this committed! I think in the coming days I'll commit this feature to trunk and 3x. > Solr Post Group Faceting > > > Key: SOLR-2665 > URL: https://issues.apache.org/jira/browse/SOLR-2665 > Project: Solr > Issue Type: New Feature >Affects Versions: 3.3 >Reporter: Bill Bell >Assignee: Martijn van Groningen > Fix For: 3.4, 4.0 > > Attachments: SOLR-2665.patch, SOLR-2665.patch, SOLR-2665.patch, > SOLR-2665.patch > > > Once Lucene is wired, add this feature to Solr. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-2665) Solr Post Group Faceting
[ https://issues.apache.org/jira/browse/SOLR-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated SOLR-2665: Attachment: SOLR-2665.patch Updated the patch. * The parameter name has changed from group.after to group.truncate. * Also removed the changes in testGroupingSortByFunction test method. > Solr Post Group Faceting > > > Key: SOLR-2665 > URL: https://issues.apache.org/jira/browse/SOLR-2665 > Project: Solr > Issue Type: New Feature >Affects Versions: 3.3 >Reporter: Bill Bell >Assignee: Martijn van Groningen > Fix For: 3.4, 4.0 > > Attachments: SOLR-2665.patch, SOLR-2665.patch, SOLR-2665.patch > > > Once Lucene is wired, add this feature to Solr. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-2665) Solr Post Group Faceting
[ https://issues.apache.org/jira/browse/SOLR-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomás Fernández Löbbe updated SOLR-2665: Attachment: SOLR-2665.patch Martijn, current patch breaks when the group field is not a String and there is no specific sort. This is the stacktrace of the Exception: java.lang.NullPointerException at org.apache.solr.search.Grouping$FunctionAllGroupHeadsCollector.(Grouping.java:1156) at org.apache.solr.search.Grouping$CommandFunc.createAllGroupCollector(Grouping.java:920) at org.apache.solr.search.Grouping.execute(Grouping.java:317) at org.apache.solr.handler.component.QueryComponent.process(QueryComponent.java:376) at org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:194) at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:129) at org.apache.solr.core.SolrCore.execute(SolrCore.java:1401) at org.apache.solr.servlet.SolrDispatchFilter.execute(SolrDispatchFilter.java:353) at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:248) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:399) at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766) at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450) at org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230) at org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:114) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152) at org.mortbay.jetty.Server.handle(Server.java:326) at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542) at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:928) at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:549) at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212) at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404) at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228) at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582) I got to this exception by using Solr's example schema/data and this request: http://localhost:8983/solr/select?q=*:*&group=true&group.field=popularity&facet.field=inStock&facet=true&group.after=true I'm uploading a patch isolating this error and a fix. Also, I don't know why, but the test case testGroupingSortByFunction with the extra line you added on the previous patch assertU(add(doc("id", "6", "value1_i", "1", "value2_i", "5", "store", "45.18014,-93.87746"))); didn't run correctly for me, I'm not sure why should it run. I didn't touch that line but that test doesn't run for me. > Solr Post Group Faceting > > > Key: SOLR-2665 > URL: https://issues.apache.org/jira/browse/SOLR-2665 > Project: Solr > Issue Type: New Feature >Affects Versions: 3.3 >Reporter: Bill Bell >Assignee: Martijn van Groningen > Fix For: 3.4, 4.0 > > Attachments: SOLR-2665.patch, SOLR-2665.patch > > > Once Lucene is wired, add this feature to Solr. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-2665) Solr Post Group Faceting
[ https://issues.apache.org/jira/browse/SOLR-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated SOLR-2665: Attachment: SOLR-2665.patch Added initial patch with basic test. You can enable post grouping facets and post grouping statistics by using the following parameter: group.after=true|false The default is false. Better names are welcome. I initially wanted to name it group.groupBasedDocSet. Because the DocSet used by faceting and statistics is based on groups. The docset is computed based on the first field / func command. > Solr Post Group Faceting > > > Key: SOLR-2665 > URL: https://issues.apache.org/jira/browse/SOLR-2665 > Project: Solr > Issue Type: New Feature >Affects Versions: 3.3 >Reporter: Bill Bell >Assignee: Martijn van Groningen > Fix For: 3.4, 4.0 > > Attachments: SOLR-2665.patch > > > Once Lucene is wired, add this feature to Solr. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-2665) Solr Post Group Faceting
[ https://issues.apache.org/jira/browse/SOLR-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated SOLR-2665: Fix Version/s: 4.0 3.4 Assignee: Martijn van Groningen > Solr Post Group Faceting > > > Key: SOLR-2665 > URL: https://issues.apache.org/jira/browse/SOLR-2665 > Project: Solr > Issue Type: New Feature >Affects Versions: 3.3 >Reporter: Bill Bell >Assignee: Martijn van Groningen > Fix For: 3.4, 4.0 > > > Once Lucene is wired, add this feature to Solr. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org