Re: [jira] [Commented] (LUCENE-8809) Refresh and rollback concurrently can leave segment states unclosed

2019-05-23 Thread Nhat Nguyen
Hi Andrzej,

Please revert that commit. Thank you!

Nhat

> On May 23, 2019, at 11:59 AM, Andrzej Białecki  wrote:
> 
> Hi Nhat,
> 
> Commits to branch_8_1 are not allowed now due to the fact that this branch is 
> used for the 8.1.1 release - any critical bug fixes should be first submitted 
> to JIRA as a patch and approved by the release coordinator (in this case me). 
> Please revert your latest commit from branch_8_1.
> 
> 
> 
>> On 23 May 2019, at 17:51, ASF subversion and git services (JIRA) 
>>  wrote:
>> 
>> 
>>   [ 
>> https://issues.apache.org/jira/browse/LUCENE-8809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846812#comment-16846812
>>  ] 
>> 
>> ASF subversion and git services commented on LUCENE-8809:
>> -
>> 
>> Commit 2e16009197ac10149a53eb97e875f89bd3a75472 in lucene-solr's branch 
>> refs/heads/branch_8_1 from Nhat Nguyen
>> [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=2e16009 ]
>> 
>> LUCENE-8809: Ensure release segment states
>> 
>> If refresh and rollback happen concurrently, then we can leave segment
>> states unreleased leads to leaking refCount of some SegmentReaders.
>> 
>> 
>>> Refresh and rollback concurrently can leave segment states unclosed
>>> ---
>>> 
>>>   Key: LUCENE-8809
>>>   URL: https://issues.apache.org/jira/browse/LUCENE-8809
>>>   Project: Lucene - Core
>>>Issue Type: Bug
>>>Components: core/index
>>>  Affects Versions: 7.7, 8.1, 8.2
>>>  Reporter: Nhat Nguyen
>>>  Priority: Major
>>>Time Spent: 50m
>>> Remaining Estimate: 0h
>>> 
>>> A [failed test|https://github.com/elastic/elasticsearch/issues/30290] from 
>>> Elasticsearch shows that refresh and rollback concurrently can leave 
>>> segment states unclosed leads to leaking refCount of some SegmentReaders.
>> 
>> 
>> 
>> --
>> This message was sent by Atlassian JIRA
>> (v7.6.3#76005)
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
>> For additional commands, e-mail: dev-h...@lucene.apache.org
>> 
> 


-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



Re: [jira] [Commented] (LUCENE-8809) Refresh and rollback concurrently can leave segment states unclosed

2019-05-23 Thread Andrzej Białecki
Hi Nhat,

Commits to branch_8_1 are not allowed now due to the fact that this branch is 
used for the 8.1.1 release - any critical bug fixes should be first submitted 
to JIRA as a patch and approved by the release coordinator (in this case me). 
Please revert your latest commit from branch_8_1.



> On 23 May 2019, at 17:51, ASF subversion and git services (JIRA) 
>  wrote:
> 
> 
>[ 
> https://issues.apache.org/jira/browse/LUCENE-8809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846812#comment-16846812
>  ] 
> 
> ASF subversion and git services commented on LUCENE-8809:
> -
> 
> Commit 2e16009197ac10149a53eb97e875f89bd3a75472 in lucene-solr's branch 
> refs/heads/branch_8_1 from Nhat Nguyen
> [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=2e16009 ]
> 
> LUCENE-8809: Ensure release segment states
> 
> If refresh and rollback happen concurrently, then we can leave segment
> states unreleased leads to leaking refCount of some SegmentReaders.
> 
> 
>> Refresh and rollback concurrently can leave segment states unclosed
>> ---
>> 
>>Key: LUCENE-8809
>>URL: https://issues.apache.org/jira/browse/LUCENE-8809
>>Project: Lucene - Core
>> Issue Type: Bug
>> Components: core/index
>>   Affects Versions: 7.7, 8.1, 8.2
>>   Reporter: Nhat Nguyen
>>   Priority: Major
>> Time Spent: 50m
>> Remaining Estimate: 0h
>> 
>> A [failed test|https://github.com/elastic/elasticsearch/issues/30290] from 
>> Elasticsearch shows that refresh and rollback concurrently can leave segment 
>> states unclosed leads to leaking refCount of some SegmentReaders.
> 
> 
> 
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: dev-h...@lucene.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org