Re: FYI Zookeeper.sync()

2018-04-19 Thread Chris Hostetter
: Thanks; I can definitely appreciate that Watchers (or more generally the : idea of chaining async callbacks) is usually a more suitable mechanism than : calling sync(). I've also seen some code patterns in which knowledge of To be clear: i'm not suggesting that we *don't* need sync() calls

Re: FYI Zookeeper.sync()

2018-04-19 Thread David Smiley
Thanks; I can definitely appreciate that Watchers (or more generally the idea of chaining async callbacks) is usually a more suitable mechanism than calling sync(). I've also seen some code patterns in which knowledge of the expected ZK node version can alleviate the need for doing a sync() as

Re: FYI Zookeeper.sync()

2018-04-19 Thread Chris Hostetter
IIUC, the reason you don't see any calls to sync() is because Solr's use of ZK is mostly based on Watchers? ... so we have callback functions to be notified anytime something (like leaeders, overseer, cluster state, etc...) changes and those calbacks update local copies of that state, which