Re: log4j-slf4j-impl dependency in solr-core

2019-09-14 Thread Mark Miller
Going to handle this better in the gradle build. We should either require a specific logging impl or get better at managing our logging jars (gradle is gonna help there). Solr should not rely on any slf4j impl jar. It does this for some UI stuff, but if we want to do that and properly support

Re: log4j-slf4j-impl dependency in solr-core

2019-09-14 Thread Jan Høydahl
Slf4j-api and log4j dependencies are ok. But the slf4j-to-log4j static binding jar should be in the deploy phase, not a compile-time dep. Jan Høydahl > 11. sep. 2019 kl. 17:40 skrev Shawn Heisey : > >> On 9/11/2019 4:45 AM, Jan Høydahl wrote: >> Upgrading to log4j2 in

Re: log4j-slf4j-impl dependency in solr-core

2019-09-11 Thread Shawn Heisey
On 9/11/2019 4:45 AM, Jan Høydahl wrote: Upgrading to log4j2 in https://issues.apache.org/jira/browse/SOLR-7887 added dependency on a bunch of log4j libs to solr-core, e.g. log4j-slf4j-impl which is a binding for slf4j to log using log4j. This seems wrong since people who consume solr-core